Fix RootSpanData writer interception on consecutive calls

[bwoebi]

If there's a cache_slot set, it will bypass the write handler, which very much is not what we want. NULL it to prevent assignment.

(And the assignment of an integer parentId did memory leak...)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (73e9db0) to head (f5d48dd).

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #2919   +/-   ##
=========================================
  Coverage     78.22%   78.22%           
  Complexity     2526     2526           
=========================================
  Files           135      135           
  Lines         14400    14400           
  Branches        989      989           
=========================================
  Hits          11265    11265           
  Misses         2593     2593           
  Partials        542      542           

Flag	Coverage Δ
appsec-extension	68.36% <ø> (ø)
tracer-php	82.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e9db0...f5d48dd. Read the comment docs.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2024-10-31 11:23:34

Comparing candidate commit f5d48dd in PR branch bob/fix-write-cache-handlre with baseline commit 73e9db0 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline-opcache

• 🟥 execution_time [+11.072µs; +13.160µs] or [+6.205%; +7.375%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1-opcache

• 🟥 execution_time [+227.127ns; +563.873ns] or [+3.326%; +8.258%]