Updating Default Rate Limit Value and Usage Based on Sample Rate

[link04]

Description

Updating the default value for the DD_TRACE_RATE_LIMIT from 0 to 100 to match RFC and most of all other languages and also only make use of the config when DD_TRACE_SAMPLE_RATE is set.

Related Jira: https://datadoghq.atlassian.net/browse/APMAPI-496

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (e314256) to head (92dac2b).

Additional details and impacted files

@@              Coverage Diff              @@
##             master    #2912       +/-   ##
=============================================
+ Coverage     51.81%   72.38%   +20.56%     
  Complexity     2526     2526               
=============================================
  Files           135      135               
  Lines         14400    14400               
  Branches        989      989               
=============================================
+ Hits           7462    10424     +2962     
+ Misses         6393     3433     -2960     
+ Partials        545      543        -2     

Flag	Coverage Δ
appsec-extension	68.34% <ø> (+0.17%)	⬆️
tracer-php	73.96% <ø> (+28.52%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e314256...92dac2b. Read the comment docs.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-05 19:47:29

Comparing candidate commit 92dac2b in PR branch maximo/consistent-config-rate-limit with baseline commit e314256 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline-opcache

• 🟥 execution_time [+3.581µs; +10.791µs] or [+2.002%; +6.034%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

• 🟩 execution_time [-504.195ns; -199.205ns] or [-6.978%; -2.757%]