Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad hasThis() check on PHP 7.0 #2911

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix bad hasThis() check on PHP 7.0 #2911

merged 1 commit into from
Oct 23, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 22, 2024

Capturing $this on PHP 7.0 segfaulted.

@bwoebi bwoebi requested a review from a team as a code owner October 22, 2024 21:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (dc68545) to head (5ef917f).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2911   +/-   ##
=========================================
  Coverage     78.21%   78.21%           
  Complexity     2526     2526           
=========================================
  Files           173      173           
  Lines         18752    18752           
  Branches        988      988           
=========================================
  Hits          14667    14667           
  Misses         3544     3544           
  Partials        541      541           
Flag Coverage Δ
appsec-extension 68.37% <ø> (ø)
tracer-extension 78.11% <ø> (ø)
tracer-php 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc68545...5ef917f. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-10-23 08:46:11

Comparing candidate commit 5ef917f in PR branch bob/fixhasthis with baseline commit dc68545 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟩 execution_time [-224.783µs; -68.677µs] or [-7.528%; -2.300%]

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-13.997µs; -7.940µs] or [-7.305%; -4.144%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-10.505µs; -4.795µs] or [-5.375%; -2.453%]

@bwoebi bwoebi merged commit 093ef34 into master Oct 23, 2024
675 of 699 checks passed
@bwoebi bwoebi deleted the bob/fixhasthis branch October 23, 2024 10:44
@github-actions github-actions bot added this to the 1.5.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants