Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sidecar sending on lambda #2904

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Disable sidecar sending on lambda #2904

merged 1 commit into from
Oct 18, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 18, 2024

Fixes #2289.

@bwoebi bwoebi requested a review from a team as a code owner October 18, 2024 16:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (8f7175e) to head (1641ada).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2904      +/-   ##
============================================
- Coverage     80.95%   78.21%   -2.75%     
  Complexity     2526     2526              
============================================
  Files           146      173      +27     
  Lines         14713    18751    +4038     
  Branches          0      988     +988     
============================================
+ Hits          11911    14666    +2755     
- Misses         2802     3544     +742     
- Partials          0      541     +541     
Flag Coverage Δ
appsec-extension 68.37% <ø> (?)
tracer-extension 78.10% <ø> (ø)
tracer-php 82.09% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7175e...1641ada. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Oct 18, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-10-18 21:35:51

Comparing candidate commit 1641ada in PR branch bob/no-lambda-sidecar with baseline commit 8f7175e in branch master.

Found 3 performance improvements and 1 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:BM_TeaSapiSpindown

  • 🟩 execution_time [-31.525µs; -13.411µs] or [-5.835%; -2.482%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-5.556µs; -4.324µs] or [-3.289%; -2.559%]

scenario:SamplingRuleMatchingBench/benchGlobMatching2

  • 🟥 execution_time [+44.129ns; +158.471ns] or [+2.024%; +7.268%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

@bwoebi bwoebi force-pushed the bob/no-lambda-sidecar branch from 04c5e06 to 1641ada Compare October 18, 2024 21:08
@bwoebi bwoebi merged commit 5b44290 into master Oct 18, 2024
659 of 699 checks passed
@bwoebi bwoebi deleted the bob/no-lambda-sidecar branch October 18, 2024 21:53
@github-actions github-actions bot added this to the 1.5.0 milestone Oct 18, 2024
@bwoebi bwoebi modified the milestones: 1.5.0, 1.4.2 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants