Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(profiling) fix actions cache #2894

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Oct 15, 2024

Description

I stumbled over the cache not being used in GitHub Actions due to a spelling error ...
So I also bumped the versions and fixed the checkout (depth: 1 is sufficient).

This reduces CI times a bit

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl changed the title fix actions cache ci(profiling) fix actions cache Oct 15, 2024
@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Oct 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (5b44290) to head (89cfe08).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2894      +/-   ##
============================================
+ Coverage     78.21%   80.91%   +2.70%     
  Complexity     2526     2526              
============================================
  Files           173      146      -27     
  Lines         18751    14713    -4038     
  Branches        988        0     -988     
============================================
- Hits          14666    11905    -2761     
+ Misses         3544     2808     -736     
+ Partials        541        0     -541     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.10% <ø> (ø)
tracer-php 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b44290...89cfe08. Read the comment docs.

@realFlowControl realFlowControl marked this pull request as ready for review October 15, 2024 07:13
@realFlowControl realFlowControl requested a review from a team as a code owner October 15, 2024 07:13
@realFlowControl realFlowControl force-pushed the florian/fix-actions-cache branch from 9d8b917 to 9bf2123 Compare October 15, 2024 07:18
@realFlowControl realFlowControl self-assigned this Oct 16, 2024
@realFlowControl realFlowControl merged commit 46173ca into master Oct 21, 2024
397 of 443 checks passed
@realFlowControl realFlowControl deleted the florian/fix-actions-cache branch October 21, 2024 08:02
@github-actions github-actions bot added this to the 1.5.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants