Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orderly helper appsec shutdown #2859

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

cataphract
Copy link
Contributor

The sent SIGUSR1 was just terminating the process.

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner September 17, 2024 14:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (17b3c7a) to head (d63c6b3).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2859      +/-   ##
============================================
- Coverage     80.94%   78.40%   -2.55%     
  Complexity     2526     2526              
============================================
  Files           146      173      +27     
  Lines         14680    18709    +4029     
  Branches          0      975     +975     
============================================
+ Hits          11883    14668    +2785     
- Misses         2797     3504     +707     
- Partials          0      537     +537     
Flag Coverage Δ
appsec-extension 69.12% <ø> (?)
tracer-extension 78.18% <ø> (ø)
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b3c7a...d63c6b3. Read the comment docs.

The sent SIGUSR1 was just terminating the process.
@cataphract cataphract force-pushed the glopes/fix-helper-exit branch from f7685aa to 6fea9c9 Compare September 17, 2024 15:25
@cataphract cataphract force-pushed the glopes/fix-helper-exit branch from bc83e5c to d63c6b3 Compare September 19, 2024 10:10
@cataphract cataphract merged commit 7088a2d into master Sep 19, 2024
692 of 695 checks passed
@cataphract cataphract deleted the glopes/fix-helper-exit branch September 19, 2024 14:13
@github-actions github-actions bot added this to the 1.4.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants