Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis tests flakiness #2848

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix Redis tests flakiness #2848

merged 1 commit into from
Sep 19, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Sep 12, 2024

Description

Fix this error

1) DDTrace\Tests\Integrations\PHPRedis\V4\PHPRedisClusterTest::testMethodsOnlySpan with data set "bgRewriteAOF" ('bgRewriteAOF', null)
RedisClusterException: Unable to send command at a specific node

Some Redis commands can fail, so we must account for this in the assertion.

So far, I've only encountered the issue with the PHPRedisClusterTest. Let's wait and see if we also need it for the regular Redis client.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (ebaa1ca) to head (6759fad).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2848   +/-   ##
=========================================
  Coverage     81.06%   81.06%           
  Complexity     2516     2516           
=========================================
  Files           146      146           
  Lines         14653    14653           
=========================================
  Hits          11879    11879           
  Misses         2774     2774           
Flag Coverage Δ
tracer-extension 78.18% <ø> (ø)
tracer-php 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaa1ca...6759fad. Read the comment docs.

@iamluc iamluc marked this pull request as ready for review September 12, 2024 15:00
@iamluc iamluc requested a review from a team as a code owner September 12, 2024 15:00
@iamluc iamluc merged commit f68f334 into master Sep 19, 2024
643 of 645 checks passed
@iamluc iamluc deleted the luc/fix-redis-tests branch September 19, 2024 08:13
@github-actions github-actions bot added this to the 1.4.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants