Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): Update Octokit to 13.0.1 #2779

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Jul 29, 2024

Description

There was an upstream issue fixed by octokit/octokit.net#2893 (part of the 13.0.1 release of Octokit)

This should fix the issues that we can see in the most recent PRs (e.g., #2777 --> failure).

There must have been some breaking changes along the way, hence the parameter name changes.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.53%. Comparing base (53684ab) to head (3776b5f).

❗ There is a different number of reports uploaded between BASE (53684ab) and HEAD (3776b5f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (53684ab) HEAD (3776b5f)
tracer-php 11 9
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2779      +/-   ##
============================================
- Coverage     78.24%   68.53%   -9.72%     
  Complexity     2459     2459              
============================================
  Files           204      204              
  Lines         23769    23769              
============================================
- Hits          18599    16289    -2310     
- Misses         5170     7480    +2310     
Flag Coverage Δ
tracer-extension 78.60% <ø> (ø)
tracer-php 54.76% <ø> (-23.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53684ab...3776b5f. Read the comment docs.

Copy link

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

1 occurrences of :

- "parent_id": 7077300158957851981
+ "parent_id": 7077300158957851980

@PROFeNoM PROFeNoM self-assigned this Jul 29, 2024
@PROFeNoM PROFeNoM added 🐛 bug Something isn't working ci labels Jul 29, 2024
@PROFeNoM PROFeNoM marked this pull request as ready for review July 29, 2024 12:06
@PROFeNoM PROFeNoM requested a review from a team as a code owner July 29, 2024 12:06
@PROFeNoM PROFeNoM merged commit b54b95f into master Jul 29, 2024
385 of 424 checks passed
@PROFeNoM PROFeNoM deleted the alex/fix/snapshot-check branch July 29, 2024 12:27
@github-actions github-actions bot added this to the 1.3.0 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants