-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: execute CI workflows based on which files are modified #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrisonlevi
force-pushed
the
levi/ci-filtering
branch
from
May 19, 2023 22:21
ae31599
to
570de6d
Compare
bwoebi
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trusting that it's working, and the pipeline conditions seem sensible.
morrisonlevi
changed the title
build(ci): execute workflows based on which files are modified
build: execute workflows based on which files are modified
May 24, 2023
morrisonlevi
changed the title
build: execute workflows based on which files are modified
build: execute CI workflows based on which files are modified
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses CircleCI's dynamic configuration to execute specific workflows based on which files are modified. It does this by comparing the changed files to the
master
branch, so in a stacked PR scenario, you may run more tests than you expect.The
build
andbuild_packages
workflows are on by default, and currently no rules disable them. The workflows which are enabled this way are:Note that the eclint job is broken when ran from a CircleCI continuation because of the gulp-reporter, which hard-codes the configuration as
.circleci/config.yml
, which is broken by using.circleci/continue_config.yml
. It seems eclint is unmaintained, and has been for around 5 years now. We could copy the lint job to the main workflow if we want, or we could drop theeclint
check instead. For now I have removed it.These PRs demonstrate the filters work correctly for the relevant workflows (but disabled the build workflows to save credits, as they aren't needed).
components/
dir changes #2066ext/handlers_api.h
changes #2067zend_abstract_interface
changes #2068Readiness checklist
Tests added for this feature/bug.Draft PRs test the job continuations, but this just a one time test.Reviewer checklist