-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support for node 16 in preparation for v5 release #3905
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3905 +/- ##
==========================================
- Coverage 84.70% 84.55% -0.15%
==========================================
Files 237 235 -2
Lines 10147 9972 -175
Branches 33 33
==========================================
- Hits 8595 8432 -163
+ Misses 1552 1540 -12 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-01-03 14:50:45 Comparing candidate commit b57ae28 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics. |
Overall package sizeSelf size: 5.82 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
4f72ce6
to
341efbe
Compare
d7d48d6
to
2435682
Compare
e723572
to
8787ac5
Compare
8787ac5
to
b92bfea
Compare
b92bfea
to
e547bfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small suggestion.
044f0dd
to
b57ae28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 from profiling
From a Serverless perspective, we are locked into supporting node 16 until at least June 2024. This is similar to what happened with node 14 support, where we were locked to using the v3 releases. Are we just dropping support because node 16 is no longer LTS? |
Yes, ideally this release was supposed to happen a few months ago when Node 16 was officially no longer LTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to not block the v5
release, everything looks good on the Serverless side, but we'd be pinned to the v4
line until August 2024 – date where AWS will drop support for Node 16 AWS Lambdas.
What does this PR do?
drops support for node 16
Motivation
v5 release of the tracer