Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nextjs 13.2 #2911

Closed
wants to merge 1 commit into from
Closed

Support nextjs 13.2 #2911

wants to merge 1 commit into from

Conversation

selimb
Copy link
Contributor

@selimb selimb commented Mar 17, 2023

What does this PR do?

Support next >= 13.2.

Motivation

As mentioned in #2834 (comment), the instrumentation doesn't work for next >= 13.2 because the API has been reworked.

Plugin Checklist

  • Unit tests.

@selimb selimb requested a review from a team as a code owner March 17, 2023 13:39
@@ -38,6 +38,19 @@ function wrapHandleApiRequest (handleApiRequest) {
}
}

function wrapHandleApiRequest2 (handleApiRequest) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure what to name this. Suggestions welcome!

@rochdev
Copy link
Member

rochdev commented Mar 17, 2023

Thanks for the PR! It looks however like #2905 was opened first and is a bit different. Can you add a review to that one instead?

@selimb
Copy link
Contributor Author

selimb commented Mar 17, 2023

Thanks for the PR! It looks however like #2905 was opened first and is a bit different. Can you add a review to that one instead?

Lol! I hadn't noticed, sorry. Yup I'll take a look.

@selimb selimb closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants