[ci-visibility] Link CI Visibility and RUM #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
juan-fernandez
changed the title
rochdev
previously approved these changes
Dec 9, 2021
|
could you have another look @rochdev ? I only changed the way we pass the trace id to decimal: 700b499. This is the way the event platform provides the trace id, and changing from hex to decimal and viceversa is a problem with big numbers in javascript, so it's better to just stick with that format. I also merged |
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 157 157
Lines 6652 6655 +3
=======================================
+ Hits 6219 6222 +3
Misses 433 433
Continue to review full report at Codecov.
|
rochdev
approved these changes
Jan 3, 2022
juan-fernandez
deleted the
juan-fernandez/cypress-browser-instrumentation
branch
khanayan123
pushed a commit
that referenced
this pull request
Jan 10, 2022
juan-fernandez
added a commit
that referenced
this pull request
Jan 21, 2022
Merged
rochdev
pushed a commit
that referenced
this pull request
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test.is_rum_activeif RUM is active.beforeunloadevent after test suite is finished to make sure RUM events are flushed.Motivation
Link CI Visibility and RUM
Plugin Checklist
Additional Notes