Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Platform.GC code #8115

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Remove unused Platform.GC code #8115

merged 2 commits into from
Dec 19, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Dec 19, 2024

... and add warning about accessing JMX too early

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…arly
@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Dec 19, 2024
@mcculls mcculls requested a review from a team as a code owner December 19, 2024 10:13
@mcculls mcculls requested a review from ygree December 19, 2024 10:13
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-platform-gc
git_commit_date 1734602177 1734632610
git_commit_sha 90899e0 6f3c3ba
release_version 1.45.0-SNAPSHOT~90899e0ddd 1.45.0-SNAPSHOT~6f3c3ba83a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734635121 1734635121
ci_job_id 746153076 746153076
ci_pipeline_id 51597027 51597027
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 6 performance regressions! Performance is the same for 50 metrics, 7 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:Telemetry worse
[+686.474µs; +917.483µs] or [+9.211%; +12.310%]
8.255ms 7.453ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Telemetry worse
[+0.830ms; +1.321ms] or [+11.294%; +17.981%]
8.421ms 7.345ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry worse
[+762.629µs; +1119.123µs] or [+10.435%; +15.313%]
8.249ms 7.308ms
scenario:startup:insecure-bank:tracing:Telemetry worse
[+830.528µs; +1158.801µs] or [+10.508%; +14.661%]
8.899ms 7.904ms
scenario:startup:petclinic:iast:Telemetry worse
[+610.099µs; +842.969µs] or [+8.213%; +11.348%]
8.155ms 7.428ms
scenario:startup:petclinic:tracing:Telemetry worse
[+0.887ms; +1.141ms] or [+11.304%; +14.533%]
8.863ms 7.849ms
Startup time reports for petclinic
Loading
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~6f3c3ba83a, baseline=1.45.0-SNAPSHOT~90899e0ddd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.107 s) : 0, 1106750
Total [baseline] (10.555 s) : 0, 10554999
Agent [candidate] (1.11 s) : 0, 1110039
Total [candidate] (10.456 s) : 0, 10456243
section appsec
Agent [baseline] (1.239 s) : 0, 1238710
Total [baseline] (10.718 s) : 0, 10718043
Agent [candidate] (1.249 s) : 0, 1249376
Total [candidate] (10.704 s) : 0, 10703552
section iast
Agent [baseline] (1.236 s) : 0, 1236374
Total [baseline] (10.95 s) : 0, 10950158
Agent [candidate] (1.246 s) : 0, 1246219
Total [candidate] (10.966 s) : 0, 10965706
section profiling
Agent [baseline] (1.326 s) : 0, 1326345
Total [baseline] (10.782 s) : 0, 10781773
Agent [candidate] (1.34 s) : 0, 1339766
Total [candidate] (10.852 s) : 0, 10852196
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.107 s -
Agent appsec 1.239 s 131.96 ms (11.9%)
Agent iast 1.236 s 129.624 ms (11.7%)
Agent profiling 1.326 s 219.595 ms (19.8%)
Total tracing 10.555 s -
Total appsec 10.718 s 163.044 ms (1.5%)
Total iast 10.95 s 395.158 ms (3.7%)
Total profiling 10.782 s 226.773 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.11 s -
Agent appsec 1.249 s 139.337 ms (12.6%)
Agent iast 1.246 s 136.18 ms (12.3%)
Agent profiling 1.34 s 229.727 ms (20.7%)
Total tracing 10.456 s -
Total appsec 10.704 s 247.309 ms (2.4%)
Total iast 10.966 s 509.463 ms (4.9%)
Total profiling 10.852 s 395.953 ms (3.8%)
Loading
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~6f3c3ba83a, baseline=1.45.0-SNAPSHOT~90899e0ddd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.751 ms) : 0, 712751
BytebuddyAgent [candidate] (711.703 ms) : 0, 711703
GlobalTracer [baseline] (316.554 ms) : 0, 316554
GlobalTracer [candidate] (318.646 ms) : 0, 318646
AppSec [baseline] (55.071 ms) : 0, 55071
AppSec [candidate] (55.217 ms) : 0, 55217
Remote Config [baseline] (679.157 µs) : 0, 679
Remote Config [candidate] (679.572 µs) : 0, 680
Telemetry [baseline] (7.849 ms) : 0, 7849
Telemetry [candidate] (8.863 ms) : 0, 8863
section appsec
BytebuddyAgent [baseline] (725.525 ms) : 0, 725525
BytebuddyAgent [candidate] (730.058 ms) : 0, 730058
GlobalTracer [baseline] (312.565 ms) : 0, 312565
GlobalTracer [candidate] (315.865 ms) : 0, 315865
AppSec [baseline] (166.463 ms) : 0, 166463
AppSec [candidate] (168.676 ms) : 0, 168676
IAST [baseline] (19.331 ms) : 0, 19331
IAST [candidate] (19.837 ms) : 0, 19837
Remote Config [baseline] (660.799 µs) : 0, 661
Remote Config [candidate] (968.969 µs) : 0, 969
Telemetry [baseline] (10.102 ms) : 0, 10102
Telemetry [candidate] (8.94 ms) : 0, 8940
section iast
BytebuddyAgent [baseline] (829.076 ms) : 0, 829076
BytebuddyAgent [candidate] (833.742 ms) : 0, 833742
GlobalTracer [baseline] (308.009 ms) : 0, 308009
GlobalTracer [candidate] (310.908 ms) : 0, 310908
AppSec [baseline] (56.386 ms) : 0, 56386
AppSec [candidate] (56.884 ms) : 0, 56884
IAST [baseline] (21.04 ms) : 0, 21040
IAST [candidate] (20.854 ms) : 0, 20854
Remote Config [baseline] (616.471 µs) : 0, 616
Remote Config [candidate] (592.362 µs) : 0, 592
Telemetry [baseline] (7.428 ms) : 0, 7428
Telemetry [candidate] (8.155 ms) : 0, 8155
section profiling
BytebuddyAgent [baseline] (700.66 ms) : 0, 700660
BytebuddyAgent [candidate] (701.144 ms) : 0, 701144
GlobalTracer [baseline] (429.481 ms) : 0, 429481
GlobalTracer [candidate] (440.166 ms) : 0, 440166
AppSec [baseline] (54.325 ms) : 0, 54325
AppSec [candidate] (54.064 ms) : 0, 54064
Remote Config [baseline] (651.799 µs) : 0, 652
Remote Config [candidate] (662.4 µs) : 0, 662
Telemetry [baseline] (7.716 ms) : 0, 7716
Telemetry [candidate] (7.829 ms) : 0, 7829
ProfilingAgent [baseline] (94.128 ms) : 0, 94128
ProfilingAgent [candidate] (94.255 ms) : 0, 94255
Profiling [baseline] (94.151 ms) : 0, 94151
Profiling [candidate] (94.279 ms) : 0, 94279
Startup time reports for insecure-bank
Loading
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~6f3c3ba83a, baseline=1.45.0-SNAPSHOT~90899e0ddd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.115 s) : 0, 1115178
Total [baseline] (8.663 s) : 0, 8662519
Agent [candidate] (1.112 s) : 0, 1111814
Total [candidate] (8.746 s) : 0, 8746384
section iast
Agent [baseline] (1.233 s) : 0, 1233276
Total [baseline] (9.248 s) : 0, 9247564
Agent [candidate] (1.246 s) : 0, 1245863
Total [candidate] (9.236 s) : 0, 9236180
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.231 s) : 0, 1231391
Total [baseline] (9.194 s) : 0, 9193905
Agent [candidate] (1.248 s) : 0, 1248318
Total [candidate] (9.293 s) : 0, 9292984
section iast_TELEMETRY_OFF
Agent [baseline] (1.225 s) : 0, 1225049
Total [baseline] (9.175 s) : 0, 9174597
Agent [candidate] (1.238 s) : 0, 1238294
Total [candidate] (9.24 s) : 0, 9239796
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.115 s -
Agent iast 1.233 s 118.097 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.231 s 116.213 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.225 s 109.871 ms (9.9%)
Total tracing 8.663 s -
Total iast 9.248 s 585.045 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.194 s 531.386 ms (6.1%)
Total iast_TELEMETRY_OFF 9.175 s 512.078 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.112 s -
Agent iast 1.246 s 134.049 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.248 s 136.504 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.238 s 126.48 ms (11.4%)
Total tracing 8.746 s -
Total iast 9.236 s 489.797 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.293 s 546.6 ms (6.2%)
Total iast_TELEMETRY_OFF 9.24 s 493.412 ms (5.6%)
Loading
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~6f3c3ba83a, baseline=1.45.0-SNAPSHOT~90899e0ddd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.362 ms) : 0, 719362
BytebuddyAgent [candidate] (713.145 ms) : 0, 713145
GlobalTracer [baseline] (317.685 ms) : 0, 317685
GlobalTracer [candidate] (318.802 ms) : 0, 318802
AppSec [baseline] (55.576 ms) : 0, 55576
AppSec [candidate] (55.317 ms) : 0, 55317
Remote Config [baseline] (677.024 µs) : 0, 677
Remote Config [candidate] (668.354 µs) : 0, 668
Telemetry [baseline] (7.904 ms) : 0, 7904
Telemetry [candidate] (8.899 ms) : 0, 8899
section iast
BytebuddyAgent [baseline] (828.431 ms) : 0, 828431
BytebuddyAgent [candidate] (833.358 ms) : 0, 833358
GlobalTracer [baseline] (307.484 ms) : 0, 307484
GlobalTracer [candidate] (312.731 ms) : 0, 312731
AppSec [baseline] (54.531 ms) : 0, 54531
AppSec [candidate] (54.998 ms) : 0, 54998
IAST [baseline] (20.932 ms) : 0, 20932
IAST [candidate] (20.979 ms) : 0, 20979
Remote Config [baseline] (614.37 µs) : 0, 614
Remote Config [candidate] (597.793 µs) : 0, 598
Telemetry [baseline] (7.453 ms) : 0, 7453
Telemetry [candidate] (8.255 ms) : 0, 8255
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (823.752 ms) : 0, 823752
BytebuddyAgent [candidate] (833.538 ms) : 0, 833538
GlobalTracer [baseline] (306.689 ms) : 0, 306689
GlobalTracer [candidate] (310.969 ms) : 0, 310969
AppSec [baseline] (58.476 ms) : 0, 58476
AppSec [candidate] (58.228 ms) : 0, 58228
IAST [baseline] (20.778 ms) : 0, 20778
IAST [candidate] (21.472 ms) : 0, 21472
Remote Config [baseline] (627.123 µs) : 0, 627
Remote Config [candidate] (668.47 µs) : 0, 668
Telemetry [baseline] (7.345 ms) : 0, 7345
Telemetry [candidate] (8.421 ms) : 0, 8421
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (820.396 ms) : 0, 820396
BytebuddyAgent [candidate] (824.537 ms) : 0, 824537
GlobalTracer [baseline] (305.696 ms) : 0, 305696
GlobalTracer [candidate] (310.845 ms) : 0, 310845
AppSec [baseline] (56.836 ms) : 0, 56836
AppSec [candidate] (58.332 ms) : 0, 58332
IAST [baseline] (20.466 ms) : 0, 20466
IAST [candidate] (20.837 ms) : 0, 20837
Remote Config [baseline] (643.78 µs) : 0, 644
Remote Config [candidate] (601.64 µs) : 0, 602
Telemetry [baseline] (7.308 ms) : 0, 7308
Telemetry [candidate] (8.249 ms) : 0, 8249

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-19T18:35:19 2024-12-19T18:42:16
git_branch master mcculls/remove-platform-gc
git_commit_date 1734602177 1734632610
git_commit_sha 90899e0 6f3c3ba
release_version 1.45.0-SNAPSHOT~90899e0ddd 1.45.0-SNAPSHOT~6f3c3ba83a
start_time 2024-12-19T18:35:05 2024-12-19T18:42:02
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734634090 1734634090
ci_job_id 746153077 746153077
ci_pipeline_id 51597027 51597027
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic
Loading
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~6f3c3ba83a, baseline=1.45.0-SNAPSHOT~90899e0ddd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1367
.   : milestone, 1346,
appsec (1.732 ms) : 1709, 1756
.   : milestone, 1732,
appsec_no_iast (1.746 ms) : 1721, 1771
.   : milestone, 1746,
iast (1.486 ms) : 1463, 1509
.   : milestone, 1486,
profiling (1.505 ms) : 1481, 1529
.   : milestone, 1505,
tracing (1.488 ms) : 1464, 1512
.   : milestone, 1488,
section candidate
no_agent (1.348 ms) : 1329, 1368
.   : milestone, 1348,
appsec (1.749 ms) : 1725, 1773
.   : milestone, 1749,
appsec_no_iast (1.776 ms) : 1752, 1801
.   : milestone, 1776,
iast (1.489 ms) : 1466, 1511
.   : milestone, 1489,
profiling (1.538 ms) : 1513, 1564
.   : milestone, 1538,
tracing (1.508 ms) : 1483, 1532
.   : milestone, 1508,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.367 ms] -
appsec 1.732 ms [1.709 ms, 1.756 ms] 386.008 µs (28.7%)
appsec_no_iast 1.746 ms [1.721 ms, 1.771 ms] 399.711 µs (29.7%)
iast 1.486 ms [1.463 ms, 1.509 ms] 139.675 µs (10.4%)
profiling 1.505 ms [1.481 ms, 1.529 ms] 158.669 µs (11.8%)
tracing 1.488 ms [1.464 ms, 1.512 ms] 141.255 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.368 ms] -
appsec 1.749 ms [1.725 ms, 1.773 ms] 400.339 µs (29.7%)
appsec_no_iast 1.776 ms [1.752 ms, 1.801 ms] 428.116 µs (31.8%)
iast 1.489 ms [1.466 ms, 1.511 ms] 140.447 µs (10.4%)
profiling 1.538 ms [1.513 ms, 1.564 ms] 189.905 µs (14.1%)
tracing 1.508 ms [1.483 ms, 1.532 ms] 159.172 µs (11.8%)
Request duration reports for insecure-bank
Loading
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~6f3c3ba83a, baseline=1.45.0-SNAPSHOT~90899e0ddd
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.335 µs) : 354, 395
.   : milestone, 374,
iast (490.355 µs) : 469, 512
.   : milestone, 490,
iast_FULL (651.775 µs) : 630, 673
.   : milestone, 652,
iast_GLOBAL (518.998 µs) : 497, 541
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (497.157 µs) : 476, 519
.   : milestone, 497,
iast_INACTIVE (448.871 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (481.988 µs) : 461, 503
.   : milestone, 482,
tracing (447.368 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (376.113 µs) : 356, 396
.   : milestone, 376,
iast (490.776 µs) : 469, 513
.   : milestone, 491,
iast_FULL (655.543 µs) : 634, 677
.   : milestone, 656,
iast_GLOBAL (522.81 µs) : 501, 545
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (490.717 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (456.982 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (474.992 µs) : 454, 496
.   : milestone, 475,
tracing (449.844 µs) : 429, 471
.   : milestone, 450,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.335 µs [354.16 µs, 394.511 µs] -
iast 490.355 µs [468.935 µs, 511.775 µs] 116.019 µs (31.0%)
iast_FULL 651.775 µs [630.348 µs, 673.202 µs] 277.439 µs (74.1%)
iast_GLOBAL 518.998 µs [496.852 µs, 541.144 µs] 144.663 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 497.157 µs [475.775 µs, 518.539 µs] 122.822 µs (32.8%)
iast_INACTIVE 448.871 µs [428.009 µs, 469.733 µs] 74.535 µs (19.9%)
iast_TELEMETRY_OFF 481.988 µs [460.589 µs, 503.387 µs] 107.653 µs (28.8%)
tracing 447.368 µs [426.462 µs, 468.275 µs] 73.033 µs (19.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.113 µs [356.499 µs, 395.728 µs] -
iast 490.776 µs [468.985 µs, 512.566 µs] 114.662 µs (30.5%)
iast_FULL 655.543 µs [633.885 µs, 677.2 µs] 279.429 µs (74.3%)
iast_GLOBAL 522.81 µs [500.663 µs, 544.956 µs] 146.696 µs (39.0%)
iast_HARDCODED_SECRET_DISABLED 490.717 µs [469.452 µs, 511.983 µs] 114.604 µs (30.5%)
iast_INACTIVE 456.982 µs [435.993 µs, 477.971 µs] 80.869 µs (21.5%)
iast_TELEMETRY_OFF 474.992 µs [453.892 µs, 496.091 µs] 98.878 µs (26.3%)
tracing 449.844 µs [428.523 µs, 471.165 µs] 73.731 µs (19.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-platform-gc
git_commit_date 1734602177 1734632610
git_commit_sha 90899e0 6f3c3ba
release_version 1.45.0-SNAPSHOT~90899e0ddd 1.45.0-SNAPSHOT~6f3c3ba83a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1734634674 1734634674
ci_job_id 746153078 746153078
ci_pipeline_id 51597027 51597027
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
Loading
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~6f3c3ba83a, baseline=1.45.0-SNAPSHOT~90899e0ddd
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.932 s) : 14932000, 14932000
.   : milestone, 14932000,
appsec (15.211 s) : 15211000, 15211000
.   : milestone, 15211000,
iast (18.995 s) : 18995000, 18995000
.   : milestone, 18995000,
iast_GLOBAL (18.023 s) : 18023000, 18023000
.   : milestone, 18023000,
profiling (15.11 s) : 15110000, 15110000
.   : milestone, 15110000,
tracing (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
section candidate
no_agent (14.844 s) : 14844000, 14844000
.   : milestone, 14844000,
appsec (15.303 s) : 15303000, 15303000
.   : milestone, 15303000,
iast (18.826 s) : 18826000, 18826000
.   : milestone, 18826000,
iast_GLOBAL (17.841 s) : 17841000, 17841000
.   : milestone, 17841000,
profiling (14.827 s) : 14827000, 14827000
.   : milestone, 14827000,
tracing (14.937 s) : 14937000, 14937000
.   : milestone, 14937000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.932 s [14.932 s, 14.932 s] -
appsec 15.211 s [15.211 s, 15.211 s] 279.0 ms (1.9%)
iast 18.995 s [18.995 s, 18.995 s] 4.063 s (27.2%)
iast_GLOBAL 18.023 s [18.023 s, 18.023 s] 3.091 s (20.7%)
profiling 15.11 s [15.11 s, 15.11 s] 178.0 ms (1.2%)
tracing 14.969 s [14.969 s, 14.969 s] 37.0 ms (0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.844 s [14.844 s, 14.844 s] -
appsec 15.303 s [15.303 s, 15.303 s] 459.0 ms (3.1%)
iast 18.826 s [18.826 s, 18.826 s] 3.982 s (26.8%)
iast_GLOBAL 17.841 s [17.841 s, 17.841 s] 2.997 s (20.2%)
profiling 14.827 s [14.827 s, 14.827 s] -17.0 ms (-0.1%)
tracing 14.937 s [14.937 s, 14.937 s] 93.0 ms (0.6%)
Execution time for tomcat
Loading
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~6f3c3ba83a, baseline=1.45.0-SNAPSHOT~90899e0ddd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.362 ms) : 2321, 2404
.   : milestone, 2362,
iast (2.099 ms) : 2046, 2152
.   : milestone, 2099,
iast_GLOBAL (2.142 ms) : 2089, 2195
.   : milestone, 2142,
profiling (1.99 ms) : 1947, 2034
.   : milestone, 1990,
tracing (1.943 ms) : 1903, 1983
.   : milestone, 1943,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.353 ms) : 2311, 2394
.   : milestone, 2353,
iast (2.098 ms) : 2045, 2151
.   : milestone, 2098,
iast_GLOBAL (2.15 ms) : 2096, 2203
.   : milestone, 2150,
profiling (1.958 ms) : 1916, 2000
.   : milestone, 1958,
tracing (1.951 ms) : 1910, 1992
.   : milestone, 1951,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.362 ms [2.321 ms, 2.404 ms] 888.675 µs (60.3%)
iast 2.099 ms [2.046 ms, 2.152 ms] 625.667 µs (42.5%)
iast_GLOBAL 2.142 ms [2.089 ms, 2.195 ms] 668.313 µs (45.3%)
profiling 1.99 ms [1.947 ms, 2.034 ms] 516.356 µs (35.0%)
tracing 1.943 ms [1.903 ms, 1.983 ms] 469.44 µs (31.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.353 ms [2.311 ms, 2.394 ms] 881.709 µs (59.9%)
iast 2.098 ms [2.045 ms, 2.151 ms] 626.766 µs (42.6%)
iast_GLOBAL 2.15 ms [2.096 ms, 2.203 ms] 678.892 µs (46.2%)
profiling 1.958 ms [1.916 ms, 2.0 ms] 486.806 µs (33.1%)
tracing 1.951 ms [1.91 ms, 1.992 ms] 480.525 µs (32.7%)

Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!

@mcculls mcculls merged commit 88c493c into master Dec 19, 2024
148 checks passed
@mcculls mcculls deleted the mcculls/remove-platform-gc branch December 19, 2024 19:26
@github-actions github-actions bot added this to the 1.45.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants