Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure native image build setting for JDK-22 based GraalVM #8092

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

MattAlp
Copy link
Contributor

@MattAlp MattAlp commented Dec 13, 2024

What Does This Do

A follow up to #8065 in order to use the tracer and profiler inside of JDK-22-based Graal native images. This adds more classes to the build time initialization list & explicitly requires components that we didn't require before (i.e. enum members, subclasses).

Motivation

The profiling team would like to start focusing on JDK-22-and-up-based Graal native images. While testing against various system / smoke tests, these configuration changes came up.

Additional Notes

We may not want to initialize all of these at build time, feedback welcome.
I've verified that this doesn't introduce regressions for JDK-21-based Graal against our system-tests repo: the spring-boot-3-native build succeeds & tests pass / JFR data is present. Normally, system-tests uses the releases of our tracer so reproducing this will require adding some code to the target Dockerfiles to replace the tracer jar with a local build of this branch.

Contributor Checklist

Jira ticket: [PROF-11012]

@MattAlp MattAlp added type: enhancement comp: core Tracer core comp: tooling Build & Tooling comp: native-image GraalVM native-image labels Dec 13, 2024
@MattAlp MattAlp requested a review from a team as a code owner December 13, 2024 20:04
@MattAlp MattAlp requested a review from mcculls December 13, 2024 20:04
@MattAlp
Copy link
Contributor Author

MattAlp commented Dec 13, 2024

It could be worth discussing how we're going to ensure that changes to dd-trace-java keep Graal NI builds from breaking / requiring extra config. This split of testing between system-tests and here isn't ideal. At the same time, the compilation times would slow down tests (local & CI) considerably.

@pr-commenter
Copy link

pr-commenter bot commented Dec 13, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mattalp/port-tracer-to-jdk-22-NI
git_commit_date 1734102010 1734119182
git_commit_sha bdc9eae 61cd91e
release_version 1.45.0-SNAPSHOT~bdc9eae8ff 1.45.0-SNAPSHOT~61cd91e1d1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734122035 1734122035
ci_job_id 739101308 739101308
ci_pipeline_id 51120577 51120577
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~61cd91e1d1, baseline=1.45.0-SNAPSHOT~bdc9eae8ff

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.102 s) : 0, 1102430
Total [baseline] (8.655 s) : 0, 8655383
Agent [candidate] (1.091 s) : 0, 1091258
Total [candidate] (8.656 s) : 0, 8656182
section iast
Agent [baseline] (1.225 s) : 0, 1224717
Total [baseline] (9.231 s) : 0, 9231059
Agent [candidate] (1.231 s) : 0, 1230679
Total [candidate] (9.261 s) : 0, 9260521
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.221 s) : 0, 1221151
Total [baseline] (9.191 s) : 0, 9191484
Agent [candidate] (1.224 s) : 0, 1223557
Total [candidate] (9.163 s) : 0, 9162842
section iast_TELEMETRY_OFF
Agent [baseline] (1.218 s) : 0, 1217763
Total [baseline] (9.188 s) : 0, 9188456
Agent [candidate] (1.216 s) : 0, 1216075
Total [candidate] (9.222 s) : 0, 9221976
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.102 s -
Agent iast 1.225 s 122.286 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.221 s 118.721 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.218 s 115.333 ms (10.5%)
Total tracing 8.655 s -
Total iast 9.231 s 575.676 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.191 s 536.102 ms (6.2%)
Total iast_TELEMETRY_OFF 9.188 s 533.073 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.231 s 139.421 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.224 s 132.299 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.216 s 124.817 ms (11.4%)
Total tracing 8.656 s -
Total iast 9.261 s 604.339 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.163 s 506.66 ms (5.9%)
Total iast_TELEMETRY_OFF 9.222 s 565.794 ms (6.5%)
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~61cd91e1d1, baseline=1.45.0-SNAPSHOT~bdc9eae8ff

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (701.933 ms) : 0, 701933
BytebuddyAgent [candidate] (695.168 ms) : 0, 695168
GlobalTracer [baseline] (319.613 ms) : 0, 319613
GlobalTracer [candidate] (317.608 ms) : 0, 317608
AppSec [baseline] (54.932 ms) : 0, 54932
AppSec [candidate] (54.808 ms) : 0, 54808
Remote Config [baseline] (672.594 µs) : 0, 673
Remote Config [candidate] (675.298 µs) : 0, 675
Telemetry [baseline] (11.352 ms) : 0, 11352
Telemetry [candidate] (9.203 ms) : 0, 9203
section iast
BytebuddyAgent [baseline] (817.18 ms) : 0, 817180
BytebuddyAgent [candidate] (820.208 ms) : 0, 820208
GlobalTracer [baseline] (307.056 ms) : 0, 307056
GlobalTracer [candidate] (308.809 ms) : 0, 308809
AppSec [baseline] (57.599 ms) : 0, 57599
AppSec [candidate] (58.124 ms) : 0, 58124
IAST [baseline] (20.978 ms) : 0, 20978
IAST [candidate] (21.466 ms) : 0, 21466
Remote Config [baseline] (620.156 µs) : 0, 620
Remote Config [candidate] (632.322 µs) : 0, 632
Telemetry [baseline] (7.447 ms) : 0, 7447
Telemetry [candidate] (7.554 ms) : 0, 7554
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (813.229 ms) : 0, 813229
BytebuddyAgent [candidate] (815.153 ms) : 0, 815153
GlobalTracer [baseline] (306.473 ms) : 0, 306473
GlobalTracer [candidate] (307.05 ms) : 0, 307050
AppSec [baseline] (57.373 ms) : 0, 57373
AppSec [candidate] (58.094 ms) : 0, 58094
IAST [baseline] (22.194 ms) : 0, 22194
IAST [candidate] (21.291 ms) : 0, 21291
Remote Config [baseline] (613.766 µs) : 0, 614
Remote Config [candidate] (626.286 µs) : 0, 626
Telemetry [baseline] (7.502 ms) : 0, 7502
Telemetry [candidate] (7.511 ms) : 0, 7511
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (810.923 ms) : 0, 810923
BytebuddyAgent [candidate] (810.577 ms) : 0, 810577
GlobalTracer [baseline] (306.447 ms) : 0, 306447
GlobalTracer [candidate] (305.849 ms) : 0, 305849
AppSec [baseline] (57.69 ms) : 0, 57690
AppSec [candidate] (57.557 ms) : 0, 57557
IAST [baseline] (20.877 ms) : 0, 20877
IAST [candidate] (20.344 ms) : 0, 20344
Remote Config [baseline] (637.893 µs) : 0, 638
Remote Config [candidate] (628.679 µs) : 0, 629
Telemetry [baseline] (7.449 ms) : 0, 7449
Telemetry [candidate] (7.304 ms) : 0, 7304
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~61cd91e1d1, baseline=1.45.0-SNAPSHOT~bdc9eae8ff

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089786
Total [baseline] (10.499 s) : 0, 10498839
Agent [candidate] (1.095 s) : 0, 1095049
Total [candidate] (10.431 s) : 0, 10431090
section appsec
Agent [baseline] (1.232 s) : 0, 1232011
Total [baseline] (10.74 s) : 0, 10739747
Agent [candidate] (1.229 s) : 0, 1228636
Total [candidate] (10.796 s) : 0, 10795581
section iast
Agent [baseline] (1.226 s) : 0, 1225504
Total [baseline] (11.066 s) : 0, 11065989
Agent [candidate] (1.221 s) : 0, 1220768
Total [candidate] (10.98 s) : 0, 10980199
section profiling
Agent [baseline] (1.333 s) : 0, 1333247
Total [baseline] (10.816 s) : 0, 10815852
Agent [candidate] (1.317 s) : 0, 1316748
Total [candidate] (10.925 s) : 0, 10925486
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent appsec 1.232 s 142.225 ms (13.1%)
Agent iast 1.226 s 135.718 ms (12.5%)
Agent profiling 1.333 s 243.461 ms (22.3%)
Total tracing 10.499 s -
Total appsec 10.74 s 240.908 ms (2.3%)
Total iast 11.066 s 567.15 ms (5.4%)
Total profiling 10.816 s 317.014 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.095 s -
Agent appsec 1.229 s 133.588 ms (12.2%)
Agent iast 1.221 s 125.719 ms (11.5%)
Agent profiling 1.317 s 221.699 ms (20.2%)
Total tracing 10.431 s -
Total appsec 10.796 s 364.49 ms (3.5%)
Total iast 10.98 s 549.109 ms (5.3%)
Total profiling 10.925 s 494.396 ms (4.7%)
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~61cd91e1d1, baseline=1.45.0-SNAPSHOT~bdc9eae8ff

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.605 ms) : 0, 694605
BytebuddyAgent [candidate] (698.898 ms) : 0, 698898
GlobalTracer [baseline] (316.971 ms) : 0, 316971
GlobalTracer [candidate] (316.916 ms) : 0, 316916
AppSec [baseline] (54.609 ms) : 0, 54609
AppSec [candidate] (54.696 ms) : 0, 54696
Remote Config [baseline] (672.238 µs) : 0, 672
Remote Config [candidate] (687.833 µs) : 0, 688
Telemetry [baseline] (9.193 ms) : 0, 9193
Telemetry [candidate] (10.052 ms) : 0, 10052
section appsec
BytebuddyAgent [baseline] (717.15 ms) : 0, 717150
BytebuddyAgent [candidate] (713.059 ms) : 0, 713059
GlobalTracer [baseline] (315.619 ms) : 0, 315619
GlobalTracer [candidate] (315.834 ms) : 0, 315834
AppSec [baseline] (166.904 ms) : 0, 166904
AppSec [candidate] (167.915 ms) : 0, 167915
IAST [baseline] (19.997 ms) : 0, 19997
IAST [candidate] (19.135 ms) : 0, 19135
Remote Config [baseline] (652.745 µs) : 0, 653
Remote Config [candidate] (647.513 µs) : 0, 648
Telemetry [baseline] (7.859 ms) : 0, 7859
Telemetry [candidate] (7.878 ms) : 0, 7878
section iast
BytebuddyAgent [baseline] (817.399 ms) : 0, 817399
BytebuddyAgent [candidate] (813.102 ms) : 0, 813102
GlobalTracer [baseline] (307.256 ms) : 0, 307256
GlobalTracer [candidate] (306.582 ms) : 0, 306582
AppSec [baseline] (57.102 ms) : 0, 57102
AppSec [candidate] (57.314 ms) : 0, 57314
IAST [baseline] (21.891 ms) : 0, 21891
IAST [candidate] (21.954 ms) : 0, 21954
Remote Config [baseline] (616.51 µs) : 0, 617
Remote Config [candidate] (618.284 µs) : 0, 618
Telemetry [baseline] (7.437 ms) : 0, 7437
Telemetry [candidate] (7.478 ms) : 0, 7478
section profiling
BytebuddyAgent [baseline] (698.902 ms) : 0, 698902
BytebuddyAgent [candidate] (687.719 ms) : 0, 687719
GlobalTracer [baseline] (437.705 ms) : 0, 437705
GlobalTracer [candidate] (434.14 ms) : 0, 434140
AppSec [baseline] (53.95 ms) : 0, 53950
AppSec [candidate] (53.873 ms) : 0, 53873
Remote Config [baseline] (676.375 µs) : 0, 676
Remote Config [candidate] (664.683 µs) : 0, 665
Telemetry [baseline] (7.854 ms) : 0, 7854
Telemetry [candidate] (7.737 ms) : 0, 7737
ProfilingAgent [baseline] (94.629 ms) : 0, 94629
ProfilingAgent [candidate] (93.486 ms) : 0, 93486
Profiling [baseline] (94.654 ms) : 0, 94654
Profiling [candidate] (93.51 ms) : 0, 93510
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-13T20:04:03 2024-12-13T20:11:04
git_branch master mattalp/port-tracer-to-jdk-22-NI
git_commit_date 1734102010 1734119182
git_commit_sha bdc9eae 61cd91e
release_version 1.45.0-SNAPSHOT~bdc9eae8ff 1.45.0-SNAPSHOT~61cd91e1d1
start_time 2024-12-13T20:03:50 2024-12-13T20:10:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734121018 1734121018
ci_job_id 739101309 739101309
ci_pipeline_id 51120577 51120577
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~61cd91e1d1, baseline=1.45.0-SNAPSHOT~bdc9eae8ff
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.579 µs) : 363, 403
.   : milestone, 383,
iast (496.486 µs) : 475, 518
.   : milestone, 496,
iast_FULL (655.682 µs) : 634, 677
.   : milestone, 656,
iast_GLOBAL (531.949 µs) : 510, 554
.   : milestone, 532,
iast_HARDCODED_SECRET_DISABLED (501.511 µs) : 480, 523
.   : milestone, 502,
iast_INACTIVE (456.94 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (482.971 µs) : 461, 505
.   : milestone, 483,
tracing (456.714 µs) : 435, 478
.   : milestone, 457,
section candidate
no_agent (388.242 µs) : 368, 408
.   : milestone, 388,
iast (490.933 µs) : 469, 512
.   : milestone, 491,
iast_FULL (658.135 µs) : 636, 680
.   : milestone, 658,
iast_GLOBAL (522.268 µs) : 501, 543
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (502.22 µs) : 481, 524
.   : milestone, 502,
iast_INACTIVE (455.118 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (486.805 µs) : 465, 508
.   : milestone, 487,
tracing (458.867 µs) : 437, 481
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.579 µs [362.556 µs, 402.602 µs] -
iast 496.486 µs [474.731 µs, 518.241 µs] 113.907 µs (29.8%)
iast_FULL 655.682 µs [633.999 µs, 677.365 µs] 273.103 µs (71.4%)
iast_GLOBAL 531.949 µs [509.567 µs, 554.33 µs] 149.369 µs (39.0%)
iast_HARDCODED_SECRET_DISABLED 501.511 µs [479.917 µs, 523.105 µs] 118.932 µs (31.1%)
iast_INACTIVE 456.94 µs [435.97 µs, 477.911 µs] 74.361 µs (19.4%)
iast_TELEMETRY_OFF 482.971 µs [461.371 µs, 504.571 µs] 100.392 µs (26.2%)
tracing 456.714 µs [434.95 µs, 478.478 µs] 74.135 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 388.242 µs [368.332 µs, 408.152 µs] -
iast 490.933 µs [469.401 µs, 512.464 µs] 102.69 µs (26.5%)
iast_FULL 658.135 µs [636.493 µs, 679.777 µs] 269.893 µs (69.5%)
iast_GLOBAL 522.268 µs [501.07 µs, 543.466 µs] 134.026 µs (34.5%)
iast_HARDCODED_SECRET_DISABLED 502.22 µs [480.573 µs, 523.866 µs] 113.977 µs (29.4%)
iast_INACTIVE 455.118 µs [433.85 µs, 476.386 µs] 66.876 µs (17.2%)
iast_TELEMETRY_OFF 486.805 µs [465.429 µs, 508.182 µs] 98.563 µs (25.4%)
tracing 458.867 µs [436.74 µs, 480.994 µs] 70.625 µs (18.2%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~61cd91e1d1, baseline=1.45.0-SNAPSHOT~bdc9eae8ff
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.363 ms) : 1343, 1382
.   : milestone, 1363,
appsec (1.737 ms) : 1713, 1760
.   : milestone, 1737,
appsec_no_iast (1.768 ms) : 1743, 1792
.   : milestone, 1768,
iast (1.508 ms) : 1485, 1531
.   : milestone, 1508,
profiling (1.53 ms) : 1507, 1553
.   : milestone, 1530,
tracing (1.512 ms) : 1486, 1537
.   : milestone, 1512,
section candidate
no_agent (1.355 ms) : 1336, 1375
.   : milestone, 1355,
appsec (1.759 ms) : 1735, 1783
.   : milestone, 1759,
appsec_no_iast (1.752 ms) : 1727, 1778
.   : milestone, 1752,
iast (1.508 ms) : 1485, 1530
.   : milestone, 1508,
profiling (1.518 ms) : 1494, 1542
.   : milestone, 1518,
tracing (1.477 ms) : 1453, 1502
.   : milestone, 1477,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.343 ms, 1.382 ms] -
appsec 1.737 ms [1.713 ms, 1.76 ms] 374.082 µs (27.5%)
appsec_no_iast 1.768 ms [1.743 ms, 1.792 ms] 404.996 µs (29.7%)
iast 1.508 ms [1.485 ms, 1.531 ms] 145.707 µs (10.7%)
profiling 1.53 ms [1.507 ms, 1.553 ms] 167.539 µs (12.3%)
tracing 1.512 ms [1.486 ms, 1.537 ms] 149.286 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.375 ms] -
appsec 1.759 ms [1.735 ms, 1.783 ms] 403.489 µs (29.8%)
appsec_no_iast 1.752 ms [1.727 ms, 1.778 ms] 396.627 µs (29.3%)
iast 1.508 ms [1.485 ms, 1.53 ms] 152.106 µs (11.2%)
profiling 1.518 ms [1.494 ms, 1.542 ms] 162.566 µs (12.0%)
tracing 1.477 ms [1.453 ms, 1.502 ms] 121.909 µs (9.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mattalp/port-tracer-to-jdk-22-NI
git_commit_date 1734102010 1734119182
git_commit_sha bdc9eae 61cd91e
release_version 1.45.0-SNAPSHOT~bdc9eae8ff 1.45.0-SNAPSHOT~61cd91e1d1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1734121577 1734121577
ci_job_id 739101310 739101310
ci_pipeline_id 51120577 51120577
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~61cd91e1d1, baseline=1.45.0-SNAPSHOT~bdc9eae8ff
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.973 s) : 14973000, 14973000
.   : milestone, 14973000,
appsec (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
iast (18.686 s) : 18686000, 18686000
.   : milestone, 18686000,
iast_GLOBAL (17.854 s) : 17854000, 17854000
.   : milestone, 17854000,
profiling (14.919 s) : 14919000, 14919000
.   : milestone, 14919000,
tracing (15.148 s) : 15148000, 15148000
.   : milestone, 15148000,
section candidate
no_agent (14.896 s) : 14896000, 14896000
.   : milestone, 14896000,
appsec (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
iast (18.946 s) : 18946000, 18946000
.   : milestone, 18946000,
iast_GLOBAL (17.767 s) : 17767000, 17767000
.   : milestone, 17767000,
profiling (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
tracing (15.1 s) : 15100000, 15100000
.   : milestone, 15100000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.973 s [14.973 s, 14.973 s] -
appsec 15.031 s [15.031 s, 15.031 s] 58.0 ms (0.4%)
iast 18.686 s [18.686 s, 18.686 s] 3.713 s (24.8%)
iast_GLOBAL 17.854 s [17.854 s, 17.854 s] 2.881 s (19.2%)
profiling 14.919 s [14.919 s, 14.919 s] -54.0 ms (-0.4%)
tracing 15.148 s [15.148 s, 15.148 s] 175.0 ms (1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.896 s [14.896 s, 14.896 s] -
appsec 15.016 s [15.016 s, 15.016 s] 120.0 ms (0.8%)
iast 18.946 s [18.946 s, 18.946 s] 4.05 s (27.2%)
iast_GLOBAL 17.767 s [17.767 s, 17.767 s] 2.871 s (19.3%)
profiling 14.947 s [14.947 s, 14.947 s] 51.0 ms (0.3%)
tracing 15.1 s [15.1 s, 15.1 s] 204.0 ms (1.4%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~61cd91e1d1, baseline=1.45.0-SNAPSHOT~bdc9eae8ff
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.35 ms) : 2308, 2392
.   : milestone, 2350,
iast (2.09 ms) : 2037, 2144
.   : milestone, 2090,
iast_GLOBAL (2.132 ms) : 2079, 2185
.   : milestone, 2132,
profiling (2.419 ms) : 2245, 2592
.   : milestone, 2419,
tracing (1.931 ms) : 1891, 1972
.   : milestone, 1931,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.353 ms) : 2311, 2395
.   : milestone, 2353,
iast (2.08 ms) : 2028, 2133
.   : milestone, 2080,
iast_GLOBAL (2.14 ms) : 2086, 2193
.   : milestone, 2140,
profiling (1.959 ms) : 1917, 2001
.   : milestone, 1959,
tracing (1.928 ms) : 1887, 1968
.   : milestone, 1928,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.35 ms [2.308 ms, 2.392 ms] 881.654 µs (60.1%)
iast 2.09 ms [2.037 ms, 2.144 ms] 622.589 µs (42.4%)
iast_GLOBAL 2.132 ms [2.079 ms, 2.185 ms] 664.313 µs (45.3%)
profiling 2.419 ms [2.245 ms, 2.592 ms] 950.778 µs (64.8%)
tracing 1.931 ms [1.891 ms, 1.972 ms] 463.378 µs (31.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.353 ms [2.311 ms, 2.395 ms] 884.355 µs (60.2%)
iast 2.08 ms [2.028 ms, 2.133 ms] 611.479 µs (41.6%)
iast_GLOBAL 2.14 ms [2.086 ms, 2.193 ms] 670.695 µs (45.7%)
profiling 1.959 ms [1.917 ms, 2.001 ms] 490.087 µs (33.4%)
tracing 1.928 ms [1.887 ms, 1.968 ms] 458.69 µs (31.2%)

Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattAlp MattAlp merged commit efe39cc into master Dec 13, 2024
159 checks passed
@MattAlp MattAlp deleted the mattalp/port-tracer-to-jdk-22-NI branch December 13, 2024 20:49
@github-actions github-actions bot added this to the 1.45.0 milestone Dec 13, 2024
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jan 9, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.50.0` -> `2.50.1` |
|
[com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.49.0` -> `2.49.1` |
|
[com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.49.0` -> `2.49.1` |
| [com.google.api:gax](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.59.0` -> `2.59.1` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.44.1` -> `1.45.0` |
| [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.44.1` -> `1.45.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.47` -> `2.29.48` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.47` -> `2.29.48` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.47` -> `2.29.48` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.47` -> `2.29.48` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.47` -> `2.29.48` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.47` -> `2.29.48` |

---

### Release Notes

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.45.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.0):
1.45.0

##### Breaking changes

> \[!WARNING]\
> Support for custom scope manager using OpenTelemetry tracer artifact
(`dd-trace-ot`) is dropped.
> Tracing with OpenTracing API and custom scope manager will continue to
work on 1.44.x releases.

##### Components

##### Application Security Management (IAST)

- ✨ Add propagation to URI#toURL method
([#&#8203;8146](DataDog/dd-trace-java#8146) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ Increase IAST propagation to StringBuilder setLength
([#&#8203;8119](DataDog/dd-trace-java#8119) -
[@&#8203;Mariovido](https://github.com/Mariovido))
- ✨ Increase IAST propagation to StringBuffer append
([#&#8203;8082](DataDog/dd-trace-java#8082) -
[@&#8203;Mariovido](https://github.com/Mariovido))
- ✨ Handle IAST security controls custom validation and
sanitization methods
([#&#8203;7997](DataDog/dd-trace-java#7997) -
[@&#8203;jandro996](https://github.com/jandro996))

##### Application Security Management (WAF)

- ✨ Update user lifecycle tracking to V3
([#&#8203;8108](DataDog/dd-trace-java#8108) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ Exploit prevention for Shell Injection / Command Injection
([#&#8203;7615](DataDog/dd-trace-java#7615) -
[@&#8203;jandro996](https://github.com/jandro996))

##### Build & Tooling

- 💡 Support instrumentation of repackaged libraries
([#&#8203;8153](DataDog/dd-trace-java#8153) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨ Configure native image build setting for JDK-22 based
GraalVM
([#&#8203;8092](DataDog/dd-trace-java#8092) -
[@&#8203;MattAlp](https://github.com/MattAlp))

##### Database Monitoring

- ✨ Add full APM/DBM mode for Oracle
([#&#8203;8090](DataDog/dd-trace-java#8090) -
[@&#8203;nenadnoveljic](https://github.com/nenadnoveljic))

##### Dynamic Instrumentation

- 🐛 make local var hoisting disabled by default
([#&#8203;8158](DataDog/dd-trace-java#8158) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Fix var hoisting issue when no previous store
([#&#8203;8122](DataDog/dd-trace-java#8122) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Only decorate spans without code origin information
([#&#8203;8105](DataDog/dd-trace-java#8105) -
[@&#8203;evanchooly](https://github.com/evanchooly))
- 🐛 Fix suspend Kotlin methods instrumentation
([#&#8203;8080](DataDog/dd-trace-java#8080) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Fix class file version detection
([#&#8203;8057](DataDog/dd-trace-java#8057) -
[@&#8203;jpbempel](https://github.com/jpbempel))

##### GraalVM native-image

- ✨ Configure native image build setting for JDK-22 based
GraalVM
([#&#8203;8092](DataDog/dd-trace-java#8092) -
[@&#8203;MattAlp](https://github.com/MattAlp))

##### ML Observability (LLMObs)

- ✨🧪 Add LLMObs configuration
([#&#8203;8076](DataDog/dd-trace-java#8076) -
[@&#8203;gary-huang](https://github.com/gary-huang))

##### Metrics

- Bump integrations-core submodule to 7.60.0
([#&#8203;8098](DataDog/dd-trace-java#8098) -
[@&#8203;mcculls](https://github.com/mcculls))
- Upgrade to java-dogstatsd-client v4.4.3
([#&#8203;8096](DataDog/dd-trace-java#8096) -
[@&#8203;mcculls](https://github.com/mcculls))

##### OpenTracing

- ⚠️🧹 Remove custom scope manager support
([#&#8203;8164](DataDog/dd-trace-java#8164) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

##### Telemetry

- ✨ Retry telemetry requests if CI Visibility is enabled
([#&#8203;8147](DataDog/dd-trace-java#8147) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Add configurable Dependency service resolution period
([#&#8203;8079](DataDog/dd-trace-java#8079) -
[@&#8203;jandro996](https://github.com/jandro996))

##### Testing

- 🐛 Remove restriction to not run vertx4 latest tests on java 17
([#&#8203;8133](DataDog/dd-trace-java#8133) -
[@&#8203;vandonr](https://github.com/vandonr))

##### Tracer core

- ✨ Defer remote components to avoid OkHttp class-loading
side-effects
([#&#8203;8131](DataDog/dd-trace-java#8131) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨ Improve Context API null handling and Javadoc
([#&#8203;8129](DataDog/dd-trace-java#8129) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- 🐛⚡ Avoid performing blocking I/O operation on application
thread
([#&#8203;8120](DataDog/dd-trace-java#8120) -
[@&#8203;mcculls](https://github.com/mcculls))
- 💡 Introduce a shared context component, independent of tracing
([#&#8203;8117](DataDog/dd-trace-java#8117) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨ Improves ServiceNameCollector
([#&#8203;8109](DataDog/dd-trace-java#8109) -
[@&#8203;amarziali](https://github.com/amarziali))
- Upgrade to ASM 9.7.1 (adds new constant for Java 24)
([#&#8203;8097](DataDog/dd-trace-java#8097) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Dynamically evaluate service name for message consumers
([#&#8203;8088](DataDog/dd-trace-java#8088) -
[@&#8203;amarziali](https://github.com/amarziali))

##### Serverless

- 🐛 Add avoid double instrumenting lambda non-streaming handlers.
([#&#8203;8073](DataDog/dd-trace-java#8073) -
[@&#8203;purple4reina](https://github.com/purple4reina))

##### Instrumentations

##### AWS SDK instrumentation

- 💡 Instrument EMR's relocated AWS SDK
([#&#8203;8157](DataDog/dd-trace-java#8157) -
[@&#8203;mcculls](https://github.com/mcculls))

##### Eclipse Vert.x instrumentation

- 🐛 Remove restriction to not run vertx4 latest tests on java 17
([#&#8203;8133](DataDog/dd-trace-java#8133) -
[@&#8203;vandonr](https://github.com/vandonr))

##### JDBC instrumentation

- ✨ Add full APM/DBM mode for Oracle
([#&#8203;8090](DataDog/dd-trace-java#8090) -
[@&#8203;nenadnoveljic](https://github.com/nenadnoveljic))

##### Jetty instrumentation

- 🐛 Ensure jetty 12 has servlet.path starting with /
([#&#8203;8093](DataDog/dd-trace-java#8093) -
[@&#8203;github-actions](https://github.com/github-actions)\[bot])

##### JMS instrumentation

- 🧹 Re-use `javax` JMS module for `jakarta` namespace
([#&#8203;8155](DataDog/dd-trace-java#8155) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🧹 Group `javax.jms` instrumentations under a single module
([#&#8203;8154](DataDog/dd-trace-java#8154) -
[@&#8203;mcculls](https://github.com/mcculls))

##### Reactor instrumentation

- 🐛 Reactor: early propagate span in context when subscribing
([#&#8203;8166](DataDog/dd-trace-java#8166) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: ba2355aa4e2e39ab1fee27319cc4176238efd90b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: core Tracer core comp: native-image GraalVM native-image comp: tooling Build & Tooling type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants