Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert back to putting the whole span for now #8074

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

evanchooly
Copy link
Contributor

What Does This Do

Temporary fix for a temporary fix until we get the actual fix.

@evanchooly evanchooly requested a review from jpbempel December 10, 2024 19:31
@evanchooly evanchooly requested a review from a team as a code owner December 10, 2024 19:31
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@evanchooly evanchooly enabled auto-merge (squash) December 10, 2024 19:31
@evanchooly evanchooly added comp: debugger Dynamic Instrumentation type: bug labels Dec 10, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1733859602 1733859979
end_time 2024-12-10T19:41:19 2024-12-10T19:47:37
git_branch master evanchooly/exitspans
git_commit_sha 063dd0b 71e1e8e
start_time 2024-12-10T19:40:03 2024-12-10T19:46:20
See matching parameters
Baseline Candidate
ci_job_id 733650721 733650721
ci_pipeline_id 50755177 50755177
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1733858944 1733858944

Summary

Found 0 performance improvements and 8 performance regressions! Performance is the same for 2 metrics, 5 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic worse
[+9.364µs; +20.090µs] or [+3.383%; +7.259%]
worse
[+5.927µs; +24.482µs] or [+1.930%; +7.971%]
worse
[+5.467µs; +26.084µs] or [+1.727%; +8.240%]
unstable
[-37.039µs; +42.517µs] or [-6.697%; +7.688%]
unsure
[-238.578op/s; -11.578op/s] or [-9.305%; -0.452%]
scenario:loop worse
[+652.758µs; +710.111µs] or [+6.386%; +6.947%]
worse
[+654.175µs; +740.347µs] or [+6.297%; +7.127%]
worse
[+612.757µs; +737.010µs] or [+5.847%; +7.032%]
worse
[+412.312µs; +912.859µs] or [+3.787%; +8.385%]
worse
[-6.763op/s; -5.142op/s] or [-7.101%; -5.399%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-18.322µs; +22.132µs] or [-6.781%; +8.191%]
unstable
[-28.425µs; +36.014µs] or [-9.183%; +11.635%]
unstable
[-37.381µs; +49.100µs] or [-11.571%; +15.199%]
unstable
[-121.659µs; +97.221µs] or [-19.569%; +15.638%]
same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (309.542 µs) : 281, 338
.   : milestone, 310,
basic (307.146 µs) : 298, 317
.   : milestone, 307,
loop (10.388 ms) : 10364, 10412
.   : milestone, 10388,
section candidate
noprobe (313.336 µs) : 281, 346
.   : milestone, 313,
basic (322.35 µs) : 314, 331
.   : milestone, 322,
loop (11.085 ms) : 11034, 11137
.   : milestone, 11085,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 309.542 µs [280.671 µs, 338.413 µs]
basic 307.146 µs [297.605 µs, 316.687 µs]
loop 10.388 ms [10.364 ms, 10.412 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 313.336 µs [280.9 µs, 345.773 µs]
basic 322.35 µs [313.787 µs, 330.913 µs]
loop 11.085 ms [11.034 ms, 11.137 ms]

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2024

Benchmarks

Startup

Load

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/exitspans
git_commit_date 1733850970 1733858944
git_commit_sha 063dd0b 71e1e8e
release_version 1.44.0-SNAPSHOT~063dd0b9a5 1.44.0-SNAPSHOT~71e1e8e940
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1733861019 1733861019
ci_job_id 733650706 733650706
ci_pipeline_id 50755177 50755177
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~71e1e8e940, baseline=1.44.0-SNAPSHOT~063dd0b9a5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.555 s) : 15555000, 15555000
.   : milestone, 15555000,
appsec (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
iast (18.791 s) : 18791000, 18791000
.   : milestone, 18791000,
iast_GLOBAL (17.788 s) : 17788000, 17788000
.   : milestone, 17788000,
profiling (15.706 s) : 15706000, 15706000
.   : milestone, 15706000,
tracing (14.896 s) : 14896000, 14896000
.   : milestone, 14896000,
section candidate
no_agent (14.945 s) : 14945000, 14945000
.   : milestone, 14945000,
appsec (14.789 s) : 14789000, 14789000
.   : milestone, 14789000,
iast (19.014 s) : 19014000, 19014000
.   : milestone, 19014000,
iast_GLOBAL (17.755 s) : 17755000, 17755000
.   : milestone, 17755000,
profiling (15.11 s) : 15110000, 15110000
.   : milestone, 15110000,
tracing (14.899 s) : 14899000, 14899000
.   : milestone, 14899000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.555 s [15.555 s, 15.555 s] -
appsec 15.002 s [15.002 s, 15.002 s] -553.0 ms (-3.6%)
iast 18.791 s [18.791 s, 18.791 s] 3.236 s (20.8%)
iast_GLOBAL 17.788 s [17.788 s, 17.788 s] 2.233 s (14.4%)
profiling 15.706 s [15.706 s, 15.706 s] 151.0 ms (1.0%)
tracing 14.896 s [14.896 s, 14.896 s] -659.0 ms (-4.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.945 s [14.945 s, 14.945 s] -
appsec 14.789 s [14.789 s, 14.789 s] -156.0 ms (-1.0%)
iast 19.014 s [19.014 s, 19.014 s] 4.069 s (27.2%)
iast_GLOBAL 17.755 s [17.755 s, 17.755 s] 2.81 s (18.8%)
profiling 15.11 s [15.11 s, 15.11 s] 165.0 ms (1.1%)
tracing 14.899 s [14.899 s, 14.899 s] -46.0 ms (-0.3%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~71e1e8e940, baseline=1.44.0-SNAPSHOT~063dd0b9a5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.339 ms) : 2297, 2381
.   : milestone, 2339,
iast (2.079 ms) : 2026, 2131
.   : milestone, 2079,
iast_GLOBAL (2.126 ms) : 2073, 2178
.   : milestone, 2126,
profiling (1.947 ms) : 1904, 1990
.   : milestone, 1947,
tracing (1.916 ms) : 1876, 1956
.   : milestone, 1916,
section candidate
no_agent (1.468 ms) : 1457, 1479
.   : milestone, 1468,
appsec (2.329 ms) : 2288, 2371
.   : milestone, 2329,
iast (2.074 ms) : 2022, 2127
.   : milestone, 2074,
iast_GLOBAL (2.121 ms) : 2069, 2174
.   : milestone, 2121,
profiling (2.45 ms) : 2260, 2641
.   : milestone, 2450,
tracing (1.918 ms) : 1878, 1959
.   : milestone, 1918,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.339 ms [2.297 ms, 2.381 ms] 872.498 µs (59.5%)
iast 2.079 ms [2.026 ms, 2.131 ms] 611.807 µs (41.7%)
iast_GLOBAL 2.126 ms [2.073 ms, 2.178 ms] 658.931 µs (44.9%)
profiling 1.947 ms [1.904 ms, 1.99 ms] 480.375 µs (32.8%)
tracing 1.916 ms [1.876 ms, 1.956 ms] 449.613 µs (30.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.479 ms] -
appsec 2.329 ms [2.288 ms, 2.371 ms] 861.471 µs (58.7%)
iast 2.074 ms [2.022 ms, 2.127 ms] 606.4 µs (41.3%)
iast_GLOBAL 2.121 ms [2.069 ms, 2.174 ms] 653.225 µs (44.5%)
profiling 2.45 ms [2.26 ms, 2.641 ms] 982.456 µs (66.9%)
tracing 1.918 ms [1.878 ms, 1.959 ms] 450.232 µs (30.7%)

@evanchooly evanchooly merged commit 7afe313 into master Dec 10, 2024
154 of 156 checks passed
@evanchooly evanchooly deleted the evanchooly/exitspans branch December 10, 2024 20:23
@jpbempel jpbempel added the tag: no release notes Changes to exclude from release notes label Dec 10, 2024
@github-actions github-actions bot added this to the 1.44.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants