Fix crash tracking setup in smoke test #8037

PerfectSlayer · 2024-11-29T13:51:23Z

What Does This Do

While crash tracking was enabled in #7855 invalid escaping was put in place, leading the install the crash tracking uploader script at a wrong location.

This PR removes the escaping which was not needed for the Java Process API nor OpenLiberty jvm.options file and make sure escaping is set up for environment variables like tomcat CATALINA_OPT and Netty / Wildfly JAVA_OPTS.

Motivation

Trying to escape the space lead to installing the crash tracking uploader script in <current_dir>/"/tmp/dd_crash_uploader.sh.

Additional Notes

This PR is a follow up of #7855

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-11-29T14:32:45Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/crashtracking
git_commit_date	1732876820	1732888175
git_commit_sha	`9f01834`	`376888a`
release_version	1.44.0-SNAPSHOT~9f01834ab7	1.44.0-SNAPSHOT~376888a9f7

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732890595	1732890595
ci_job_id	723558339	723558339
ci_pipeline_id	50146991	50146991
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~376888a9f7, baseline=1.44.0-SNAPSHOT~9f01834ab7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096417
Total [baseline] (10.465 s) : 0, 10465489
Agent [candidate] (1.088 s) : 0, 1088144
Total [candidate] (10.394 s) : 0, 10393668
section appsec
Agent [baseline] (1.225 s) : 0, 1225466
Total [baseline] (10.72 s) : 0, 10719715
Agent [candidate] (1.227 s) : 0, 1226848
Total [candidate] (10.706 s) : 0, 10706092
section iast
Agent [baseline] (1.22 s) : 0, 1220064
Total [baseline] (10.991 s) : 0, 10990854
Agent [candidate] (1.219 s) : 0, 1218505
Total [candidate] (10.948 s) : 0, 10947633
section profiling
Agent [baseline] (1.323 s) : 0, 1323301
Total [baseline] (10.856 s) : 0, 10855816
Agent [candidate] (1.333 s) : 0, 1333499
Total [candidate] (10.88 s) : 0, 10879538

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	appsec	1.225 s	129.049 ms (11.8%)
Agent	iast	1.22 s	123.647 ms (11.3%)
Agent	profiling	1.323 s	226.884 ms (20.7%)
Total	tracing	10.465 s	-
Total	appsec	10.72 s	254.226 ms (2.4%)
Total	iast	10.991 s	525.365 ms (5.0%)
Total	profiling	10.856 s	390.327 ms (3.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	appsec	1.227 s	138.704 ms (12.7%)
Agent	iast	1.219 s	130.361 ms (12.0%)
Agent	profiling	1.333 s	245.355 ms (22.5%)
Total	tracing	10.394 s	-
Total	appsec	10.706 s	312.424 ms (3.0%)
Total	iast	10.948 s	553.965 ms (5.3%)
Total	profiling	10.88 s	485.87 ms (4.7%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~376888a9f7, baseline=1.44.0-SNAPSHOT~9f01834ab7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (699.014 ms) : 0, 699014
BytebuddyAgent [candidate] (692.796 ms) : 0, 692796
GlobalTracer [baseline] (319.97 ms) : 0, 319970
GlobalTracer [candidate] (317.688 ms) : 0, 317688
AppSec [baseline] (55.137 ms) : 0, 55137
AppSec [candidate] (54.836 ms) : 0, 54836
Remote Config [baseline] (686.628 µs) : 0, 687
Remote Config [candidate] (674.881 µs) : 0, 675
Telemetry [baseline] (7.808 ms) : 0, 7808
Telemetry [candidate] (8.447 ms) : 0, 8447
section appsec
BytebuddyAgent [baseline] (711.206 ms) : 0, 711206
BytebuddyAgent [candidate] (711.48 ms) : 0, 711480
GlobalTracer [baseline] (315.127 ms) : 0, 315127
GlobalTracer [candidate] (315.698 ms) : 0, 315698
AppSec [baseline] (166.808 ms) : 0, 166808
AppSec [candidate] (167.173 ms) : 0, 167173
Remote Config [baseline] (637.316 µs) : 0, 637
Remote Config [candidate] (657.717 µs) : 0, 658
Telemetry [baseline] (8.163 ms) : 0, 8163
Telemetry [candidate] (8.181 ms) : 0, 8181
IAST [baseline] (19.585 ms) : 0, 19585
IAST [candidate] (19.837 ms) : 0, 19837
section iast
BytebuddyAgent [baseline] (812.63 ms) : 0, 812630
BytebuddyAgent [candidate] (811.735 ms) : 0, 811735
GlobalTracer [baseline] (306.591 ms) : 0, 306591
GlobalTracer [candidate] (306.086 ms) : 0, 306086
AppSec [baseline] (57.237 ms) : 0, 57237
AppSec [candidate] (57.736 ms) : 0, 57736
Remote Config [baseline] (628.601 µs) : 0, 629
Remote Config [candidate] (657.777 µs) : 0, 658
Telemetry [baseline] (7.511 ms) : 0, 7511
Telemetry [candidate] (7.55 ms) : 0, 7550
IAST [baseline] (21.683 ms) : 0, 21683
IAST [candidate] (20.997 ms) : 0, 20997
section profiling
ProfilingAgent [baseline] (93.714 ms) : 0, 93714
ProfilingAgent [candidate] (95.409 ms) : 0, 95409
BytebuddyAgent [baseline] (692.077 ms) : 0, 692077
BytebuddyAgent [candidate] (698.166 ms) : 0, 698166
GlobalTracer [baseline] (435.784 ms) : 0, 435784
GlobalTracer [candidate] (437.533 ms) : 0, 437533
AppSec [baseline] (54.016 ms) : 0, 54016
AppSec [candidate] (54.269 ms) : 0, 54269
Remote Config [baseline] (676.493 µs) : 0, 676
Remote Config [candidate] (670.259 µs) : 0, 670
Telemetry [baseline] (7.781 ms) : 0, 7781
Telemetry [candidate] (7.862 ms) : 0, 7862
Profiling [baseline] (93.737 ms) : 0, 93737
Profiling [candidate] (95.433 ms) : 0, 95433

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~376888a9f7, baseline=1.44.0-SNAPSHOT~9f01834ab7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097905
Total [baseline] (8.749 s) : 0, 8749426
Agent [candidate] (1.102 s) : 0, 1101920
Total [candidate] (8.729 s) : 0, 8729306
section iast
Agent [baseline] (1.218 s) : 0, 1217902
Total [baseline] (9.2 s) : 0, 9199636
Agent [candidate] (1.223 s) : 0, 1223310
Total [candidate] (9.224 s) : 0, 9224221
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.228 s) : 0, 1227746
Total [baseline] (9.195 s) : 0, 9194802
Agent [candidate] (1.219 s) : 0, 1219316
Total [candidate] (9.191 s) : 0, 9191280
section iast_TELEMETRY_OFF
Agent [baseline] (1.214 s) : 0, 1213852
Total [baseline] (9.199 s) : 0, 9199423
Agent [candidate] (1.222 s) : 0, 1222264
Total [candidate] (9.194 s) : 0, 9193776

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.098 s	-
Agent	iast	1.218 s	119.997 ms (10.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.228 s	129.841 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.214 s	115.947 ms (10.6%)
Total	tracing	8.749 s	-
Total	iast	9.2 s	450.21 ms (5.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.195 s	445.376 ms (5.1%)
Total	iast_TELEMETRY_OFF	9.199 s	449.998 ms (5.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.102 s	-
Agent	iast	1.223 s	121.39 ms (11.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.219 s	117.397 ms (10.7%)
Agent	iast_TELEMETRY_OFF	1.222 s	120.344 ms (10.9%)
Total	tracing	8.729 s	-
Total	iast	9.224 s	494.915 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.191 s	461.974 ms (5.3%)
Total	iast_TELEMETRY_OFF	9.194 s	464.47 ms (5.3%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~376888a9f7, baseline=1.44.0-SNAPSHOT~9f01834ab7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (700.116 ms) : 0, 700116
BytebuddyAgent [candidate] (699.831 ms) : 0, 699831
GlobalTracer [baseline] (320.31 ms) : 0, 320310
GlobalTracer [candidate] (322.037 ms) : 0, 322037
AppSec [baseline] (55.143 ms) : 0, 55143
AppSec [candidate] (55.448 ms) : 0, 55448
Remote Config [baseline] (682.692 µs) : 0, 683
Remote Config [candidate] (689.504 µs) : 0, 690
Telemetry [baseline] (7.809 ms) : 0, 7809
Telemetry [candidate] (10.051 ms) : 0, 10051
section iast
BytebuddyAgent [baseline] (811.259 ms) : 0, 811259
BytebuddyAgent [candidate] (814.875 ms) : 0, 814875
GlobalTracer [baseline] (305.858 ms) : 0, 305858
GlobalTracer [candidate] (306.817 ms) : 0, 306817
AppSec [baseline] (57.072 ms) : 0, 57072
AppSec [candidate] (57.77 ms) : 0, 57770
IAST [baseline] (21.827 ms) : 0, 21827
IAST [candidate] (21.853 ms) : 0, 21853
Remote Config [baseline] (650.07 µs) : 0, 650
Remote Config [candidate] (634.882 µs) : 0, 635
Telemetry [baseline] (7.516 ms) : 0, 7516
Telemetry [candidate] (7.543 ms) : 0, 7543
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (817.774 ms) : 0, 817774
BytebuddyAgent [candidate] (811.772 ms) : 0, 811772
GlobalTracer [baseline] (308.277 ms) : 0, 308277
GlobalTracer [candidate] (306.596 ms) : 0, 306596
AppSec [baseline] (57.716 ms) : 0, 57716
AppSec [candidate] (57.373 ms) : 0, 57373
IAST [baseline] (21.953 ms) : 0, 21953
IAST [candidate] (21.685 ms) : 0, 21685
Remote Config [baseline] (654.049 µs) : 0, 654
Remote Config [candidate] (621.702 µs) : 0, 622
Telemetry [baseline] (7.498 ms) : 0, 7498
Telemetry [candidate] (7.518 ms) : 0, 7518
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.447 ms) : 0, 807447
BytebuddyAgent [candidate] (813.591 ms) : 0, 813591
GlobalTracer [baseline] (306.196 ms) : 0, 306196
GlobalTracer [candidate] (308.23 ms) : 0, 308230
AppSec [baseline] (57.35 ms) : 0, 57350
AppSec [candidate] (57.162 ms) : 0, 57162
IAST [baseline] (21.143 ms) : 0, 21143
IAST [candidate] (21.344 ms) : 0, 21344
Remote Config [baseline] (653.779 µs) : 0, 654
Remote Config [candidate] (647.265 µs) : 0, 647
Telemetry [baseline] (7.343 ms) : 0, 7343
Telemetry [candidate] (7.471 ms) : 0, 7471

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-29T14:00:09	2024-11-29T14:07:08
git_branch	master	bbujon/crashtracking
git_commit_date	1732876820	1732888175
git_commit_sha	`9f01834`	`376888a`
release_version	1.44.0-SNAPSHOT~9f01834ab7	1.44.0-SNAPSHOT~376888a9f7
start_time	2024-11-29T13:59:56	2024-11-29T14:06:54

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732889579	1732889579
ci_job_id	723558342	723558342
ci_pipeline_id	50146991	50146991
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~376888a9f7, baseline=1.44.0-SNAPSHOT~9f01834ab7
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.929 µs) : 353, 392
.   : milestone, 373,
iast (494.203 µs) : 473, 516
.   : milestone, 494,
iast_FULL (655.596 µs) : 634, 677
.   : milestone, 656,
iast_GLOBAL (511.568 µs) : 490, 533
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (494.977 µs) : 473, 517
.   : milestone, 495,
iast_INACTIVE (451.786 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (480.493 µs) : 459, 502
.   : milestone, 480,
tracing (446.903 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (376.547 µs) : 357, 396
.   : milestone, 377,
iast (485.231 µs) : 464, 507
.   : milestone, 485,
iast_FULL (645.68 µs) : 624, 667
.   : milestone, 646,
iast_GLOBAL (524.169 µs) : 501, 547
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (484.762 µs) : 463, 506
.   : milestone, 485,
iast_INACTIVE (450.83 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (482.987 µs) : 461, 505
.   : milestone, 483,
tracing (445.811 µs) : 425, 467
.   : milestone, 446,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.929 µs [353.465 µs, 392.393 µs]	-
iast	494.203 µs [472.519 µs, 515.888 µs]	121.275 µs (32.5%)
iast_FULL	655.596 µs [634.279 µs, 676.912 µs]	282.667 µs (75.8%)
iast_GLOBAL	511.568 µs [489.716 µs, 533.419 µs]	138.639 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED	494.977 µs [473.205 µs, 516.748 µs]	122.048 µs (32.7%)
iast_INACTIVE	451.786 µs [430.093 µs, 473.479 µs]	78.857 µs (21.1%)
iast_TELEMETRY_OFF	480.493 µs [458.667 µs, 502.318 µs]	107.564 µs (28.8%)
tracing	446.903 µs [425.949 µs, 467.857 µs]	73.974 µs (19.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.547 µs [356.762 µs, 396.331 µs]	-
iast	485.231 µs [463.73 µs, 506.732 µs]	108.684 µs (28.9%)
iast_FULL	645.68 µs [624.268 µs, 667.092 µs]	269.133 µs (71.5%)
iast_GLOBAL	524.169 µs [501.498 µs, 546.839 µs]	147.622 µs (39.2%)
iast_HARDCODED_SECRET_DISABLED	484.762 µs [463.391 µs, 506.134 µs]	108.216 µs (28.7%)
iast_INACTIVE	450.83 µs [429.767 µs, 471.894 µs]	74.284 µs (19.7%)
iast_TELEMETRY_OFF	482.987 µs [461.39 µs, 504.585 µs]	106.44 µs (28.3%)
tracing	445.811 µs [424.537 µs, 467.085 µs]	69.265 µs (18.4%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~376888a9f7, baseline=1.44.0-SNAPSHOT~9f01834ab7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.367 ms) : 1347, 1387
.   : milestone, 1367,
appsec (1.754 ms) : 1729, 1778
.   : milestone, 1754,
appsec_no_iast (1.742 ms) : 1717, 1767
.   : milestone, 1742,
iast (1.495 ms) : 1472, 1518
.   : milestone, 1495,
profiling (1.536 ms) : 1511, 1560
.   : milestone, 1536,
tracing (1.495 ms) : 1471, 1519
.   : milestone, 1495,
section candidate
no_agent (1.351 ms) : 1331, 1370
.   : milestone, 1351,
appsec (1.726 ms) : 1701, 1750
.   : milestone, 1726,
appsec_no_iast (1.757 ms) : 1732, 1781
.   : milestone, 1757,
iast (1.488 ms) : 1465, 1511
.   : milestone, 1488,
profiling (1.549 ms) : 1525, 1573
.   : milestone, 1549,
tracing (1.471 ms) : 1446, 1496
.   : milestone, 1471,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.367 ms [1.347 ms, 1.387 ms]	-
appsec	1.754 ms [1.729 ms, 1.778 ms]	386.454 µs (28.3%)
appsec_no_iast	1.742 ms [1.717 ms, 1.767 ms]	374.616 µs (27.4%)
iast	1.495 ms [1.472 ms, 1.518 ms]	127.781 µs (9.3%)
profiling	1.536 ms [1.511 ms, 1.56 ms]	168.398 µs (12.3%)
tracing	1.495 ms [1.471 ms, 1.519 ms]	127.445 µs (9.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.331 ms, 1.37 ms]	-
appsec	1.726 ms [1.701 ms, 1.75 ms]	375.194 µs (27.8%)
appsec_no_iast	1.757 ms [1.732 ms, 1.781 ms]	405.978 µs (30.1%)
iast	1.488 ms [1.465 ms, 1.511 ms]	137.847 µs (10.2%)
profiling	1.549 ms [1.525 ms, 1.573 ms]	198.684 µs (14.7%)
tracing	1.471 ms [1.446 ms, 1.496 ms]	120.26 µs (8.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/crashtracking
git_commit_date	1732876820	1732888175
git_commit_sha	`9f01834`	`376888a`
release_version	1.44.0-SNAPSHOT~9f01834ab7	1.44.0-SNAPSHOT~376888a9f7

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732890114	1732890114
ci_job_id	723558344	723558344
ci_pipeline_id	50146991	50146991
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~376888a9f7, baseline=1.44.0-SNAPSHOT~9f01834ab7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.235 s) : 15235000, 15235000
.   : milestone, 15235000,
appsec (15.136 s) : 15136000, 15136000
.   : milestone, 15136000,
iast (18.965 s) : 18965000, 18965000
.   : milestone, 18965000,
iast_GLOBAL (18.099 s) : 18099000, 18099000
.   : milestone, 18099000,
profiling (15.018 s) : 15018000, 15018000
.   : milestone, 15018000,
tracing (14.798 s) : 14798000, 14798000
.   : milestone, 14798000,
section candidate
no_agent (15.614 s) : 15614000, 15614000
.   : milestone, 15614000,
appsec (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
iast (18.636 s) : 18636000, 18636000
.   : milestone, 18636000,
iast_GLOBAL (17.859 s) : 17859000, 17859000
.   : milestone, 17859000,
profiling (15.891 s) : 15891000, 15891000
.   : milestone, 15891000,
tracing (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.235 s [15.235 s, 15.235 s]	-
appsec	15.136 s [15.136 s, 15.136 s]	-99.0 ms (-0.6%)
iast	18.965 s [18.965 s, 18.965 s]	3.73 s (24.5%)
iast_GLOBAL	18.099 s [18.099 s, 18.099 s]	2.864 s (18.8%)
profiling	15.018 s [15.018 s, 15.018 s]	-217.0 ms (-1.4%)
tracing	14.798 s [14.798 s, 14.798 s]	-437.0 ms (-2.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.614 s [15.614 s, 15.614 s]	-
appsec	15.013 s [15.013 s, 15.013 s]	-601.0 ms (-3.8%)
iast	18.636 s [18.636 s, 18.636 s]	3.022 s (19.4%)
iast_GLOBAL	17.859 s [17.859 s, 17.859 s]	2.245 s (14.4%)
profiling	15.891 s [15.891 s, 15.891 s]	277.0 ms (1.8%)
tracing	15.009 s [15.009 s, 15.009 s]	-605.0 ms (-3.9%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~376888a9f7, baseline=1.44.0-SNAPSHOT~9f01834ab7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.34 ms) : 2299, 2381
.   : milestone, 2340,
iast (2.086 ms) : 2033, 2138
.   : milestone, 2086,
iast_GLOBAL (2.13 ms) : 2077, 2183
.   : milestone, 2130,
profiling (1.948 ms) : 1906, 1989
.   : milestone, 1948,
tracing (1.93 ms) : 1889, 1970
.   : milestone, 1930,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.34 ms) : 2299, 2381
.   : milestone, 2340,
iast (2.093 ms) : 2040, 2145
.   : milestone, 2093,
iast_GLOBAL (2.132 ms) : 2079, 2184
.   : milestone, 2132,
profiling (1.958 ms) : 1916, 2000
.   : milestone, 1958,
tracing (1.928 ms) : 1888, 1968
.   : milestone, 1928,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.34 ms [2.299 ms, 2.381 ms]	868.247 µs (59.0%)
iast	2.086 ms [2.033 ms, 2.138 ms]	614.053 µs (41.7%)
iast_GLOBAL	2.13 ms [2.077 ms, 2.183 ms]	658.444 µs (44.7%)
profiling	1.948 ms [1.906 ms, 1.989 ms]	475.861 µs (32.3%)
tracing	1.93 ms [1.889 ms, 1.97 ms]	457.881 µs (31.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.457 ms, 1.48 ms]	-
appsec	2.34 ms [2.299 ms, 2.381 ms]	871.238 µs (59.3%)
iast	2.093 ms [2.04 ms, 2.145 ms]	624.053 µs (42.5%)
iast_GLOBAL	2.132 ms [2.079 ms, 2.184 ms]	662.845 µs (45.1%)
profiling	1.958 ms [1.916 ms, 2.0 ms]	488.948 µs (33.3%)
tracing	1.928 ms [1.888 ms, 1.968 ms]	458.721 µs (31.2%)

github-actions · 2024-12-02T08:02:25Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

github-actions · 2024-12-02T08:02:25Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

mcculls

Nice cleanup

fix(smoke-tests): Fix crash tracking setup

376888a

PerfectSlayer marked this pull request as ready for review November 29, 2024 15:06

PerfectSlayer requested a review from a team as a code owner November 29, 2024 15:06

PerfectSlayer requested a review from manuel-alvarez-alvarez November 29, 2024 15:06

mcculls approved these changes Dec 2, 2024

View reviewed changes

PerfectSlayer added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Dec 2, 2024

PerfectSlayer merged commit 626485f into master Dec 2, 2024
116 of 120 checks passed

PerfectSlayer deleted the bbujon/crashtracking branch December 2, 2024 09:43

github-actions bot added this to the 1.44.0 milestone Dec 2, 2024

PerfectSlayer added comp: testing Testing and removed tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Dec 2, 2024

PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash tracking setup in smoke test #8037

Fix crash tracking setup in smoke test #8037

PerfectSlayer commented Nov 29, 2024 •

edited

Loading

pr-commenter bot commented Nov 29, 2024

github-actions bot commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024

mcculls left a comment

Fix crash tracking setup in smoke test #8037

Fix crash tracking setup in smoke test #8037

Conversation

PerfectSlayer commented Nov 29, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 29, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

github-actions bot commented Dec 2, 2024 • edited Loading

github-actions bot commented Dec 2, 2024

mcculls left a comment

Choose a reason for hiding this comment

PerfectSlayer commented Nov 29, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited

Loading