Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UntrustedDeserializationModule to be more generic #7484

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Refactor UntrustedDeserializationModule to be more generic #7484

merged 1 commit into from
Aug 21, 2024

Conversation

Mariovido
Copy link
Contributor

@Mariovido Mariovido commented Aug 21, 2024 •
edited by jira bot
Loading

What Does This Do

Refactors the UntrustedDeserializationModule to a more generic call.

Motivation

We want to avoid having the same function duplicated for different types of objects such as InputStream, Reader, Strings...

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-54452

@Mariovido Mariovido changed the title Refactor UntrustedDeserializationModule call to onObject Refactor UntrustedDeserializationModule to be more generic Aug 21, 2024
@Mariovido Mariovido mentioned this pull request Aug 21, 2024
Merged
5 tasks
@smola smola added tag: no release notes Changes to exclude from release notes type: refactoring comp: asm iast Application Security Management (IAST) labels Aug 21, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 21, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/refactor_untrusted_deserialization
git_commit_date 1724232069 1724246636
git_commit_sha 99cfdba e79cb51
release_version 1.39.0-SNAPSHOT~99cfdba356 1.39.0-SNAPSHOT~e79cb51dcf
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724249011 1724249011
ci_job_id 612161131 612161131
ci_pipeline_id 42420157 42420157
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~e79cb51dcf, baseline=1.39.0-SNAPSHOT~99cfdba356

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048901
Total [baseline] (8.506 s) : 0, 8506080
Agent [candidate] (1.047 s) : 0, 1046678
Total [candidate] (8.521 s) : 0, 8521452
section iast
Agent [baseline] (1.197 s) : 0, 1197255
Total [baseline] (9.028 s) : 0, 9027958
Agent [candidate] (1.177 s) : 0, 1177498
Total [candidate] (8.973 s) : 0, 8973384
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177939
Total [baseline] (8.96 s) : 0, 8960263
Agent [candidate] (1.182 s) : 0, 1181708
Total [candidate] (9.042 s) : 0, 9042259
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175187
Total [baseline] (9.016 s) : 0, 9015858
Agent [candidate] (1.172 s) : 0, 1172136
Total [candidate] (8.972 s) : 0, 8971535
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.197 s 148.354 ms (14.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 129.038 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.175 s 126.285 ms (12.0%)
Total tracing 8.506 s -
Total iast 9.028 s 521.878 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 454.182 ms (5.3%)
Total iast_TELEMETRY_OFF 9.016 s 509.778 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.177 s 130.82 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.182 s 135.03 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.172 s 125.458 ms (12.0%)
Total tracing 8.521 s -
Total iast 8.973 s 451.932 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.042 s 520.807 ms (6.1%)
Total iast_TELEMETRY_OFF 8.972 s 450.082 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~e79cb51dcf, baseline=1.39.0-SNAPSHOT~99cfdba356

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.174 ms) : 0, 669174
BytebuddyAgent [candidate] (667.527 ms) : 0, 667527
GlobalTracer [baseline] (307.008 ms) : 0, 307008
GlobalTracer [candidate] (306.377 ms) : 0, 306377
AppSec [baseline] (51.103 ms) : 0, 51103
AppSec [candidate] (51.075 ms) : 0, 51075
Remote Config [baseline] (680.321 µs) : 0, 680
Remote Config [candidate] (685.278 µs) : 0, 685
Telemetry [baseline] (7.454 ms) : 0, 7454
Telemetry [candidate] (7.495 ms) : 0, 7495
section iast
BytebuddyAgent [baseline] (797.039 ms) : 0, 797039
BytebuddyAgent [candidate] (782.815 ms) : 0, 782815
GlobalTracer [baseline] (301.385 ms) : 0, 301385
GlobalTracer [candidate] (296.881 ms) : 0, 296881
AppSec [baseline] (53.832 ms) : 0, 53832
AppSec [candidate] (53.31 ms) : 0, 53310
IAST [baseline] (22.605 ms) : 0, 22605
IAST [candidate] (22.454 ms) : 0, 22454
Remote Config [baseline] (588.057 µs) : 0, 588
Remote Config [candidate] (578.439 µs) : 0, 578
Telemetry [baseline] (8.105 ms) : 0, 8105
Telemetry [candidate] (7.949 ms) : 0, 7949
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.958 ms) : 0, 782958
BytebuddyAgent [candidate] (784.313 ms) : 0, 784313
GlobalTracer [baseline] (296.736 ms) : 0, 296736
GlobalTracer [candidate] (298.663 ms) : 0, 298663
AppSec [baseline] (51.086 ms) : 0, 51086
AppSec [candidate] (48.884 ms) : 0, 48884
IAST [baseline] (24.339 ms) : 0, 24339
IAST [candidate] (26.022 ms) : 0, 26022
Remote Config [baseline] (583.398 µs) : 0, 583
Remote Config [candidate] (580.169 µs) : 0, 580
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (9.656 ms) : 0, 9656
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.14 ms) : 0, 781140
BytebuddyAgent [candidate] (779.48 ms) : 0, 779480
GlobalTracer [baseline] (297.576 ms) : 0, 297576
GlobalTracer [candidate] (296.797 ms) : 0, 296797
AppSec [baseline] (52.226 ms) : 0, 52226
AppSec [candidate] (53.017 ms) : 0, 53017
IAST [baseline] (22.25 ms) : 0, 22250
IAST [candidate] (21.566 ms) : 0, 21566
Remote Config [baseline] (619.495 µs) : 0, 619
Remote Config [candidate] (623.761 µs) : 0, 624
Telemetry [baseline] (7.841 ms) : 0, 7841
Telemetry [candidate] (7.145 ms) : 0, 7145
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~e79cb51dcf, baseline=1.39.0-SNAPSHOT~99cfdba356

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056493
Total [baseline] (10.431 s) : 0, 10431301
Agent [candidate] (1.049 s) : 0, 1048661
Total [candidate] (10.388 s) : 0, 10387791
section appsec
Agent [baseline] (1.184 s) : 0, 1184400
Total [baseline] (10.557 s) : 0, 10557193
Agent [candidate] (1.167 s) : 0, 1167145
Total [candidate] (10.441 s) : 0, 10440837
section iast
Agent [baseline] (1.177 s) : 0, 1176697
Total [baseline] (10.898 s) : 0, 10897754
Agent [candidate] (1.179 s) : 0, 1179158
Total [candidate] (10.912 s) : 0, 10912087
section profiling
Agent [baseline] (1.25 s) : 0, 1249723
Total [baseline] (10.602 s) : 0, 10601826
Agent [candidate] (1.261 s) : 0, 1260895
Total [candidate] (10.675 s) : 0, 10674736
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.184 s 127.907 ms (12.1%)
Agent iast 1.177 s 120.204 ms (11.4%)
Agent profiling 1.25 s 193.23 ms (18.3%)
Total tracing 10.431 s -
Total appsec 10.557 s 125.892 ms (1.2%)
Total iast 10.898 s 466.452 ms (4.5%)
Total profiling 10.602 s 170.524 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.167 s 118.484 ms (11.3%)
Agent iast 1.179 s 130.497 ms (12.4%)
Agent profiling 1.261 s 212.234 ms (20.2%)
Total tracing 10.388 s -
Total appsec 10.441 s 53.045 ms (0.5%)
Total iast 10.912 s 524.296 ms (5.0%)
Total profiling 10.675 s 286.945 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~e79cb51dcf, baseline=1.39.0-SNAPSHOT~99cfdba356

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.456 ms) : 0, 674456
BytebuddyAgent [candidate] (668.76 ms) : 0, 668760
GlobalTracer [baseline] (309.021 ms) : 0, 309021
GlobalTracer [candidate] (307.083 ms) : 0, 307083
AppSec [baseline] (51.215 ms) : 0, 51215
AppSec [candidate] (51.207 ms) : 0, 51207
Remote Config [baseline] (694.241 µs) : 0, 694
Remote Config [candidate] (687.948 µs) : 0, 688
Telemetry [baseline] (7.545 ms) : 0, 7545
Telemetry [candidate] (7.458 ms) : 0, 7458
section appsec
BytebuddyAgent [baseline] (689.093 ms) : 0, 689093
BytebuddyAgent [candidate] (677.616 ms) : 0, 677616
GlobalTracer [baseline] (303.771 ms) : 0, 303771
GlobalTracer [candidate] (299.802 ms) : 0, 299802
AppSec [baseline] (158.094 ms) : 0, 158094
AppSec [candidate] (156.857 ms) : 0, 156857
IAST [baseline] (20.149 ms) : 0, 20149
IAST [candidate] (20.225 ms) : 0, 20225
Remote Config [baseline] (612.577 µs) : 0, 613
Remote Config [candidate] (601.716 µs) : 0, 602
Telemetry [baseline] (9.05 ms) : 0, 9050
Telemetry [candidate] (8.653 ms) : 0, 8653
section iast
BytebuddyAgent [baseline] (782.462 ms) : 0, 782462
BytebuddyAgent [candidate] (783.667 ms) : 0, 783667
GlobalTracer [baseline] (296.382 ms) : 0, 296382
GlobalTracer [candidate] (297.233 ms) : 0, 297233
AppSec [baseline] (52.484 ms) : 0, 52484
AppSec [candidate] (50.068 ms) : 0, 50068
IAST [baseline] (23.322 ms) : 0, 23322
IAST [candidate] (25.233 ms) : 0, 25233
Remote Config [baseline] (605.615 µs) : 0, 606
Remote Config [candidate] (579.224 µs) : 0, 579
Telemetry [baseline] (7.954 ms) : 0, 7954
Telemetry [candidate] (8.829 ms) : 0, 8829
section profiling
BytebuddyAgent [baseline] (667.899 ms) : 0, 667899
BytebuddyAgent [candidate] (671.907 ms) : 0, 671907
GlobalTracer [baseline] (389.334 ms) : 0, 389334
GlobalTracer [candidate] (393.293 ms) : 0, 393293
AppSec [baseline] (52.056 ms) : 0, 52056
AppSec [candidate] (53.168 ms) : 0, 53168
Remote Config [baseline] (693.893 µs) : 0, 694
Remote Config [candidate] (693.899 µs) : 0, 694
Telemetry [baseline] (7.644 ms) : 0, 7644
Telemetry [candidate] (7.471 ms) : 0, 7471
ProfilingAgent [baseline] (94.663 ms) : 0, 94663
ProfilingAgent [candidate] (96.645 ms) : 0, 96645
Profiling [baseline] (94.687 ms) : 0, 94687
Profiling [candidate] (96.671 ms) : 0, 96671
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-21T13:36:09 2024-08-21T13:42:59
git_branch master mario.vidal/refactor_untrusted_deserialization
git_commit_date 1724232069 1724246636
git_commit_sha 99cfdba e79cb51
release_version 1.39.0-SNAPSHOT~99cfdba356 1.39.0-SNAPSHOT~e79cb51dcf
start_time 2024-08-21T13:35:55 2024-08-21T13:42:46
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724248125 1724248125
ci_job_id 612161133 612161133
ci_pipeline_id 42420157 42420157
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-95.735µs; -41.187µs] or [-6.149%; -2.645%]		 unstable
[-484.417op/s; +712.338op/s] or [-16.349%; +24.041%]		 1.488ms 3076.923op/s 1.557ms 2962.963op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~e79cb51dcf, baseline=1.39.0-SNAPSHOT~99cfdba356
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.966 µs) : 350, 390
.   : milestone, 370,
iast (490.538 µs) : 469, 512
.   : milestone, 491,
iast_FULL (548.854 µs) : 527, 571
.   : milestone, 549,
iast_GLOBAL (505.78 µs) : 484, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (485.481 µs) : 464, 507
.   : milestone, 485,
iast_INACTIVE (459.185 µs) : 436, 482
.   : milestone, 459,
iast_TELEMETRY_OFF (473.008 µs) : 452, 494
.   : milestone, 473,
tracing (443.924 µs) : 424, 464
.   : milestone, 444,
section candidate
no_agent (370.171 µs) : 349, 391
.   : milestone, 370,
iast (488.274 µs) : 467, 510
.   : milestone, 488,
iast_FULL (555.464 µs) : 533, 578
.   : milestone, 555,
iast_GLOBAL (510.051 µs) : 487, 533
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (489.271 µs) : 468, 511
.   : milestone, 489,
iast_INACTIVE (458.109 µs) : 436, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (479.081 µs) : 458, 500
.   : milestone, 479,
tracing (441.379 µs) : 421, 462
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.966 µs [349.691 µs, 390.24 µs] -
iast 490.538 µs [468.879 µs, 512.197 µs] 120.572 µs (32.6%)
iast_FULL 548.854 µs [526.619 µs, 571.09 µs] 178.889 µs (48.4%)
iast_GLOBAL 505.78 µs [483.69 µs, 527.869 µs] 135.814 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 485.481 µs [464.075 µs, 506.887 µs] 115.515 µs (31.2%)
iast_INACTIVE 459.185 µs [436.186 µs, 482.184 µs] 89.219 µs (24.1%)
iast_TELEMETRY_OFF 473.008 µs [451.723 µs, 494.293 µs] 103.043 µs (27.9%)
tracing 443.924 µs [423.738 µs, 464.111 µs] 73.959 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.171 µs [349.496 µs, 390.847 µs] -
iast 488.274 µs [467.021 µs, 509.527 µs] 118.103 µs (31.9%)
iast_FULL 555.464 µs [532.903 µs, 578.024 µs] 185.292 µs (50.1%)
iast_GLOBAL 510.051 µs [487.286 µs, 532.816 µs] 139.879 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 489.271 µs [467.646 µs, 510.897 µs] 119.1 µs (32.2%)
iast_INACTIVE 458.109 µs [435.813 µs, 480.405 µs] 87.938 µs (23.8%)
iast_TELEMETRY_OFF 479.081 µs [457.806 µs, 500.357 µs] 108.91 µs (29.4%)
tracing 441.379 µs [420.871 µs, 461.886 µs] 71.207 µs (19.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~e79cb51dcf, baseline=1.39.0-SNAPSHOT~99cfdba356
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1366
.   : milestone, 1346,
appsec (1.71 ms) : 1686, 1735
.   : milestone, 1710,
appsec_no_iast (1.702 ms) : 1677, 1726
.   : milestone, 1702,
iast (1.489 ms) : 1466, 1511
.   : milestone, 1489,
profiling (1.557 ms) : 1531, 1583
.   : milestone, 1557,
tracing (1.473 ms) : 1448, 1497
.   : milestone, 1473,
section candidate
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.747 ms) : 1723, 1771
.   : milestone, 1747,
appsec_no_iast (1.757 ms) : 1733, 1781
.   : milestone, 1757,
iast (1.484 ms) : 1461, 1507
.   : milestone, 1484,
profiling (1.488 ms) : 1464, 1513
.   : milestone, 1488,
tracing (1.457 ms) : 1431, 1482
.   : milestone, 1457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.366 ms] -
appsec 1.71 ms [1.686 ms, 1.735 ms] 364.403 µs (27.1%)
appsec_no_iast 1.702 ms [1.677 ms, 1.726 ms] 355.589 µs (26.4%)
iast 1.489 ms [1.466 ms, 1.511 ms] 142.736 µs (10.6%)
profiling 1.557 ms [1.531 ms, 1.583 ms] 210.846 µs (15.7%)
tracing 1.473 ms [1.448 ms, 1.497 ms] 126.514 µs (9.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.747 ms [1.723 ms, 1.771 ms] 403.609 µs (30.0%)
appsec_no_iast 1.757 ms [1.733 ms, 1.781 ms] 413.933 µs (30.8%)
iast 1.484 ms [1.461 ms, 1.507 ms] 140.645 µs (10.5%)
profiling 1.488 ms [1.464 ms, 1.513 ms] 145.103 µs (10.8%)
tracing 1.457 ms [1.431 ms, 1.482 ms] 113.389 µs (8.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/refactor_untrusted_deserialization
git_commit_date 1724232069 1724246636
git_commit_sha 99cfdba e79cb51
release_version 1.39.0-SNAPSHOT~99cfdba356 1.39.0-SNAPSHOT~e79cb51dcf
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724248621 1724248621
ci_job_id 612161135 612161135
ci_pipeline_id 42420157 42420157
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~e79cb51dcf, baseline=1.39.0-SNAPSHOT~99cfdba356
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.235 ms) : 2200, 2269
.   : milestone, 2235,
iast (1.954 ms) : 1913, 1996
.   : milestone, 1954,
iast_GLOBAL (2.01 ms) : 1967, 2052
.   : milestone, 2010,
profiling (1.855 ms) : 1821, 1889
.   : milestone, 1855,
tracing (1.841 ms) : 1807, 1874
.   : milestone, 1841,
section candidate
no_agent (1.46 ms) : 1449, 1471
.   : milestone, 1460,
appsec (2.222 ms) : 2187, 2256
.   : milestone, 2222,
iast (1.961 ms) : 1919, 2003
.   : milestone, 1961,
iast_GLOBAL (2.016 ms) : 1972, 2060
.   : milestone, 2016,
profiling (1.846 ms) : 1812, 1879
.   : milestone, 1846,
tracing (1.837 ms) : 1804, 1870
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.235 ms [2.2 ms, 2.269 ms] 777.093 µs (53.3%)
iast 1.954 ms [1.913 ms, 1.996 ms] 497.023 µs (34.1%)
iast_GLOBAL 2.01 ms [1.967 ms, 2.052 ms] 552.103 µs (37.9%)
profiling 1.855 ms [1.821 ms, 1.889 ms] 397.749 µs (27.3%)
tracing 1.841 ms [1.807 ms, 1.874 ms] 383.092 µs (26.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.471 ms] -
appsec 2.222 ms [2.187 ms, 2.256 ms] 761.752 µs (52.2%)
iast 1.961 ms [1.919 ms, 2.003 ms] 501.394 µs (34.3%)
iast_GLOBAL 2.016 ms [1.972 ms, 2.06 ms] 556.121 µs (38.1%)
profiling 1.846 ms [1.812 ms, 1.879 ms] 385.743 µs (26.4%)
tracing 1.837 ms [1.804 ms, 1.87 ms] 377.083 µs (25.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~e79cb51dcf, baseline=1.39.0-SNAPSHOT~99cfdba356
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.103 s) : 15103000, 15103000
.   : milestone, 15103000,
appsec (15.344 s) : 15344000, 15344000
.   : milestone, 15344000,
iast (19.404 s) : 19404000, 19404000
.   : milestone, 19404000,
iast_GLOBAL (17.679 s) : 17679000, 17679000
.   : milestone, 17679000,
profiling (14.942 s) : 14942000, 14942000
.   : milestone, 14942000,
tracing (15.234 s) : 15234000, 15234000
.   : milestone, 15234000,
section candidate
no_agent (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
appsec (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
iast (19.053 s) : 19053000, 19053000
.   : milestone, 19053000,
iast_GLOBAL (17.921 s) : 17921000, 17921000
.   : milestone, 17921000,
profiling (14.84 s) : 14840000, 14840000
.   : milestone, 14840000,
tracing (15.118 s) : 15118000, 15118000
.   : milestone, 15118000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.103 s [15.103 s, 15.103 s] -
appsec 15.344 s [15.344 s, 15.344 s] 241.0 ms (1.6%)
iast 19.404 s [19.404 s, 19.404 s] 4.301 s (28.5%)
iast_GLOBAL 17.679 s [17.679 s, 17.679 s] 2.576 s (17.1%)
profiling 14.942 s [14.942 s, 14.942 s] -161.0 ms (-1.1%)
tracing 15.234 s [15.234 s, 15.234 s] 131.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.009 s [15.009 s, 15.009 s] -
appsec 15.075 s [15.075 s, 15.075 s] 66.0 ms (0.4%)
iast 19.053 s [19.053 s, 19.053 s] 4.044 s (26.9%)
iast_GLOBAL 17.921 s [17.921 s, 17.921 s] 2.912 s (19.4%)
profiling 14.84 s [14.84 s, 14.84 s] -169.0 ms (-1.1%)
tracing 15.118 s [15.118 s, 15.118 s] 109.0 ms (0.7%)

@Mariovido Mariovido marked this pull request as ready for review August 21, 2024 14:06
@Mariovido Mariovido requested review from a team as code owners August 21, 2024 14:06
@Mariovido Mariovido merged commit b6464a6 into master Aug 21, 2024
80 checks passed
@Mariovido Mariovido deleted the mario.vidal/refactor_untrusted_deserialization branch August 21, 2024 14:10
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.39.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mariovido @smola