Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protobuf collections as safe ones #7438

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add protobuf collections as safe ones #7438

merged 1 commit into from
Aug 26, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Aug 14, 2024 •
edited by jira bot
Loading

What Does This Do

protobuf collections used are specific ones implementing JDK interfaces. They are in-memory collection so it is safe to handle them like the JDK ones.
https://github.com/protocolbuffers/protobuf/tree/main/java/core/src/main/java/com/google/protobuf

Motivation

DSM live payload feature

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2779

@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1724419675 1724420054
end_time 2024-08-23T13:29:10 2024-08-23T13:35:28
git_branch master jpbempel/add-protobuf-collection
git_commit_sha 0720a77 eee82fb
start_time 2024-08-23T13:27:56 2024-08-23T13:34:15
See matching parameters
Baseline Candidate
ci_job_id 615231238 615231238
ci_pipeline_id 42677627 42677627
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1724419061 1724419061

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 3 metrics, 7 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+566.305µs; +582.613µs] or [+5.462%; +5.619%]		 worse
[+543.660µs; +608.946µs] or [+5.160%; +5.780%]		 worse
[+521.016µs; +630.985µs] or [+4.906%; +5.942%]		 worse
[+394.043µs; +800.703µs] or [+3.583%; +7.281%]		 worse
[-5.968op/s; -4.047op/s] or [-6.356%; -4.310%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-31.122µs; +42.045µs] or [-11.894%; +16.068%]		 unstable
[-48.150µs; +60.075µs] or [-15.987%; +19.947%]		 unstable
[-59.073µs; +69.138µs] or [-18.739%; +21.932%]		 unstable
[-204.137µs; +455.609µs] or [-31.281%; +69.816%]		 unstable
[-102.141op/s; +174.266op/s] or [-3.830%; +6.535%]
scenario:basic same same same unstable
[-6.608µs; +76.762µs] or [-1.136%; +13.197%]		 unstable
[-136.922op/s; +271.874op/s] or [-5.340%; +10.603%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (301.177 µs) : 262, 340
.   : milestone, 301,
basic (296.723 µs) : 287, 307
.   : milestone, 297,
loop (10.535 ms) : 10499, 10571
.   : milestone, 10535,
section candidate
noprobe (307.139 µs) : 245, 369
.   : milestone, 307,
basic (294.253 µs) : 281, 308
.   : milestone, 294,
loop (11.111 ms) : 11088, 11135
.   : milestone, 11111,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 301.177 µs [262.31 µs, 340.043 µs]
basic 296.723 µs [286.64 µs, 306.807 µs]
loop 10.535 ms [10.499 ms, 10.571 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 307.139 µs [245.328 µs, 368.95 µs]
basic 294.253 µs [280.599 µs, 307.908 µs]
loop 11.111 ms [11.088 ms, 11.135 ms]

@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/add-protobuf-collection
git_commit_date 1724414464 1724419061
git_commit_sha 0720a77 eee82fb
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~eee82fb98f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724421374 1724421374
ci_job_id 615231232 615231232
ci_pipeline_id 42677627 42677627
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~eee82fb98f, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052129
Total [baseline] (10.435 s) : 0, 10434986
Agent [candidate] (1.05 s) : 0, 1050477
Total [candidate] (10.313 s) : 0, 10312996
section appsec
Agent [baseline] (1.175 s) : 0, 1174744
Total [baseline] (10.486 s) : 0, 10485742
Agent [candidate] (1.173 s) : 0, 1172593
Total [candidate] (10.498 s) : 0, 10498463
section iast
Agent [baseline] (1.176 s) : 0, 1176211
Total [baseline] (10.849 s) : 0, 10848681
Agent [candidate] (1.179 s) : 0, 1179389
Total [candidate] (10.841 s) : 0, 10841142
section profiling
Agent [baseline] (1.246 s) : 0, 1245519
Total [baseline] (10.646 s) : 0, 10645613
Agent [candidate] (1.255 s) : 0, 1255408
Total [candidate] (10.628 s) : 0, 10627737
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.175 s 122.615 ms (11.7%)
Agent iast 1.176 s 124.082 ms (11.8%)
Agent profiling 1.246 s 193.39 ms (18.4%)
Total tracing 10.435 s -
Total appsec 10.486 s 50.756 ms (0.5%)
Total iast 10.849 s 413.695 ms (4.0%)
Total profiling 10.646 s 210.627 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.173 s 122.116 ms (11.6%)
Agent iast 1.179 s 128.912 ms (12.3%)
Agent profiling 1.255 s 204.931 ms (19.5%)
Total tracing 10.313 s -
Total appsec 10.498 s 185.467 ms (1.8%)
Total iast 10.841 s 528.146 ms (5.1%)
Total profiling 10.628 s 314.741 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~eee82fb98f, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.45 ms) : 0, 671450
BytebuddyAgent [candidate] (669.646 ms) : 0, 669646
GlobalTracer [baseline] (307.851 ms) : 0, 307851
GlobalTracer [candidate] (308.181 ms) : 0, 308181
AppSec [baseline] (51.192 ms) : 0, 51192
AppSec [candidate] (51.003 ms) : 0, 51003
Remote Config [baseline] (664.825 µs) : 0, 665
Remote Config [candidate] (684.237 µs) : 0, 684
Telemetry [baseline] (7.493 ms) : 0, 7493
Telemetry [candidate] (7.486 ms) : 0, 7486
section appsec
BytebuddyAgent [baseline] (681.085 ms) : 0, 681085
BytebuddyAgent [candidate] (679.913 ms) : 0, 679913
GlobalTracer [baseline] (302.223 ms) : 0, 302223
GlobalTracer [candidate] (301.192 ms) : 0, 301192
AppSec [baseline] (157.225 ms) : 0, 157225
AppSec [candidate] (157.311 ms) : 0, 157311
IAST [baseline] (20.901 ms) : 0, 20901
IAST [candidate] (22.707 ms) : 0, 22707
Remote Config [baseline] (611.701 µs) : 0, 612
Remote Config [candidate] (599.913 µs) : 0, 600
Telemetry [baseline] (9.674 ms) : 0, 9674
Telemetry [candidate] (8.673 ms) : 0, 8673
section iast
BytebuddyAgent [baseline] (780.708 ms) : 0, 780708
BytebuddyAgent [candidate] (784.023 ms) : 0, 784023
GlobalTracer [baseline] (297.412 ms) : 0, 297412
GlobalTracer [candidate] (296.999 ms) : 0, 296999
AppSec [baseline] (49.149 ms) : 0, 49149
AppSec [candidate] (52.001 ms) : 0, 52001
IAST [baseline] (26.916 ms) : 0, 26916
IAST [candidate] (23.457 ms) : 0, 23457
Remote Config [baseline] (586.685 µs) : 0, 587
Remote Config [candidate] (606.095 µs) : 0, 606
Telemetry [baseline] (7.923 ms) : 0, 7923
Telemetry [candidate] (8.794 ms) : 0, 8794
section profiling
BytebuddyAgent [baseline] (664.438 ms) : 0, 664438
BytebuddyAgent [candidate] (668.319 ms) : 0, 668319
GlobalTracer [baseline] (389.359 ms) : 0, 389359
GlobalTracer [candidate] (392.863 ms) : 0, 392863
AppSec [baseline] (52.498 ms) : 0, 52498
AppSec [candidate] (52.767 ms) : 0, 52767
Remote Config [baseline] (668.555 µs) : 0, 669
Remote Config [candidate] (704.753 µs) : 0, 705
Telemetry [baseline] (7.311 ms) : 0, 7311
Telemetry [candidate] (7.464 ms) : 0, 7464
ProfilingAgent [baseline] (94.101 ms) : 0, 94101
ProfilingAgent [candidate] (95.798 ms) : 0, 95798
Profiling [baseline] (94.125 ms) : 0, 94125
Profiling [candidate] (95.822 ms) : 0, 95822
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~eee82fb98f, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051822
Total [baseline] (8.504 s) : 0, 8504224
Agent [candidate] (1.049 s) : 0, 1049066
Total [candidate] (8.547 s) : 0, 8546720
section iast
Agent [baseline] (1.176 s) : 0, 1176038
Total [baseline] (9.013 s) : 0, 9013109
Agent [candidate] (1.179 s) : 0, 1178671
Total [candidate] (9.014 s) : 0, 9013719
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177684
Total [baseline] (8.967 s) : 0, 8966801
Agent [candidate] (1.18 s) : 0, 1180290
Total [candidate] (8.978 s) : 0, 8978317
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1179225
Total [baseline] (8.998 s) : 0, 8998200
Agent [candidate] (1.182 s) : 0, 1181797
Total [candidate] (8.997 s) : 0, 8997484
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.176 s 124.216 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 125.862 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.179 s 127.403 ms (12.1%)
Total tracing 8.504 s -
Total iast 9.013 s 508.885 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.967 s 462.577 ms (5.4%)
Total iast_TELEMETRY_OFF 8.998 s 493.976 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.179 s 129.604 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.18 s 131.224 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.182 s 132.73 ms (12.7%)
Total tracing 8.547 s -
Total iast 9.014 s 466.999 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.978 s 431.597 ms (5.0%)
Total iast_TELEMETRY_OFF 8.997 s 450.764 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~eee82fb98f, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.097 ms) : 0, 671097
BytebuddyAgent [candidate] (668.916 ms) : 0, 668916
GlobalTracer [baseline] (307.637 ms) : 0, 307637
GlobalTracer [candidate] (307.766 ms) : 0, 307766
AppSec [baseline] (51.474 ms) : 0, 51474
AppSec [candidate] (50.831 ms) : 0, 50831
Remote Config [baseline] (683.928 µs) : 0, 684
Remote Config [candidate] (688.875 µs) : 0, 689
Telemetry [baseline] (7.454 ms) : 0, 7454
Telemetry [candidate] (7.44 ms) : 0, 7440
section iast
BytebuddyAgent [baseline] (781.105 ms) : 0, 781105
BytebuddyAgent [candidate] (783.636 ms) : 0, 783636
GlobalTracer [baseline] (297.026 ms) : 0, 297026
GlobalTracer [candidate] (296.776 ms) : 0, 296776
AppSec [baseline] (49.839 ms) : 0, 49839
AppSec [candidate] (51.029 ms) : 0, 51029
IAST [baseline] (24.479 ms) : 0, 24479
IAST [candidate] (23.538 ms) : 0, 23538
Remote Config [baseline] (600.202 µs) : 0, 600
Remote Config [candidate] (586.032 µs) : 0, 586
Telemetry [baseline] (9.436 ms) : 0, 9436
Telemetry [candidate] (9.602 ms) : 0, 9602
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.846 ms) : 0, 780846
BytebuddyAgent [candidate] (782.789 ms) : 0, 782789
GlobalTracer [baseline] (297.468 ms) : 0, 297468
GlobalTracer [candidate] (299.354 ms) : 0, 299354
AppSec [baseline] (48.988 ms) : 0, 48988
AppSec [candidate] (49.883 ms) : 0, 49883
IAST [baseline] (26.657 ms) : 0, 26657
IAST [candidate] (24.496 ms) : 0, 24496
Remote Config [baseline] (608.637 µs) : 0, 609
Remote Config [candidate] (590.316 µs) : 0, 590
Telemetry [baseline] (9.603 ms) : 0, 9603
Telemetry [candidate] (9.648 ms) : 0, 9648
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.615 ms) : 0, 782615
BytebuddyAgent [candidate] (786.135 ms) : 0, 786135
GlobalTracer [baseline] (299.383 ms) : 0, 299383
GlobalTracer [candidate] (299.476 ms) : 0, 299476
AppSec [baseline] (50.529 ms) : 0, 50529
AppSec [candidate] (50.841 ms) : 0, 50841
IAST [baseline] (23.048 ms) : 0, 23048
IAST [candidate] (23.248 ms) : 0, 23248
Remote Config [baseline] (591.565 µs) : 0, 592
Remote Config [candidate] (621.706 µs) : 0, 622
Telemetry [baseline] (9.521 ms) : 0, 9521
Telemetry [candidate] (7.855 ms) : 0, 7855
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-23T13:28:59 2024-08-23T13:35:47
git_branch master jpbempel/add-protobuf-collection
git_commit_date 1724414464 1724419061
git_commit_sha 0720a77 eee82fb
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~eee82fb98f
start_time 2024-08-23T13:28:46 2024-08-23T13:35:34
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724420493 1724420493
ci_job_id 615231233 615231233
ci_pipeline_id 42677627 42677627
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~eee82fb98f, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1381
.   : milestone, 1361,
appsec (1.724 ms) : 1700, 1747
.   : milestone, 1724,
appsec_no_iast (1.721 ms) : 1698, 1745
.   : milestone, 1721,
iast (1.468 ms) : 1446, 1491
.   : milestone, 1468,
profiling (1.487 ms) : 1462, 1512
.   : milestone, 1487,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,
section candidate
no_agent (1.346 ms) : 1327, 1366
.   : milestone, 1346,
appsec (1.728 ms) : 1705, 1751
.   : milestone, 1728,
appsec_no_iast (1.742 ms) : 1717, 1767
.   : milestone, 1742,
iast (1.478 ms) : 1455, 1500
.   : milestone, 1478,
profiling (1.531 ms) : 1505, 1557
.   : milestone, 1531,
tracing (1.483 ms) : 1459, 1507
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.341 ms, 1.381 ms] -
appsec 1.724 ms [1.7 ms, 1.747 ms] 362.559 µs (26.6%)
appsec_no_iast 1.721 ms [1.698 ms, 1.745 ms] 360.382 µs (26.5%)
iast 1.468 ms [1.446 ms, 1.491 ms] 107.319 µs (7.9%)
profiling 1.487 ms [1.462 ms, 1.512 ms] 126.183 µs (9.3%)
tracing 1.482 ms [1.458 ms, 1.506 ms] 120.746 µs (8.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.366 ms] -
appsec 1.728 ms [1.705 ms, 1.751 ms] 381.548 µs (28.3%)
appsec_no_iast 1.742 ms [1.717 ms, 1.767 ms] 395.804 µs (29.4%)
iast 1.478 ms [1.455 ms, 1.5 ms] 131.398 µs (9.8%)
profiling 1.531 ms [1.505 ms, 1.557 ms] 184.406 µs (13.7%)
tracing 1.483 ms [1.459 ms, 1.507 ms] 136.577 µs (10.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~eee82fb98f, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.069 µs) : 349, 389
.   : milestone, 369,
iast (484.277 µs) : 462, 507
.   : milestone, 484,
iast_FULL (548.112 µs) : 526, 570
.   : milestone, 548,
iast_GLOBAL (500.409 µs) : 478, 522
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (477.211 µs) : 455, 499
.   : milestone, 477,
iast_INACTIVE (442.113 µs) : 420, 464
.   : milestone, 442,
iast_TELEMETRY_OFF (469.01 µs) : 448, 490
.   : milestone, 469,
tracing (438.304 µs) : 417, 459
.   : milestone, 438,
section candidate
no_agent (358.89 µs) : 339, 378
.   : milestone, 359,
iast (486.498 µs) : 465, 508
.   : milestone, 486,
iast_FULL (548.302 µs) : 526, 571
.   : milestone, 548,
iast_GLOBAL (512.505 µs) : 489, 536
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (475.857 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (449.37 µs) : 427, 472
.   : milestone, 449,
iast_TELEMETRY_OFF (468.919 µs) : 447, 491
.   : milestone, 469,
tracing (437.915 µs) : 417, 459
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.069 µs [349.412 µs, 388.725 µs] -
iast 484.277 µs [461.71 µs, 506.844 µs] 115.209 µs (31.2%)
iast_FULL 548.112 µs [526.317 µs, 569.907 µs] 179.044 µs (48.5%)
iast_GLOBAL 500.409 µs [478.34 µs, 522.479 µs] 131.341 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 477.211 µs [454.999 µs, 499.423 µs] 108.142 µs (29.3%)
iast_INACTIVE 442.113 µs [420.459 µs, 463.766 µs] 73.044 µs (19.8%)
iast_TELEMETRY_OFF 469.01 µs [447.807 µs, 490.213 µs] 99.942 µs (27.1%)
tracing 438.304 µs [417.441 µs, 459.166 µs] 69.235 µs (18.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.89 µs [339.391 µs, 378.39 µs] -
iast 486.498 µs [465.173 µs, 507.822 µs] 127.607 µs (35.6%)
iast_FULL 548.302 µs [525.907 µs, 570.696 µs] 189.411 µs (52.8%)
iast_GLOBAL 512.505 µs [488.972 µs, 536.039 µs] 153.615 µs (42.8%)
iast_HARDCODED_SECRET_DISABLED 475.857 µs [454.722 µs, 496.992 µs] 116.967 µs (32.6%)
iast_INACTIVE 449.37 µs [427.206 µs, 471.534 µs] 90.479 µs (25.2%)
iast_TELEMETRY_OFF 468.919 µs [447.336 µs, 490.503 µs] 110.029 µs (30.7%)
tracing 437.915 µs [417.325 µs, 458.504 µs] 79.024 µs (22.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/add-protobuf-collection
git_commit_date 1724414464 1724419061
git_commit_sha 0720a77 eee82fb
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~eee82fb98f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724421658 1724421658
ci_job_id 615231234 615231234
ci_pipeline_id 42677627 42677627
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~eee82fb98f, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.541 ms) : 1529, 1554
.   : milestone, 1541,
appsec (2.728 ms) : 2666, 2791
.   : milestone, 2728,
iast (2.354 ms) : 2282, 2427
.   : milestone, 2354,
iast_GLOBAL (2.438 ms) : 2362, 2514
.   : milestone, 2438,
profiling (2.222 ms) : 2159, 2285
.   : milestone, 2222,
tracing (2.178 ms) : 2119, 2237
.   : milestone, 2178,
section candidate
no_agent (1.538 ms) : 1525, 1551
.   : milestone, 1538,
appsec (2.728 ms) : 2665, 2790
.   : milestone, 2728,
iast (2.366 ms) : 2294, 2438
.   : milestone, 2366,
iast_GLOBAL (2.43 ms) : 2355, 2506
.   : milestone, 2430,
profiling (2.237 ms) : 2173, 2301
.   : milestone, 2237,
tracing (2.189 ms) : 2129, 2249
.   : milestone, 2189,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.541 ms [1.529 ms, 1.554 ms] -
appsec 2.728 ms [2.666 ms, 2.791 ms] 1.187 ms (77.0%)
iast 2.354 ms [2.282 ms, 2.427 ms] 813.199 µs (52.8%)
iast_GLOBAL 2.438 ms [2.362 ms, 2.514 ms] 896.867 µs (58.2%)
profiling 2.222 ms [2.159 ms, 2.285 ms] 680.796 µs (44.2%)
tracing 2.178 ms [2.119 ms, 2.237 ms] 636.618 µs (41.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.538 ms [1.525 ms, 1.551 ms] -
appsec 2.728 ms [2.665 ms, 2.79 ms] 1.19 ms (77.4%)
iast 2.366 ms [2.294 ms, 2.438 ms] 827.946 µs (53.8%)
iast_GLOBAL 2.43 ms [2.355 ms, 2.506 ms] 892.219 µs (58.0%)
profiling 2.237 ms [2.173 ms, 2.301 ms] 699.029 µs (45.5%)
tracing 2.189 ms [2.129 ms, 2.249 ms] 650.957 µs (42.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~eee82fb98f, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (20.58 s) : 20580000, 20580000
.   : milestone, 20580000,
appsec (21.465 s) : 21465000, 21465000
.   : milestone, 21465000,
iast (24.783 s) : 24783000, 24783000
.   : milestone, 24783000,
iast_GLOBAL (24.477 s) : 24477000, 24477000
.   : milestone, 24477000,
profiling (21.382 s) : 21382000, 21382000
.   : milestone, 21382000,
tracing (21.197 s) : 21197000, 21197000
.   : milestone, 21197000,
section candidate
no_agent (21.03 s) : 21030000, 21030000
.   : milestone, 21030000,
appsec (21.136 s) : 21136000, 21136000
.   : milestone, 21136000,
iast (24.233 s) : 24233000, 24233000
.   : milestone, 24233000,
iast_GLOBAL (25.176 s) : 25176000, 25176000
.   : milestone, 25176000,
profiling (20.726 s) : 20726000, 20726000
.   : milestone, 20726000,
tracing (21.244 s) : 21244000, 21244000
.   : milestone, 21244000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.58 s [20.58 s, 20.58 s] -
appsec 21.465 s [21.465 s, 21.465 s] 885.0 ms (4.3%)
iast 24.783 s [24.783 s, 24.783 s] 4.203 s (20.4%)
iast_GLOBAL 24.477 s [24.477 s, 24.477 s] 3.897 s (18.9%)
profiling 21.382 s [21.382 s, 21.382 s] 802.0 ms (3.9%)
tracing 21.197 s [21.197 s, 21.197 s] 617.0 ms (3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 21.03 s [21.03 s, 21.03 s] -
appsec 21.136 s [21.136 s, 21.136 s] 106.0 ms (0.5%)
iast 24.233 s [24.233 s, 24.233 s] 3.203 s (15.2%)
iast_GLOBAL 25.176 s [25.176 s, 25.176 s] 4.146 s (19.7%)
profiling 20.726 s [20.726 s, 20.726 s] -304.0 ms (-1.4%)
tracing 21.244 s [21.244 s, 21.244 s] 214.0 ms (1.0%)

@jpbempel
Add protobuf collections as safe ones
eee82fb 
protobuf collections used are specific ones implementing JDK
interfaces. They are in-memory collection so it is safe to handle them
like the JDK ones.
@jpbempel jpbempel force-pushed the jpbempel/add-protobuf-collection branch from 739ace0 to eee82fb Compare August 23, 2024 13:17
@jpbempel jpbempel marked this pull request as ready for review August 23, 2024 13:18
@jpbempel jpbempel requested a review from a team as a code owner August 23, 2024 13:18
@jpbempel jpbempel requested review from evanchooly and removed request for a team August 23, 2024 13:18
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: enhancement labels Aug 23, 2024
OmerRaviv
OmerRaviv approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@OmerRaviv OmerRaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpbempel jpbempel merged commit d5b629d into master Aug 26, 2024
86 checks passed
@jpbempel jpbempel deleted the jpbempel/add-protobuf-collection branch August 26, 2024 07:06
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmerRaviv OmerRaviv OmerRaviv approved these changes

@evanchooly evanchooly Awaiting requested review from evanchooly evanchooly is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement
Projects
None yet
Milestone
1.39.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @OmerRaviv