Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MAX_SIZE_EXCEEDED value in truncated IAST evidence #6779

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update MAX_SIZE_EXCEEDED value in truncated IAST evidence #6779

merged 1 commit into from
Mar 12, 2024
+5 −5

Conversation

jandro996
Copy link
Member

What Does This Do

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@jandro996 jandro996 added tag: no release notes Changes to exclude from release notes comp: asm iast Application Security Management (IAST) labels Mar 6, 2024
@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/update-generic-evidence
git_commit_date 1709707671 1709721924
git_commit_sha 02d3cb7 53e4d96
release_version 1.32.0-SNAPSHOT~02d3cb7aac 1.32.0-SNAPSHOT~53e4d96820
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709725058 1709725058
ci_job_id 452175372 452175372
ci_pipeline_id 29596965 29596965
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~53e4d96820, baseline=1.32.0-SNAPSHOT~02d3cb7aac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089349
Total [baseline] (8.613 s) : 0, 8613246
Agent [candidate] (1.085 s) : 0, 1084696
Total [candidate] (8.58 s) : 0, 8579822
section iast
Agent [baseline] (1.204 s) : 0, 1204281
Total [baseline] (9.032 s) : 0, 9031726
Agent [candidate] (1.208 s) : 0, 1207807
Total [candidate] (9.07 s) : 0, 9070298
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1206422
Total [baseline] (9.008 s) : 0, 9007512
Agent [candidate] (1.214 s) : 0, 1214012
Total [candidate] (9.069 s) : 0, 9068621
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1199923
Total [baseline] (9.032 s) : 0, 9031637
Agent [candidate] (1.211 s) : 0, 1211485
Total [candidate] (9.073 s) : 0, 9072578
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.204 s 114.931 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 117.073 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.2 s 110.573 ms (10.2%)
Total tracing 8.613 s -
Total iast 9.032 s 418.48 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.008 s 394.266 ms (4.6%)
Total iast_TELEMETRY_OFF 9.032 s 418.391 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.208 s 123.111 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.214 s 129.316 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.211 s 126.789 ms (11.7%)
Total tracing 8.58 s -
Total iast 9.07 s 490.477 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.069 s 488.799 ms (5.7%)
Total iast_TELEMETRY_OFF 9.073 s 492.756 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~53e4d96820, baseline=1.32.0-SNAPSHOT~02d3cb7aac

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (702.683 ms) : 0, 702683
BytebuddyAgent [candidate] (699.08 ms) : 0, 699080
GlobalTracer [baseline] (292.747 ms) : 0, 292747
GlobalTracer [candidate] (292.1 ms) : 0, 292100
AppSec [baseline] (50.857 ms) : 0, 50857
AppSec [candidate] (50.712 ms) : 0, 50712
Remote Config [baseline] (746.84 µs) : 0, 747
Remote Config [candidate] (745.518 µs) : 0, 746
Telemetry [baseline] (7.758 ms) : 0, 7758
Telemetry [candidate] (7.681 ms) : 0, 7681
section iast
BytebuddyAgent [baseline] (798.896 ms) : 0, 798896
BytebuddyAgent [candidate] (801.507 ms) : 0, 801507
GlobalTracer [baseline] (287.901 ms) : 0, 287901
GlobalTracer [candidate] (288.867 ms) : 0, 288867
AppSec [baseline] (53.767 ms) : 0, 53767
AppSec [candidate] (52.638 ms) : 0, 52638
IAST [baseline] (22.214 ms) : 0, 22214
IAST [candidate] (23.095 ms) : 0, 23095
Remote Config [baseline] (581.91 µs) : 0, 582
Remote Config [candidate] (590.403 µs) : 0, 590
Telemetry [baseline] (6.666 ms) : 0, 6666
Telemetry [candidate] (6.646 ms) : 0, 6646
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.241 ms) : 0, 800241
BytebuddyAgent [candidate] (803.202 ms) : 0, 803202
GlobalTracer [baseline] (288.39 ms) : 0, 288390
GlobalTracer [candidate] (292.129 ms) : 0, 292129
AppSec [baseline] (52.238 ms) : 0, 52238
AppSec [candidate] (51.612 ms) : 0, 51612
IAST [baseline] (22.313 ms) : 0, 22313
IAST [candidate] (24.57 ms) : 0, 24570
Remote Config [baseline] (582.366 µs) : 0, 582
Remote Config [candidate] (586.089 µs) : 0, 586
Telemetry [baseline] (8.201 ms) : 0, 8201
Telemetry [candidate] (7.48 ms) : 0, 7480
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.288 ms) : 0, 793288
BytebuddyAgent [candidate] (800.712 ms) : 0, 800712
GlobalTracer [baseline] (289.463 ms) : 0, 289463
GlobalTracer [candidate] (292.409 ms) : 0, 292409
AppSec [baseline] (53.589 ms) : 0, 53589
AppSec [candidate] (54.187 ms) : 0, 54187
IAST [baseline] (21.45 ms) : 0, 21450
IAST [candidate] (22.487 ms) : 0, 22487
Remote Config [baseline] (574.116 µs) : 0, 574
Remote Config [candidate] (581.313 µs) : 0, 581
Telemetry [baseline] (7.319 ms) : 0, 7319
Telemetry [candidate] (6.604 ms) : 0, 6604
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~53e4d96820, baseline=1.32.0-SNAPSHOT~02d3cb7aac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081791
Total [baseline] (9.192 s) : 0, 9192389
Agent [candidate] (1.088 s) : 0, 1087606
Total [candidate] (9.205 s) : 0, 9205348
section appsec
Agent [baseline] (1.212 s) : 0, 1212486
Total [baseline] (9.327 s) : 0, 9327344
Agent [candidate] (1.207 s) : 0, 1206693
Total [candidate] (9.318 s) : 0, 9318163
section iast
Agent [baseline] (1.219 s) : 0, 1219004
Total [baseline] (9.411 s) : 0, 9411186
Agent [candidate] (1.222 s) : 0, 1222457
Total [candidate] (9.361 s) : 0, 9361003
section profiling
Agent [baseline] (1.286 s) : 0, 1286218
Total [baseline] (9.455 s) : 0, 9454705
Agent [candidate] (1.282 s) : 0, 1281562
Total [candidate] (9.408 s) : 0, 9407832
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.212 s 130.695 ms (12.1%)
Agent iast 1.219 s 137.213 ms (12.7%)
Agent profiling 1.286 s 204.427 ms (18.9%)
Total tracing 9.192 s -
Total appsec 9.327 s 134.954 ms (1.5%)
Total iast 9.411 s 218.797 ms (2.4%)
Total profiling 9.455 s 262.316 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent appsec 1.207 s 119.086 ms (10.9%)
Agent iast 1.222 s 134.85 ms (12.4%)
Agent profiling 1.282 s 193.955 ms (17.8%)
Total tracing 9.205 s -
Total appsec 9.318 s 112.814 ms (1.2%)
Total iast 9.361 s 155.655 ms (1.7%)
Total profiling 9.408 s 202.484 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~53e4d96820, baseline=1.32.0-SNAPSHOT~02d3cb7aac

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.719 ms) : 0, 696719
BytebuddyAgent [candidate] (699.909 ms) : 0, 699909
GlobalTracer [baseline] (291.609 ms) : 0, 291609
GlobalTracer [candidate] (293.749 ms) : 0, 293749
AppSec [baseline] (50.726 ms) : 0, 50726
AppSec [candidate] (50.991 ms) : 0, 50991
Remote Config [baseline] (726.96 µs) : 0, 727
Remote Config [candidate] (734.837 µs) : 0, 735
Telemetry [baseline] (7.664 ms) : 0, 7664
Telemetry [candidate] (7.778 ms) : 0, 7778
section appsec
BytebuddyAgent [baseline] (702.846 ms) : 0, 702846
BytebuddyAgent [candidate] (698.094 ms) : 0, 698094
GlobalTracer [baseline] (293.44 ms) : 0, 293440
GlobalTracer [candidate] (293.052 ms) : 0, 293052
AppSec [baseline] (156.196 ms) : 0, 156196
AppSec [candidate] (155.87 ms) : 0, 155870
IAST [baseline] (17.9 ms) : 0, 17900
IAST [candidate] (17.817 ms) : 0, 17817
Remote Config [baseline] (606.128 µs) : 0, 606
Remote Config [candidate] (605.913 µs) : 0, 606
Telemetry [baseline] (6.895 ms) : 0, 6895
Telemetry [candidate] (6.878 ms) : 0, 6878
section iast
BytebuddyAgent [baseline] (808.522 ms) : 0, 808522
BytebuddyAgent [candidate] (809.932 ms) : 0, 809932
GlobalTracer [baseline] (292.163 ms) : 0, 292163
GlobalTracer [candidate] (292.707 ms) : 0, 292707
AppSec [baseline] (50.976 ms) : 0, 50976
AppSec [candidate] (51.801 ms) : 0, 51801
IAST [baseline] (24.593 ms) : 0, 24593
IAST [candidate] (25.126 ms) : 0, 25126
Remote Config [baseline] (595.475 µs) : 0, 595
Remote Config [candidate] (599.084 µs) : 0, 599
Telemetry [baseline] (7.455 ms) : 0, 7455
Telemetry [candidate] (7.578 ms) : 0, 7578
section profiling
BytebuddyAgent [baseline] (694.741 ms) : 0, 694741
BytebuddyAgent [candidate] (693.599 ms) : 0, 693599
GlobalTracer [baseline] (377.853 ms) : 0, 377853
GlobalTracer [candidate] (376.654 ms) : 0, 376654
AppSec [baseline] (53.226 ms) : 0, 53226
AppSec [candidate] (52.587 ms) : 0, 52587
Remote Config [baseline] (803.49 µs) : 0, 803
Remote Config [candidate] (771.325 µs) : 0, 771
Telemetry [baseline] (7.49 ms) : 0, 7490
Telemetry [candidate] (7.504 ms) : 0, 7504
ProfilingAgent [baseline] (95.665 ms) : 0, 95665
ProfilingAgent [candidate] (94.07 ms) : 0, 94070
Profiling [baseline] (95.688 ms) : 0, 95688
Profiling [candidate] (94.094 ms) : 0, 94094
Loading

Load

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~53e4d96820, baseline=1.32.0-SNAPSHOT~02d3cb7aac
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.442 µs) : 345, 384
.   : milestone, 364,
iast (474.186 µs) : 453, 495
.   : milestone, 474,
iast_FULL (541.278 µs) : 521, 562
.   : milestone, 541,
iast_GLOBAL (490.46 µs) : 470, 511
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (473.526 µs) : 453, 494
.   : milestone, 474,
iast_INACTIVE (446.476 µs) : 426, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (472.707 µs) : 452, 493
.   : milestone, 473,
tracing (446.121 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (366.606 µs) : 345, 388
.   : milestone, 367,
iast (472.108 µs) : 451, 493
.   : milestone, 472,
iast_FULL (535.773 µs) : 515, 556
.   : milestone, 536,
iast_GLOBAL (492.295 µs) : 472, 512
.   : milestone, 492,
iast_HARDCODED_SECRET_DISABLED (465.915 µs) : 446, 486
.   : milestone, 466,
iast_INACTIVE (448.108 µs) : 428, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (470.905 µs) : 449, 493
.   : milestone, 471,
tracing (447.775 µs) : 427, 468
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.442 µs [344.578 µs, 384.307 µs] -
iast 474.186 µs [453.481 µs, 494.891 µs] 109.744 µs (30.1%)
iast_FULL 541.278 µs [520.839 µs, 561.717 µs] 176.836 µs (48.5%)
iast_GLOBAL 490.46 µs [469.541 µs, 511.379 µs] 126.017 µs (34.6%)
iast_HARDCODED_SECRET_DISABLED 473.526 µs [453.044 µs, 494.008 µs] 109.084 µs (29.9%)
iast_INACTIVE 446.476 µs [425.835 µs, 467.117 µs] 82.034 µs (22.5%)
iast_TELEMETRY_OFF 472.707 µs [452.105 µs, 493.31 µs] 108.265 µs (29.7%)
tracing 446.121 µs [425.455 µs, 466.786 µs] 81.679 µs (22.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.606 µs [345.131 µs, 388.082 µs] -
iast 472.108 µs [451.358 µs, 492.858 µs] 105.502 µs (28.8%)
iast_FULL 535.773 µs [515.382 µs, 556.164 µs] 169.166 µs (46.1%)
iast_GLOBAL 492.295 µs [472.104 µs, 512.485 µs] 125.688 µs (34.3%)
iast_HARDCODED_SECRET_DISABLED 465.915 µs [445.866 µs, 485.965 µs] 99.309 µs (27.1%)
iast_INACTIVE 448.108 µs [427.651 µs, 468.564 µs] 81.501 µs (22.2%)
iast_TELEMETRY_OFF 470.905 µs [449.176 µs, 492.634 µs] 104.299 µs (28.4%)
tracing 447.775 µs [427.327 µs, 468.222 µs] 81.168 µs (22.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~53e4d96820, baseline=1.32.0-SNAPSHOT~02d3cb7aac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.78 ms) : 1756, 1803
.   : milestone, 1780,
iast (1.521 ms) : 1498, 1544
.   : milestone, 1521,
profiling (1.529 ms) : 1505, 1553
.   : milestone, 1529,
tracing (1.524 ms) : 1501, 1547
.   : milestone, 1524,
section candidate
no_agent (1.361 ms) : 1341, 1380
.   : milestone, 1361,
appsec (1.781 ms) : 1757, 1804
.   : milestone, 1781,
iast (1.519 ms) : 1495, 1543
.   : milestone, 1519,
profiling (1.526 ms) : 1503, 1550
.   : milestone, 1526,
tracing (1.509 ms) : 1486, 1532
.   : milestone, 1509,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.78 ms [1.756 ms, 1.803 ms] 425.756 µs (31.4%)
iast 1.521 ms [1.498 ms, 1.544 ms] 167.154 µs (12.3%)
profiling 1.529 ms [1.505 ms, 1.553 ms] 175.429 µs (13.0%)
tracing 1.524 ms [1.501 ms, 1.547 ms] 170.295 µs (12.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.341 ms, 1.38 ms] -
appsec 1.781 ms [1.757 ms, 1.804 ms] 420.019 µs (30.9%)
iast 1.519 ms [1.495 ms, 1.543 ms] 158.356 µs (11.6%)
profiling 1.526 ms [1.503 ms, 1.55 ms] 165.819 µs (12.2%)
tracing 1.509 ms [1.486 ms, 1.532 ms] 148.28 µs (10.9%)

@smola smola changed the title update MAX_SIZE_EXCEEDED value Update MAX_SIZE_EXCEEDED value in truncated IAST evidence Mar 11, 2024
@jandro996 jandro996 marked this pull request as ready for review March 11, 2024 10:50
@jandro996 jandro996 requested a review from a team as a code owner March 11, 2024 10:50
@jandro996 jandro996 merged commit 0d49c12 into master Mar 12, 2024
81 checks passed
@jandro996 jandro996 deleted the alejandro.gonzalez/update-generic-evidence branch March 12, 2024 07:45
@github-actions github-actions bot added this to the 1.32.0 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@smola smola smola approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jandro996 @smola @manuel-alvarez-alvarez