-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve application module performance and security bounds #6647
Merged
manuel-alvarez-alvarez
merged 1 commit into
master
from
malvarez/iast-improve-app-module
Feb 16, 2024
Merged
Improve application module performance and security bounds #6647
manuel-alvarez-alvarez
merged 1 commit into
master
from
malvarez/iast-improve-app-module
Feb 16, 2024
+253
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-alvarez-alvarez
added
tag: performance
Performance related changes
comp: asm iast
Application Security Management (IAST)
labels
Feb 8, 2024
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-improve-app-module
branch
4 times, most recently
from
February 8, 2024 13:27
7e3143f
to
f8c22d9
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~5453c158c7, baseline=1.31.0-SNAPSHOT~3210501b95
dateFormat X
axisFormat %s
section baseline
no_agent (361.61 µs) : 342, 382
. : milestone, 362,
iast (471.856 µs) : 451, 492
. : milestone, 472,
iast_FULL (532.907 µs) : 512, 554
. : milestone, 533,
iast_GLOBAL (489.737 µs) : 469, 511
. : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (470.547 µs) : 449, 492
. : milestone, 471,
iast_INACTIVE (437.224 µs) : 417, 458
. : milestone, 437,
iast_TELEMETRY_OFF (468.704 µs) : 448, 490
. : milestone, 469,
tracing (444.644 µs) : 423, 466
. : milestone, 445,
section candidate
no_agent (369.645 µs) : 350, 390
. : milestone, 370,
iast (470.597 µs) : 450, 491
. : milestone, 471,
iast_FULL (533.22 µs) : 513, 554
. : milestone, 533,
iast_GLOBAL (485.506 µs) : 465, 506
. : milestone, 486,
iast_HARDCODED_SECRET_DISABLED (472.996 µs) : 452, 494
. : milestone, 473,
iast_INACTIVE (450.478 µs) : 429, 472
. : milestone, 450,
iast_TELEMETRY_OFF (471.728 µs) : 450, 493
. : milestone, 472,
tracing (432.081 µs) : 412, 452
. : milestone, 432,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~5453c158c7, baseline=1.31.0-SNAPSHOT~3210501b95
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1384
. : milestone, 1364,
appsec (1.776 ms) : 1751, 1802
. : milestone, 1776,
iast (1.517 ms) : 1493, 1542
. : milestone, 1517,
profiling (1.523 ms) : 1498, 1547
. : milestone, 1523,
tracing (1.496 ms) : 1470, 1521
. : milestone, 1496,
section candidate
no_agent (1.355 ms) : 1336, 1374
. : milestone, 1355,
appsec (1.767 ms) : 1742, 1793
. : milestone, 1767,
iast (1.524 ms) : 1499, 1548
. : milestone, 1524,
profiling (1.53 ms) : 1504, 1556
. : milestone, 1530,
tracing (1.49 ms) : 1465, 1515
. : milestone, 1490,
|
jandro996
approved these changes
Feb 8, 2024
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-improve-app-module
branch
3 times, most recently
from
February 14, 2024 08:50
a9ee87f
to
5453c15
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-improve-app-module
branch
from
February 16, 2024 08:44
5453c15
to
b058193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Uses the NIO file visitor API to traverse the folders in order to ensure proper performance and depth bounds for the traversal.