[jmxfetch] run() will be non-static for App
#3190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: I can see the tests failing until we actually release the new JMXFetch version. |
devinsba
reviewed
Nov 9, 2021
| @@ -100,6 +100,7 @@ private static void run(final StatsDClientManager statsDClientManager, final Con | |||
| configBuilder.checkPeriod(checkPeriod); | |||
| } | |||
| final AppConfig appConfig = configBuilder.build(); | |||
| private App app = new App(appConfig); | |||
There was a problem hiding this comment.
private is unnecessary here but final would be good
There was a problem hiding this comment.
My bad, I originally had that as a class attribute, then moved it into the run() method. Will mark final.
|
This is the PR on the jmxfetch side: DataDog/jmxfetch#376 |
|
Closing as stale, this change was applied in #3236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small PR to address a small change we expect to implement in the JMXFetch lib, by which the
App.run()method will no longer be static. It is currently a nasty piece of code we have in JMXFetch we would like to get rid of. It should be of minor impact as it still seems very self contained within the tracer use of the lib.