Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix(contrib/hashicorp/{consul,vault}): pin armon/go-metrics to v0.4.1 #3107

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

darccio
Copy link
Member

@darccio darccio commented Jan 20, 2025

What does this PR do?

Pins armon/go-metrics to v0.4.1 using a replace directive.

Motivation

To reduce CI times and noise in smoke tests' logs, we pin github.com/armon/go-metrics to v0.4.1, the last version released before it was migirated to Hashicorp's organization.

Without this, running our smoke tests that rely on go get -u tend to run longer due to Go's toolchain mechanism to try to find the right version that fits the import URL. Versions higher than v0.4.1 use github.com/hashicorp/go-metrics instead.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners January 20, 2025 16:10
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 20, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 20, 2025

Datadog Report

Branch report: dario.castane/langplat-282/pin-armon-gometrics
Commit report: 9c83303
Test service: dd-trace-go

✅ 0 Failed, 4088 Passed, 64 Skipped, 2m 52.19s Total Time

@darccio darccio changed the title fix(contrib/hashicorp/vault): pin armon/go-metrics to v0.4.1 [v2] fix(contrib/hashicorp/vault): pin armon/go-metrics to v0.4.1 Jan 20, 2025
@darccio darccio force-pushed the dario.castane/langplat-282/pin-armon-gometrics branch from a9b49de to ad5f435 Compare January 20, 2025 16:21
@darccio darccio changed the title [v2] fix(contrib/hashicorp/vault): pin armon/go-metrics to v0.4.1 [v2] fix(contrib/hashicorp/{consul,vault}): pin armon/go-metrics to v0.4.1 Jan 20, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Benchmarks

Benchmark execution time: 2025-01-20 17:00:38

Comparing candidate commit ad5f435 in PR branch dario.castane/langplat-282/pin-armon-gometrics with baseline commit 6dd1f10 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 1 unstable metrics.

@darccio darccio merged commit 4ce65f3 into v2-dev Jan 21, 2025
172 of 175 checks passed
@darccio darccio deleted the dario.castane/langplat-282/pin-armon-gometrics branch January 21, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant