[v2] fix(contrib/hashicorp/{consul,vault}): pin armon/go-metrics to v0.4.1 #3107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pins
armon/go-metrics
tov0.4.1
using areplace
directive.Motivation
To reduce CI times and noise in smoke tests' logs, we pin
github.com/armon/go-metrics
tov0.4.1
, the last version released before it was migirated to Hashicorp's organization.Without this, running our smoke tests that rely on
go get -u
tend to run longer due to Go's toolchain mechanism to try to find the right version that fits the import URL. Versions higher thanv0.4.1
usegithub.aaakk.us.kg/hashicorp/go-metrics
instead.Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!