Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix(contrib/Shopify/sarama): pin Shopify/sarama to v1.38.1 #3105

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

darccio
Copy link
Member

@darccio darccio commented Jan 20, 2025

What does this PR do?

Pins Shopify/sarama to v1.38.1 using a replace directive.

Motivation

To reduce CI times and noise in smoke tests' logs, we pin github.com/Shopify/sarama to v1.38.1, the last version released under Shopify’s organization.

Without this, running our smoke tests that rely on go get -u tend to run longer due to Go's toolchain mechanism to try to find the right version that fits the import URL. Versions higher than v1.38.1 use github.com/IBM/samara instead.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners January 20, 2025 15:19
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 20, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 20, 2025

Datadog Report

Branch report: dario.castane/langplat-281/pin-shopify-sarama
Commit report: 2afe1a8
Test service: dd-trace-go

✅ 0 Failed, 4088 Passed, 64 Skipped, 2m 53.68s Total Time

@darccio darccio merged commit 6dd1f10 into v2-dev Jan 20, 2025
173 of 177 checks passed
@darccio darccio deleted the dario.castane/langplat-281/pin-shopify-sarama branch January 20, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant