Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) internal/civisibility: add support for testify Suites (v2) #3097

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Jan 16, 2025

What does this PR do?

This PR adds support for testify Suite kind of tests.

Ticket: SDTEST-1435

V1 PR: #3094

Note: This improvements will require a new orchestrion integration to intercept suite.Run calls

Example:

....
type USMSuite struct {
	suite.Suite
}

func TestUSMSuite(t *testing.T) {
	suite.Run(t, new(USMSuite))
}

func (s *USMSuite) TestEnableHTTPMonitoring() {
}

func (s *USMSuite) TestDisableUSM() {
}
....

Motivation

Currently the support lacks the correct identification of the Suite name, Module name and Test source affecting features like Codeowners and Impact Analysis

From:

image image

To:

image image

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo marked this pull request as ready for review January 16, 2025 23:37
@tonyredondo tonyredondo requested review from a team as code owners January 16, 2025 23:37
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 16, 2025

Datadog Report

Branch report: tony/civisibility-testify-support-v2
Commit report: dc9bf63
Test service: dd-trace-go

✅ 0 Failed, 4088 Passed, 64 Skipped, 2m 49.74s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 17, 2025

Benchmarks

Benchmark execution time: 2025-01-17 00:13:35

Comparing candidate commit 44b4013 in PR branch tony/civisibility-testify-support-v2 with baseline commit bb4979d in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 1 unstable metrics.

@tonyredondo tonyredondo merged commit 5d42e4d into v2-dev Jan 17, 2025
150 of 153 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-testify-support-v2 branch January 17, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants