Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix(ddtrace/tracer): avoid tests to fail with error "non-constant format string" from upcoming Go 1.24 release (#3048) #3082

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

darccio
Copy link
Member

@darccio darccio commented Jan 13, 2025

What does this PR do?

Port of #3048 to v2-dev.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners January 13, 2025 15:56
@darccio darccio requested a review from liashenko January 13, 2025 15:56
@darccio darccio changed the title [v2] fix(ddtrace/tracer): avoid tests to fail with error "non-constant for… fix(ddtrace/tracer): avoid tests to fail with error "non-constant format string" from upcoming Go 1.24 release (#3048) Jan 13, 2025
@darccio darccio changed the title fix(ddtrace/tracer): avoid tests to fail with error "non-constant format string" from upcoming Go 1.24 release (#3048) [v2] fix(ddtrace/tracer): avoid tests to fail with error "non-constant format string" from upcoming Go 1.24 release (#3048) Jan 13, 2025
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: dario.castane/go-124-port
Commit report: 9b59963
Test service: dd-trace-go

✅ 0 Failed, 2843 Passed, 24 Skipped, 2m 50.26s Total Time

@hannahkm
Copy link
Contributor

Approved this preemptively 🙃 , but looks like there are some issues with using the internal log package.

@darccio darccio merged commit 0880b0d into v2-dev Jan 13, 2025
166 of 174 checks passed
@darccio darccio deleted the dario.castane/go-124-port branch January 13, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants