Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: update integration_go.mod #3064

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Jan 3, 2025

What does this PR do?

Remove non-integration packages from the integration_go.mod that was created in #2936

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@quinna-h quinna-h marked this pull request as ready for review January 3, 2025 15:34
@quinna-h quinna-h requested review from a team as code owners January 3, 2025 15:34
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 3, 2025

Datadog Report

Branch report: quinna.halim/fix-integration-go-mod
Commit report: 50f251d
Test service: dd-trace-go

✅ 0 Failed, 5121 Passed, 70 Skipped, 2m 26.24s Total Time

@quinna-h quinna-h mentioned this pull request Jan 3, 2025
7 tasks
@pr-commenter
Copy link

pr-commenter bot commented Jan 3, 2025

Benchmarks

Benchmark execution time: 2025-01-03 16:21:53

Comparing candidate commit 3932d6b in PR branch quinna.halim/fix-integration-go-mod with baseline commit 4f57a47 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant