Remove unnecessary analytics optionx

DataDog · Mar 29, 2022 · 4da037f · 4da037f
1 parent e0d55a8
commit 4da037f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/contrib/google.golang.org/grpc.v12/option.go b/contrib/google.golang.org/grpc.v12/option.go
@@ -6,8 +6,6 @@
 package grpc
 
 import (
-	"math"
-
 	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace"
 	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
 	"gopkg.in/DataDog/dd-trace-go.v1/internal"
@@ -27,8 +25,6 @@ func defaults(cfg *interceptorConfig) {
 	// cfg.spanOpts = append(cfg.spanOpts, tracer.AnalyticsRate(globalconfig.AnalyticsRate()))
 	if internal.BoolEnv("DD_TRACE_GRPC_ANALYTICS_ENABLED", false) {
 		cfg.spanOpts = append(cfg.spanOpts, tracer.AnalyticsRate(1.0))
-	} else {
-		cfg.spanOpts = append(cfg.spanOpts, tracer.AnalyticsRate(math.NaN()))
 	}
 }
 
@@ -44,8 +40,6 @@ func WithAnalytics(on bool) InterceptorOption {
 	return func(cfg *interceptorConfig) {
 		if on {
 			WithSpanOptions(tracer.AnalyticsRate(1.0))(cfg)
-		} else {
-			WithSpanOptions(tracer.AnalyticsRate(math.NaN()))(cfg)
 		}
 	}
 }
@@ -56,8 +50,6 @@ func WithAnalyticsRate(rate float64) InterceptorOption {
 	return func(cfg *interceptorConfig) {
 		if rate >= 0.0 && rate <= 1.0 {
 			WithSpanOptions(tracer.AnalyticsRate(rate))(cfg)
-		} else {
-			WithSpanOptions(tracer.AnalyticsRate(math.NaN()))(cfg)
 		}
 	}
 }

diff --git a/contrib/google.golang.org/grpc/option.go b/contrib/google.golang.org/grpc/option.go
@@ -6,8 +6,6 @@
 package grpc
 
 import (
-	"math"
-
 	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace"
 	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
 	"gopkg.in/DataDog/dd-trace-go.v1/internal"
@@ -63,8 +61,6 @@ func defaults(cfg *config) {
 	// cfg.spanOpts = append(cfg.spanOpts, tracer.AnalyticsRate(globalconfig.AnalyticsRate()))
 	if internal.BoolEnv("DD_TRACE_GRPC_ANALYTICS_ENABLED", false) {
 		cfg.spanOpts = append(cfg.spanOpts, tracer.AnalyticsRate(1.0))
-	} else {
-		cfg.spanOpts = append(cfg.spanOpts, tracer.AnalyticsRate(math.NaN()))
 	}
 	cfg.ignoredMetadata = map[string]struct{}{
 		"x-datadog-trace-id":          {},
@@ -120,8 +116,6 @@ func WithAnalytics(on bool) Option {
 	return func(cfg *config) {
 		if on {
 			WithSpanOptions(tracer.AnalyticsRate(1.0))(cfg)
-		} else {
-			WithSpanOptions(tracer.AnalyticsRate(math.NaN()))(cfg)
 		}
 	}
 }
@@ -132,8 +126,6 @@ func WithAnalyticsRate(rate float64) Option {
 	return func(cfg *config) {
 		if rate >= 0.0 && rate <= 1.0 {
 			WithSpanOptions(tracer.AnalyticsRate(rate))(cfg)
-		} else {
-			WithSpanOptions(tracer.AnalyticsRate(math.NaN()))(cfg)
 		}
 	}
 }