[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

zacharycmontoya · 2025-01-13T22:15:03Z

Summary of changes

At instrumentation startup, if OpenTelemetry.Api v1.0.0+ is present, replace the OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator implementation (defaults to a NoopTextMapPropagator) with the following:

new CompositeTextMapPropagator(new TextMapPropagator[]
{
    new TraceContextPropagator(),
    new BaggagePropagator(),
});

Reason for change

There is a current feature gap when the user tries to use OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator.

If the user is using the OpenTelemetry SDK, the static property gets overwritten with a functioning implementation when the OpenTelemetry.Sdk type is loaded.

However, if the user removes the OpenTelemetry SDK from their application and relies on the Datadog .NET Tracer for implementing the OpenTelemetry Tracing API, the default propagator no longer gets a functional implementation. This change addresses that gap.

Implementation details

At instrumentation initialization, if the OpenTelemetry support is enabled (DD_TRACE_OTEL_ENABLED=true), use reflection to call into the static OpenTelemetry.Context.Propagation.Propagators class and overwrite the DefaultTextMapPropagator property in the same way as the OpenTelemetry SDK would, with a propagator that propagates W3C Tracecontext and W3C Baggage.

Test coverage

This PR adds to the snapshot testing of the Samples.NetActivitySdk application, asserting that the context propagation has a functioning implementation.

Other details

github-actions · 2025-01-13T22:15:50Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

+      custom.opentelemetry.defaulttextmappropagator.baggage: key=value,

tracer/src/Datadog.Trace/Activity/ActivityListener.cs

tracer/src/Datadog.Trace/ClrProfiler/Instrumentation.cs

datadog-ddstaging · 2025-01-13T23:02:15Z

Datadog Report

Branch report: zach.montoya/otel-dropin-default-propagator
Commit report: b60809f
Test service: dd-trace-dotnet

✅ 0 Failed, 239794 Passed, 1986 Skipped, 19h 4m 28.99s Total Time

andrewlock · 2025-01-13T23:07:55Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (69ms)  : 65, 73
     .   : milestone, 69,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (981ms)  : 959, 1003
     .   : milestone, 981,
    master - mean (985ms)  : 956, 1015
     .   : milestone, 985,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (107ms)  : 104, 110
     .   : milestone, 107,
    master - mean (115ms)  : 100, 129
     .   : milestone, 115,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (679ms)  : 666, 693
     .   : milestone, 679,
    master - mean (682ms)  : 669, 696
     .   : milestone, 682,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (91ms)  : 89, 92
     .   : milestone, 91,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (629ms)  : 610, 648
     .   : milestone, 629,
    master - mean (635ms)  : 620, 650
     .   : milestone, 635,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (190ms)  : 185, 195
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (1,091ms)  : 1057, 1125
     .   : milestone, 1091,
    master - mean (1,090ms)  : 1061, 1119
     .   : milestone, 1090,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (275ms)  : 270, 280
     .   : milestone, 275,
    master - mean (274ms)  : 270, 279
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (864ms)  : 833, 896
     .   : milestone, 864,
    master - mean (867ms)  : 839, 894
     .   : milestone, 867,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (264ms)  : 260, 267
     .   : milestone, 264,
    master - mean (264ms)  : 260, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (837ms)  : 810, 864
     .   : milestone, 837,
    master - mean (850ms)  : 818, 882
     .   : milestone, 850,

bouwkast

I think ForceDefaultIdFormat should be removed as it seems to change the IDs of Hierarchical Activities to be W3C

tracer/src/Datadog.Trace/Activity/ActivityListener.cs

bouwkast

LGTM!

andrewlock · 2025-01-15T06:14:02Z

Benchmarks Report for tracer 🐌

Benchmarks for #6544 compared to master:

3 benchmarks are slower, with geometric mean 1.140
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.32μs	44.7ns	253ns	0.0165	0.00824	0	5.62 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	50.7ns	287ns	0.0199	0.00993	0	5.8 KB
master	`StartStopWithChild`	net472	16.3μs	35.3ns	137ns	1.06	0.307	0.102	6.21 KB
#6544	`StartStopWithChild`	net6.0	7.85μs	45.3ns	365ns	0.015	0.00748	0	5.61 KB
#6544	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.8ns	305ns	0.0241	0.00966	0	5.8 KB
#6544	`StartStopWithChild`	net472	16.2μs	40.3ns	156ns	1.04	0.308	0.0892	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	470μs	385ns	1.49μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	269ns	1.04μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	859μs	722ns	2.79μs	0.428	3.3 KB
#6544	`WriteAndFlushEnrichedTraces`	net6.0	477μs	423ns	1.64μs	0	2.7 KB
#6544	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	651μs	602ns	2.33μs	0	2.7 KB
#6544	`WriteAndFlushEnrichedTraces`	net472	857μs	809ns	3.13μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	157μs	923ns	8.71μs	0.147	14.47 KB
master	`SendRequest`	netcoreapp3.1	175μs	1.12μs	11.1μs	0.191	17.27 KB
master	`SendRequest`	net472	0.00137ns	0.000761ns	0.00285ns	0	0 b
#6544	`SendRequest`	net6.0	152μs	880ns	7.15μs	0.141	14.47 KB
#6544	`SendRequest`	netcoreapp3.1	166μs	955ns	7.81μs	0.156	17.27 KB
#6544	`SendRequest`	net472	0.00172ns	0.000711ns	0.00266ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6544

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.6 KB	41.81 KB	209 B	0.50%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	571μs	2.67μs	10μs	0.584	0	0	41.6 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	695μs	3.86μs	23.5μs	0.353	0	0	41.76 KB
master	`WriteAndFlushEnrichedTraces`	net472	825μs	2.97μs	10.7μs	8.5	2.55	0.425	53.27 KB
#6544	`WriteAndFlushEnrichedTraces`	net6.0	606μs	3.22μs	16.1μs	0.553	0	0	41.81 KB
#6544	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	683μs	3.88μs	27.7μs	0.317	0	0	41.85 KB
#6544	`WriteAndFlushEnrichedTraces`	net472	845μs	3.54μs	13.7μs	8.28	2.48	0.414	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.32μs	1ns	3.87ns	0.0147	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	1.85ns	6.92ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.06μs	3.08ns	11.9ns	0.156	0.00102	987 B
#6544	`ExecuteNonQuery`	net6.0	1.21μs	1.61ns	6.04ns	0.0141	0	1.02 KB
#6544	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.45ns	5.43ns	0.0133	0	1.02 KB
#6544	`ExecuteNonQuery`	net472	2.04μs	2.76ns	10.7ns	0.156	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.26μs	1.05ns	3.94ns	0.0133	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.57μs	1.18ns	4.58ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.64μs	1.83ns	7.08ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.28μs	0.793ns	2.97ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.59μs	0.636ns	2.38ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.65μs	2.23ns	8.62ns	0.166	1.05 KB
#6544	`CallElasticsearch`	net6.0	1.26μs	0.38ns	1.47ns	0.0134	976 B
#6544	`CallElasticsearch`	netcoreapp3.1	1.55μs	1.43ns	5.55ns	0.0132	976 B
#6544	`CallElasticsearch`	net472	2.57μs	1.86ns	6.97ns	0.157	995 B
#6544	`CallElasticsearchAsync`	net6.0	1.38μs	0.768ns	2.97ns	0.013	952 B
#6544	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	1.77ns	6.87ns	0.0137	1.02 KB
#6544	`CallElasticsearchAsync`	net472	2.74μs	1.57ns	6.1ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6544

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.174	1,229.89	1,443.54

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.23μs	0.583ns	2.18ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.57μs	2.12ns	7.92ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.83μs	0.494ns	1.91ns	0.145	915 B
#6544	`ExecuteAsync`	net6.0	1.44μs	0.778ns	2.91ns	0.013	952 B
#6544	`ExecuteAsync`	netcoreapp3.1	1.6μs	0.661ns	2.38ns	0.0127	952 B
#6544	`ExecuteAsync`	net472	1.78μs	0.436ns	1.57ns	0.144	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.4μs	2.07ns	7.76ns	0.0325	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.21μs	1.27ns	4.76ns	0.039	2.85 KB
master	`SendAsync`	net472	7.35μs	2.08ns	8.06ns	0.493	3.12 KB
#6544	`SendAsync`	net6.0	4.32μs	1.88ns	7.29ns	0.0326	2.31 KB
#6544	`SendAsync`	netcoreapp3.1	5.19μs	1.69ns	6.1ns	0.0391	2.85 KB
#6544	`SendAsync`	net472	7.29μs	1.94ns	7.5ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.5μs	0.724ns	2.8ns	0.0233	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.24μs	5.12ns	19.8ns	0.022	1.64 KB
master	`EnrichedLog`	net472	2.63μs	1.34ns	5.19ns	0.25	1.57 KB
#6544	`EnrichedLog`	net6.0	1.44μs	0.726ns	2.81ns	0.0231	1.64 KB
#6544	`EnrichedLog`	netcoreapp3.1	2.28μs	1.49ns	5.78ns	0.0212	1.64 KB
#6544	`EnrichedLog`	net472	2.43μs	1.4ns	5.43ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	117μs	178ns	689ns	0.0579	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	123μs	186ns	722ns	0	0	4.28 KB
master	`EnrichedLog`	net472	150μs	117ns	452ns	0.684	0.228	4.46 KB
#6544	`EnrichedLog`	net6.0	115μs	152ns	590ns	0.0572	0	4.28 KB
#6544	`EnrichedLog`	netcoreapp3.1	119μs	155ns	579ns	0	0	4.28 KB
#6544	`EnrichedLog`	net472	150μs	134ns	521ns	0.676	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.98μs	0.65ns	2.52ns	0.0299	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.33μs	2.1ns	8.15ns	0.0281	2.2 KB
master	`EnrichedLog`	net472	4.88μs	1.59ns	6.17ns	0.319	2.02 KB
#6544	`EnrichedLog`	net6.0	2.95μs	1.45ns	5.6ns	0.031	2.2 KB
#6544	`EnrichedLog`	netcoreapp3.1	4.22μs	0.896ns	3.35ns	0.0295	2.2 KB
#6544	`EnrichedLog`	net472	5.1μs	1.53ns	5.92ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.3μs	0.604ns	2.34ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.78μs	1.7ns	6.38ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.11μs	1.65ns	6.4ns	0.183	1.16 KB
#6544	`SendReceive`	net6.0	1.31μs	0.296ns	1.02ns	0.0159	1.14 KB
#6544	`SendReceive`	netcoreapp3.1	1.77μs	1.83ns	7.1ns	0.0152	1.14 KB
#6544	`SendReceive`	net472	2.15μs	1.66ns	6.42ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	1.48ns	5.72ns	0.0225	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.91μs	2.99ns	11.6ns	0.0214	1.65 KB
master	`EnrichedLog`	net472	4.35μs	2.51ns	9.73ns	0.322	2.04 KB
#6544	`EnrichedLog`	net6.0	2.73μs	0.926ns	3.46ns	0.0232	1.6 KB
#6544	`EnrichedLog`	netcoreapp3.1	3.92μs	1.17ns	4.55ns	0.0216	1.65 KB
#6544	`EnrichedLog`	net472	4.39μs	3.5ns	13.6ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	398ns	0.155ns	0.602ns	0.00819	576 B
master	`StartFinishSpan`	netcoreapp3.1	615ns	0.451ns	1.75ns	0.00767	576 B
master	`StartFinishSpan`	net472	700ns	0.374ns	1.4ns	0.0917	578 B
master	`StartFinishScope`	net6.0	542ns	0.325ns	1.22ns	0.00975	696 B
master	`StartFinishScope`	netcoreapp3.1	718ns	0.412ns	1.49ns	0.00946	696 B
master	`StartFinishScope`	net472	884ns	0.661ns	2.56ns	0.104	658 B
#6544	`StartFinishSpan`	net6.0	411ns	0.208ns	0.778ns	0.00804	576 B
#6544	`StartFinishSpan`	netcoreapp3.1	621ns	0.554ns	2.15ns	0.00774	576 B
#6544	`StartFinishSpan`	net472	679ns	0.499ns	1.93ns	0.0918	578 B
#6544	`StartFinishScope`	net6.0	552ns	0.548ns	2.05ns	0.00972	696 B
#6544	`StartFinishScope`	netcoreapp3.1	719ns	0.758ns	2.94ns	0.00941	696 B
#6544	`StartFinishScope`	net472	835ns	0.585ns	2.26ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6544

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472	1.129	1,069.70	1,207.80
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	1.117	875.87	978.65

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	667ns	0.353ns	1.32ns	0.00969	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	876ns	0.706ns	2.74ns	0.00922	696 B
master	`RunOnMethodBegin`	net472	1.07μs	0.659ns	2.55ns	0.104	658 B
#6544	`RunOnMethodBegin`	net6.0	706ns	0.783ns	3.03ns	0.00993	696 B
#6544	`RunOnMethodBegin`	netcoreapp3.1	978ns	0.665ns	2.57ns	0.0097	696 B
#6544	`RunOnMethodBegin`	net472	1.21μs	1.44ns	5.59ns	0.104	658 B

tracer/src/Datadog.Trace/OpenTelemetry/Sdk.cs

…e initialized indepedently of the ActivityListener

zacharycmontoya added 2 commits January 13, 2025 13:52

Add tests for the default OpenTelemetry.Api Propagator

0eb03eb

Add default implementation for OpenTelemetry Propagator API

f3e6398

zacharycmontoya changed the title ~~[Tracing] Provide OpenTelemetry.Context.Propagation.Propagators~~ [Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator Jan 13, 2025

zacharycmontoya commented Jan 13, 2025

View reviewed changes

tracer/src/Datadog.Trace/Activity/ActivityListener.cs Outdated Show resolved Hide resolved

zacharycmontoya commented Jan 13, 2025

View reviewed changes

tracer/src/Datadog.Trace/ClrProfiler/Instrumentation.cs Show resolved Hide resolved

zacharycmontoya marked this pull request as ready for review January 13, 2025 22:26

zacharycmontoya requested a review from a team as a code owner January 13, 2025 22:26

zacharycmontoya changed the title ~~[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator~~ [AIDM-504] Jan 13, 2025

zacharycmontoya changed the title ~~[AIDM-504]~~ [Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] Jan 14, 2025

bouwkast reviewed Jan 14, 2025

View reviewed changes

tracer/src/Datadog.Trace/Activity/ActivityListener.cs Outdated Show resolved Hide resolved

Revert changes to Activity.ForceDefaultIdFormat

d9d654c

bouwkast approved these changes Jan 14, 2025

View reviewed changes

lucaspimentel reviewed Jan 15, 2025

View reviewed changes

tracer/src/Datadog.Trace/OpenTelemetry/Sdk.cs Outdated Show resolved Hide resolved

lucaspimentel approved these changes Jan 15, 2025

View reviewed changes

zacharycmontoya added 2 commits January 15, 2025 12:22

Use PropertyInfo.SetValue instead of PropertyInfo.GetSetMethod().Invoke

a926014

Move OpenTelemetry.Sdk.Initialize to a separate try/catch so it can b…

b60809f

…e initialized indepedently of the ActivityListener

lucaspimentel approved these changes Jan 15, 2025

View reviewed changes

zacharycmontoya merged commit de7ffac into master Jan 15, 2025
125 of 127 checks passed

zacharycmontoya deleted the zach.montoya/otel-dropin-default-propagator branch January 15, 2025 23:58

github-actions bot added this to the vNext-v3 milestone Jan 15, 2025

andrewlock added type:enhancement Improvement to an existing feature area:opentelemetry OpenTelemetry support labels Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

zacharycmontoya commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025

datadog-ddstaging bot commented Jan 13, 2025 •

edited

Loading

andrewlock commented Jan 13, 2025 •

edited

Loading

bouwkast left a comment

bouwkast left a comment

andrewlock commented Jan 15, 2025 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #6544

Raw results

Raw results

Raw results

Slower ⚠️ in #6544

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6544

Raw results

[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

Conversation

zacharycmontoya commented Jan 13, 2025 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

github-actions bot commented Jan 13, 2025

Snapshots difference summary

datadog-ddstaging bot commented Jan 13, 2025 • edited Loading

Datadog Report

andrewlock commented Jan 13, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

bouwkast left a comment

Choose a reason for hiding this comment

bouwkast left a comment

Choose a reason for hiding this comment

andrewlock commented Jan 15, 2025 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6544

Raw results

Raw results

Raw results

Slower ⚠️ in #6544

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6544

Raw results

zacharycmontoya commented Jan 13, 2025 •

edited

Loading

datadog-ddstaging bot commented Jan 13, 2025 •

edited

Loading

andrewlock commented Jan 13, 2025 •

edited

Loading

andrewlock commented Jan 15, 2025 •

edited

Loading