Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6372

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners November 28, 2024 16:25
@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (69ms)  : 66, 73
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (982ms)  : 957, 1006
     .   : milestone, 982,
    master - mean (979ms)  : 954, 1004
     .   : milestone, 979,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (676ms)  : 660, 692
     .   : milestone, 676,
    master - mean (680ms)  : 659, 701
     .   : milestone, 680,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (91ms)  : 89, 94
     .   : milestone, 91,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (634ms)  : 615, 652
     .   : milestone, 634,
    master - mean (631ms)  : 612, 651
     .   : milestone, 631,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (190ms)  : 186, 195
     .   : milestone, 190,
    master - mean (192ms)  : 187, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (1,098ms)  : 1066, 1130
     .   : milestone, 1098,
    master - mean (1,102ms)  : 1080, 1124
     .   : milestone, 1102,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (279ms)  : 274, 283
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (872ms)  : 846, 898
     .   : milestone, 872,
    master - mean (873ms)  : 848, 899
     .   : milestone, 873,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (266ms)  : 262, 271
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (849ms)  : 817, 881
     .   : milestone, 849,
    master - mean (856ms)  : 823, 888
     .   : milestone, 856,

Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 28, 2024

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 45f7d74
Test service: dd-trace-dotnet

✅ 0 Failed, 452671 Passed, 2716 Skipped, 19h 12m 28.21s Total Time

@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6372 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.14μs 46.4ns 321ns 0.0162 0.00811 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 55.2ns 317ns 0.015 0.005 0 5.8 KB
master StartStopWithChild net472 16.3μs 67.9ns 263ns 1.04 0.303 0.0984 6.21 KB
#6372 StartStopWithChild net6.0 7.94μs 42.9ns 235ns 0.016 0.00798 0 5.6 KB
#6372 StartStopWithChild netcoreapp3.1 10.2μs 55.8ns 339ns 0.0251 0.01 0 5.8 KB
#6372 StartStopWithChild net472 16.5μs 46.7ns 181ns 1.04 0.31 0.0897 6.19 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 491μs 211ns 761ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 682μs 310ns 1.16μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 847μs 417ns 1.62μs 0.422 0 0 3.3 KB
#6372 WriteAndFlushEnrichedTraces net6.0 495μs 279ns 1.08μs 0 0 0 2.7 KB
#6372 WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 432ns 1.67μs 0 0 0 2.7 KB
#6372 WriteAndFlushEnrichedTraces net472 838μs 665ns 2.58μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 150μs 854ns 6.1μs 0.142 0 0 14.47 KB
master SendRequest netcoreapp3.1 164μs 934ns 6.74μs 0.161 0 0 17.27 KB
master SendRequest net472 0.00147ns 0.000595ns 0.00231ns 0 0 0 0 b
#6372 SendRequest net6.0 150μs 847ns 5.81μs 0.16 0 0 14.47 KB
#6372 SendRequest netcoreapp3.1 166μs 972ns 9.12μs 0.167 0 0 17.27 KB
#6372 SendRequest net472 0.00037ns 0.000188ns 0.000705ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 582μs 3.17μs 18.5μs 0.553 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 685μs 3.28μs 13.1μs 0.351 0 0 41.82 KB
master WriteAndFlushEnrichedTraces net472 860μs 4.04μs 16.7μs 8.33 2.5 0.417 53.26 KB
#6372 WriteAndFlushEnrichedTraces net6.0 565μs 2.96μs 16.5μs 0.553 0 0 41.67 KB
#6372 WriteAndFlushEnrichedTraces netcoreapp3.1 669μs 3.52μs 17.3μs 0.334 0 0 41.69 KB
#6372 WriteAndFlushEnrichedTraces net472 869μs 2.6μs 10.1μs 8.45 2.53 0.422 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.27μs 0.942ns 3.65ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.62μs 1.08ns 3.88ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.1μs 1.39ns 5.2ns 0.156 0.00106 0 987 B
#6372 ExecuteNonQuery net6.0 1.28μs 1.43ns 5.54ns 0.0147 0 0 1.02 KB
#6372 ExecuteNonQuery netcoreapp3.1 1.72μs 0.999ns 3.74ns 0.0137 0 0 1.02 KB
#6372 ExecuteNonQuery net472 2.07μs 1.43ns 5.53ns 0.156 0.00106 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.22μs 0.627ns 2.34ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.715ns 2.67ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.47μs 2.31ns 8.96ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.33μs 0.751ns 2.81ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.62μs 0.972ns 3.64ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.69μs 2.8ns 10.5ns 0.167 0 0 1.05 KB
#6372 CallElasticsearch net6.0 1.29μs 0.443ns 1.66ns 0.0135 0 0 976 B
#6372 CallElasticsearch netcoreapp3.1 1.61μs 0.85ns 3.18ns 0.013 0 0 976 B
#6372 CallElasticsearch net472 2.7μs 2.18ns 8.46ns 0.158 0 0 995 B
#6372 CallElasticsearchAsync net6.0 1.31μs 0.858ns 3.32ns 0.0138 0 0 952 B
#6372 CallElasticsearchAsync netcoreapp3.1 1.61μs 0.717ns 2.78ns 0.0137 0 0 1.02 KB
#6372 CallElasticsearchAsync net472 2.67μs 1.13ns 4.23ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.23μs 1.18ns 4.4ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.77μs 0.984ns 3.81ns 0.0131 0 0 952 B
master ExecuteAsync net472 1.79μs 0.634ns 2.45ns 0.145 0 0 915 B
#6372 ExecuteAsync net6.0 1.24μs 0.598ns 2.32ns 0.013 0 0 952 B
#6372 ExecuteAsync netcoreapp3.1 1.64μs 0.632ns 2.28ns 0.0131 0 0 952 B
#6372 ExecuteAsync net472 1.86μs 0.447ns 1.73ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.37μs 1.25ns 4.49ns 0.0329 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.25μs 2.93ns 11ns 0.0365 0 0 2.85 KB
master SendAsync net472 7.41μs 2.13ns 8.25ns 0.493 0 0 3.12 KB
#6372 SendAsync net6.0 4.24μs 1.43ns 5.36ns 0.0317 0 0 2.31 KB
#6372 SendAsync netcoreapp3.1 5.28μs 1.76ns 6.8ns 0.0369 0 0 2.85 KB
#6372 SendAsync net472 7.41μs 1.86ns 7.22ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 0.843ns 3.27ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.21μs 1.42ns 5.49ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.49μs 1.47ns 5.5ns 0.249 0 0 1.57 KB
#6372 EnrichedLog net6.0 1.52μs 0.572ns 2.14ns 0.0235 0 0 1.64 KB
#6372 EnrichedLog netcoreapp3.1 2.12μs 3.28ns 12.7ns 0.0223 0 0 1.64 KB
#6372 EnrichedLog net472 2.56μs 1.54ns 5.77ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 121μs 144ns 558ns 0.0603 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 125μs 78.8ns 295ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 123ns 462ns 0.682 0.227 0 4.46 KB
#6372 EnrichedLog net6.0 120μs 163ns 630ns 0.0607 0 0 4.28 KB
#6372 EnrichedLog netcoreapp3.1 124μs 161ns 622ns 0 0 0 4.28 KB
#6372 EnrichedLog net472 152μs 115ns 446ns 0.686 0.229 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 1.04ns 4.02ns 0.0301 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.2μs 1.25ns 4.83ns 0.0295 0 0 2.2 KB
master EnrichedLog net472 4.95μs 1.29ns 4.99ns 0.319 0 0 2.02 KB
#6372 EnrichedLog net6.0 2.94μs 0.522ns 1.88ns 0.0309 0 0 2.2 KB
#6372 EnrichedLog netcoreapp3.1 4.21μs 3.47ns 13.4ns 0.0293 0 0 2.2 KB
#6372 EnrichedLog net472 4.78μs 1.93ns 7.23ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.42μs 0.892ns 3.34ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.79μs 1.14ns 4.4ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.17μs 1.57ns 6.07ns 0.183 0 0 1.16 KB
#6372 SendReceive net6.0 1.36μs 0.571ns 2.21ns 0.0163 0 0 1.14 KB
#6372 SendReceive netcoreapp3.1 1.72μs 1.33ns 5.16ns 0.0155 0 0 1.14 KB
#6372 SendReceive net472 2.06μs 1.62ns 6.27ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.86μs 2.03ns 7.85ns 0.0215 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.71μs 1.7ns 6.58ns 0.0203 0 0 1.65 KB
master EnrichedLog net472 4.4μs 4.05ns 15.7ns 0.324 0 0 2.04 KB
#6372 EnrichedLog net6.0 2.76μs 1.02ns 3.95ns 0.0221 0 0 1.6 KB
#6372 EnrichedLog netcoreapp3.1 3.82μs 2.66ns 9.95ns 0.021 0 0 1.65 KB
#6372 EnrichedLog net472 4.49μs 3.06ns 11.8ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 413ns 0.225ns 0.871ns 0.0082 0 0 576 B
master StartFinishSpan netcoreapp3.1 563ns 0.28ns 1.08ns 0.00758 0 0 576 B
master StartFinishSpan net472 756ns 0.273ns 1.06ns 0.0915 0 0 578 B
master StartFinishScope net6.0 497ns 1.42ns 5.33ns 0.00964 0 0 696 B
master StartFinishScope netcoreapp3.1 685ns 0.305ns 1.18ns 0.0096 0 0 696 B
master StartFinishScope net472 842ns 0.767ns 2.97ns 0.105 0 0 658 B
#6372 StartFinishSpan net6.0 395ns 0.249ns 0.965ns 0.00805 0 0 576 B
#6372 StartFinishSpan netcoreapp3.1 551ns 0.351ns 1.36ns 0.0078 0 0 576 B
#6372 StartFinishSpan net472 741ns 0.538ns 2.08ns 0.0917 0 0 578 B
#6372 StartFinishScope net6.0 489ns 0.525ns 2.03ns 0.00976 0 0 696 B
#6372 StartFinishScope netcoreapp3.1 752ns 0.357ns 1.34ns 0.00946 0 0 696 B
#6372 StartFinishScope net472 916ns 0.817ns 3.16ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 653ns 0.246ns 0.92ns 0.00989 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 935ns 0.486ns 1.82ns 0.00923 0 0 696 B
master RunOnMethodBegin net472 1.19μs 0.363ns 1.4ns 0.104 0 0 658 B
#6372 RunOnMethodBegin net6.0 620ns 0.562ns 2.18ns 0.0096 0 0 696 B
#6372 RunOnMethodBegin netcoreapp3.1 1.01μs 0.755ns 2.83ns 0.00909 0 0 696 B
#6372 RunOnMethodBegin net472 1.1μs 0.878ns 3.4ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6372) (11.193M)   : 0, 11193440
    master (10.959M)   : 0, 10958752
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6372) (7.330M)   : 0, 7329829
    master (7.142M)   : 0, 7142062
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.565M)   : 0, 7564960

    section Manual
    master (11.087M)   : 0, 11086868

    section Manual + Automatic
    This PR (6372) (6.734M)   : 0, 6734305
    master (6.731M)   : 0, 6731055

    section DD_TRACE_ENABLED=0
    master (10.193M)   : 0, 10192820

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6372) (9.494M)   : 0, 9494244
    master (9.541M)   : 0, 9540843
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6372) (6.403M)   : 0, 6402825
    master (6.379M)   : 0, 6379462

    section Trace stats
    master (6.703M)   : 0, 6702605

    section Manual
    master (9.289M)   : 0, 9288933

    section Manual + Automatic
    This PR (6372) (6.006M)   : 0, 6006079
    master (5.931M)   : 0, 5931165

    section DD_TRACE_ENABLED=0
    master (8.565M)   : 0, 8565457

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6372) (9.872M)   : 0, 9871865
    master (10.517M)   : 0, 10517430
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6372) (6.474M)   : 0, 6474219
    master (6.756M)   : 0, 6755522
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.266M)   : 0, 7265713

    section Manual
    master (10.222M)   : 0, 10222021

    section Manual + Automatic
    This PR (6372) (5.987M)   : 0, 5986904
    master (5.941M)   : 0, 5941030

    section DD_TRACE_ENABLED=0
    master (9.471M)   : 0, 9470886

Loading

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from b932e4c to ac9ec60 Compare November 29, 2024 16:35
@quinna-h quinna-h requested a review from andrewlock December 2, 2024 15:13
@quinna-h
Copy link
Contributor

quinna-h commented Dec 2, 2024

The modified files look good to me, unsure if any of the test failures are related to the actual PR

Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock andrewlock merged commit 1dcee5a into master Dec 3, 2024
76 of 78 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch December 3, 2024 15:16
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 3, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
Updates the package versions for integration tests.

Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Quinna Halim <[email protected]>
@andrewlock andrewlock added dependencies Pull requests that update a dependency file area:dependabot dependabot updates area:integrations labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependabot dependabot updates area:integrations dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants