Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners November 28, 2024 16:25
@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (69ms)  : 65, 73
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (978ms)  : 956, 999
     .   : milestone, 978,
    master - mean (983ms)  : 961, 1006
     .   : milestone, 983,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (678ms)  : 660, 696
     .   : milestone, 678,
    master - mean (681ms)  : 663, 699
     .   : milestone, 681,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 88, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (632ms)  : 616, 648
     .   : milestone, 632,
    master - mean (632ms)  : 619, 645
     .   : milestone, 632,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (1,095ms)  : 1057, 1132
     .   : milestone, 1095,
    master - mean (1,090ms)  : 1058, 1122
     .   : milestone, 1090,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (276ms)  : 269, 283
     .   : milestone, 276,
    master - mean (275ms)  : 270, 281
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (871ms)  : 842, 900
     .   : milestone, 871,
    master - mean (869ms)  : 844, 894
     .   : milestone, 869,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6372) - mean (265ms)  : 261, 270
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6372) - mean (851ms)  : 814, 888
     .   : milestone, 851,
    master - mean (847ms)  : 817, 878
     .   : milestone, 847,

Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 28, 2024

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: ac9ec60
Test service: dd-trace-dotnet

❌ 2 Failed (0 Known Flaky), 456087 Passed, 2729 Skipped, 19h 0m 48.67s Total Time

❌ Failed Tests (2)

  • SubmitTraces - Datadog.Trace.ClrProfiler.IntegrationTests.CI.TcpXUnitEvpTests - Details

    Expand for error
     Assert.Equal() Failure
     Expected: 16
     Actual:   0
    
  • TypicalLoop_WithLogsQueueTrigger - Datadog.Trace.Tests.Telemetry.TelemetryControllerSchedulerTests - Details

    Expand for error
     Expected boolean to be true, but found False.
    

@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6372 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.183
  • 1 benchmarks are slower, with geometric mean 1.157
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.1μs 45.4ns 287ns 0.0265 0.0113 0 5.61 KB
master StartStopWithChild netcoreapp3.1 9.89μs 39.8ns 149ns 0.0153 0.00511 0 5.8 KB
master StartStopWithChild net472 16.3μs 48.9ns 189ns 1.04 0.303 0.103 6.21 KB
#6372 StartStopWithChild net6.0 7.93μs 44.1ns 299ns 0.0285 0.0122 0 5.61 KB
#6372 StartStopWithChild netcoreapp3.1 10.3μs 56.9ns 360ns 0.025 0.01 0 5.8 KB
#6372 StartStopWithChild net472 16.2μs 64.8ns 251ns 1.05 0.312 0.0961 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 479μs 248ns 961ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 254ns 982ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 853μs 870ns 3.37μs 0.425 0 0 3.3 KB
#6372 WriteAndFlushEnrichedTraces net6.0 469μs 390ns 1.46μs 0 0 0 2.7 KB
#6372 WriteAndFlushEnrichedTraces netcoreapp3.1 668μs 370ns 1.43μs 0 0 0 2.7 KB
#6372 WriteAndFlushEnrichedTraces net472 849μs 531ns 2.06μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 161μs 1.3μs 12.9μs 0.156 0 0 14.47 KB
master SendRequest netcoreapp3.1 167μs 918ns 7.17μs 0.176 0 0 17.27 KB
master SendRequest net472 0.00221ns 0.000746ns 0.00279ns 0 0 0 0 b
#6372 SendRequest net6.0 152μs 887ns 8.41μs 0.169 0 0 14.47 KB
#6372 SendRequest netcoreapp3.1 170μs 986ns 8.82μs 0.156 0 0 17.27 KB
#6372 SendRequest net472 0.00167ns 0.000754ns 0.00292ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 585μs 2.9μs 14.8μs 0.551 0 0 41.72 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 3.17μs 12.7μs 0.338 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 901μs 4.3μs 16.7μs 8.04 2.23 0.446 53.3 KB
#6372 WriteAndFlushEnrichedTraces net6.0 562μs 3.03μs 16μs 0.278 0 0 41.67 KB
#6372 WriteAndFlushEnrichedTraces netcoreapp3.1 685μs 1.94μs 7.01μs 0.343 0 0 41.74 KB
#6372 WriteAndFlushEnrichedTraces net472 852μs 4.22μs 17.4μs 8.39 2.52 0.419 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.38μs 1.87ns 7.23ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.74μs 2.03ns 7.86ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.12μs 1.91ns 7.41ns 0.156 0.00105 0 987 B
#6372 ExecuteNonQuery net6.0 1.28μs 1.31ns 4.89ns 0.014 0 0 1.02 KB
#6372 ExecuteNonQuery netcoreapp3.1 1.66μs 2.71ns 10.5ns 0.0137 0 0 1.02 KB
#6372 ExecuteNonQuery net472 2.09μs 3.04ns 11.8ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 0.558ns 2.09ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.723ns 2.7ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.57μs 1.13ns 4.23ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.21μs 0.628ns 2.35ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.6μs 0.976ns 3.52ns 0.0137 0 0 1.02 KB
master CallElasticsearchAsync net472 2.61μs 1.11ns 4.17ns 0.166 0 0 1.05 KB
#6372 CallElasticsearch net6.0 1.18μs 0.694ns 2.6ns 0.0137 0 0 976 B
#6372 CallElasticsearch netcoreapp3.1 1.53μs 0.599ns 2.24ns 0.0128 0 0 976 B
#6372 CallElasticsearch net472 2.64μs 1.16ns 4.48ns 0.157 0 0 995 B
#6372 CallElasticsearchAsync net6.0 1.33μs 1.14ns 4.27ns 0.0134 0 0 952 B
#6372 CallElasticsearchAsync netcoreapp3.1 1.64μs 0.992ns 3.84ns 0.0143 0 0 1.02 KB
#6372 CallElasticsearchAsync net472 2.62μs 1.28ns 4.97ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 2.53ns 9.82ns 0.0137 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 2.03ns 7.04ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.84μs 0.325ns 1.26ns 0.145 0 0 915 B
#6372 ExecuteAsync net6.0 1.22μs 0.745ns 2.79ns 0.0133 0 0 952 B
#6372 ExecuteAsync netcoreapp3.1 1.6μs 1.27ns 4.74ns 0.0129 0 0 952 B
#6372 ExecuteAsync net472 1.79μs 0.763ns 2.86ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.32μs 2.21ns 8.55ns 0.0324 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.46μs 2.02ns 7.82ns 0.0383 0 0 2.85 KB
master SendAsync net472 7.36μs 0.69ns 2.58ns 0.493 0 0 3.12 KB
#6372 SendAsync net6.0 4.33μs 2.12ns 8.2ns 0.0323 0 0 2.31 KB
#6372 SendAsync netcoreapp3.1 5.26μs 1.8ns 6.98ns 0.0367 0 0 2.85 KB
#6372 SendAsync net472 7.4μs 2.25ns 8.43ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.49μs 0.869ns 3.37ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.22μs 0.923ns 3.46ns 0.0222 0 0 1.64 KB
master EnrichedLog net472 2.63μs 0.688ns 2.57ns 0.249 0 0 1.57 KB
#6372 EnrichedLog net6.0 1.45μs 0.61ns 2.28ns 0.0232 0 0 1.64 KB
#6372 EnrichedLog netcoreapp3.1 2.09μs 0.928ns 3.59ns 0.022 0 0 1.64 KB
#6372 EnrichedLog net472 2.57μs 1.09ns 3.94ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 121μs 155ns 601ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 125μs 186ns 721ns 0 0 0 4.28 KB
master EnrichedLog net472 152μs 143ns 553ns 0.69 0.23 0 4.46 KB
#6372 EnrichedLog net6.0 120μs 182ns 706ns 0 0 0 4.28 KB
#6372 EnrichedLog netcoreapp3.1 125μs 147ns 568ns 0 0 0 4.28 KB
#6372 EnrichedLog net472 152μs 160ns 597ns 0.676 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.06μs 1.38ns 5.35ns 0.0308 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.06μs 3.49ns 13.5ns 0.0286 0 0 2.2 KB
master EnrichedLog net472 4.82μs 1.05ns 4.07ns 0.321 0 0 2.02 KB
#6372 EnrichedLog net6.0 3.08μs 1.47ns 5.29ns 0.0309 0 0 2.2 KB
#6372 EnrichedLog netcoreapp3.1 3.98μs 1.19ns 4.46ns 0.0298 0 0 2.2 KB
#6372 EnrichedLog net472 4.88μs 1.71ns 6.62ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.43μs 1.46ns 5.45ns 0.0164 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 0.68ns 2.54ns 0.0159 0 0 1.14 KB
master SendReceive net472 2.14μs 1.4ns 5.25ns 0.183 0 0 1.16 KB
#6372 SendReceive net6.0 1.41μs 0.965ns 3.74ns 0.0162 0 0 1.14 KB
#6372 SendReceive netcoreapp3.1 1.83μs 1.05ns 4.08ns 0.0155 0 0 1.14 KB
#6372 SendReceive net472 2.13μs 2.05ns 7.94ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.74μs 0.79ns 3.06ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.92μs 2.02ns 7.82ns 0.0214 0 0 1.65 KB
master EnrichedLog net472 4.4μs 1.36ns 5.08ns 0.322 0 0 2.04 KB
#6372 EnrichedLog net6.0 2.86μs 0.694ns 2.69ns 0.0229 0 0 1.6 KB
#6372 EnrichedLog netcoreapp3.1 3.95μs 1.21ns 4.51ns 0.0216 0 0 1.65 KB
#6372 EnrichedLog net472 4.34μs 1.46ns 5.46ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6372

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.238 488.67 394.70
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.130 791.95 701.05

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 488ns 0.733ns 2.84ns 0.00814 0 0 576 B
master StartFinishSpan netcoreapp3.1 568ns 1.39ns 5.21ns 0.00754 0 0 576 B
master StartFinishSpan net472 596ns 1.63ns 6.3ns 0.0916 0 0 578 B
master StartFinishScope net6.0 483ns 0.75ns 2.91ns 0.0098 0 0 696 B
master StartFinishScope netcoreapp3.1 790ns 1.65ns 6.4ns 0.00912 0 0 696 B
master StartFinishScope net472 832ns 1.39ns 5.36ns 0.104 0 0 658 B
#6372 StartFinishSpan net6.0 394ns 0.711ns 2.76ns 0.00799 0 0 576 B
#6372 StartFinishSpan netcoreapp3.1 622ns 0.885ns 3.31ns 0.00773 0 0 576 B
#6372 StartFinishSpan net472 638ns 1.42ns 5.51ns 0.0918 0 0 578 B
#6372 StartFinishScope net6.0 481ns 0.53ns 2.05ns 0.00967 0 0 696 B
#6372 StartFinishScope netcoreapp3.1 703ns 1.29ns 4.99ns 0.00933 0 0 696 B
#6372 StartFinishScope net472 830ns 2.26ns 8.74ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6372

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.157 608.13 703.44

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 608ns 1.03ns 3.97ns 0.00976 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 905ns 1.41ns 5.48ns 0.00953 0 0 696 B
master RunOnMethodBegin net472 1.13μs 1.68ns 6.49ns 0.104 0 0 658 B
#6372 RunOnMethodBegin net6.0 703ns 0.979ns 3.79ns 0.00959 0 0 696 B
#6372 RunOnMethodBegin netcoreapp3.1 900ns 1.45ns 5.62ns 0.00937 0 0 696 B
#6372 RunOnMethodBegin net472 1.14μs 2.07ns 8.03ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6372) (11.235M)   : 0, 11234943
    master (10.950M)   : 0, 10950268
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6372) (7.195M)   : 0, 7195307
    master (7.144M)   : 0, 7144062
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.592M)   : 0, 7592116

    section Manual
    master (11.151M)   : 0, 11151368

    section Manual + Automatic
    This PR (6372) (6.697M)   : 0, 6696849
    master (6.721M)   : 0, 6721227

    section DD_TRACE_ENABLED=0
    master (10.133M)   : 0, 10132646

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6372) (9.547M)   : 0, 9546598
    master (9.581M)   : 0, 9581060
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6372) (6.078M)   : crit ,0, 6078259
    master (6.411M)   : 0, 6411077

    section Trace stats
    master (6.557M)   : 0, 6557433

    section Manual
    master (9.539M)   : 0, 9539314

    section Manual + Automatic
    This PR (6372) (5.926M)   : 0, 5926268
    master (5.854M)   : 0, 5854294

    section DD_TRACE_ENABLED=0
    master (8.891M)   : 0, 8890821

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6372) (10.116M)   : 0, 10116323
    master (10.194M)   : 0, 10193580
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6372) (6.486M)   : 0, 6485570
    master (6.769M)   : 0, 6768819
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.357M)   : 0, 7356753

    section Manual
    master (10.447M)   : 0, 10447376

    section Manual + Automatic
    This PR (6372) (5.897M)   : 0, 5897003
    master (5.985M)   : 0, 5985300

    section DD_TRACE_ENABLED=0
    master (9.475M)   : 0, 9475300

Loading

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from b932e4c to ac9ec60 Compare November 29, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant