-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Package Versions Bump] Updating package versions #6372
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (69ms) : 66, 73
. : milestone, 69,
master - mean (69ms) : 66, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (982ms) : 957, 1006
. : milestone, 982,
master - mean (979ms) : 954, 1004
. : milestone, 979,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (107ms) : 105, 109
. : milestone, 107,
master - mean (108ms) : 106, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (676ms) : 660, 692
. : milestone, 676,
master - mean (680ms) : 659, 701
. : milestone, 680,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (91ms) : 89, 94
. : milestone, 91,
master - mean (92ms) : 89, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (634ms) : 615, 652
. : milestone, 634,
master - mean (631ms) : 612, 651
. : milestone, 631,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (190ms) : 186, 195
. : milestone, 190,
master - mean (192ms) : 187, 196
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (1,098ms) : 1066, 1130
. : milestone, 1098,
master - mean (1,102ms) : 1080, 1124
. : milestone, 1102,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (276ms) : 271, 281
. : milestone, 276,
master - mean (279ms) : 274, 283
. : milestone, 279,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (872ms) : 846, 898
. : milestone, 872,
master - mean (873ms) : 848, 899
. : milestone, 873,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (266ms) : 262, 271
. : milestone, 266,
master - mean (266ms) : 262, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (849ms) : 817, 881
. : milestone, 849,
master - mean (856ms) : 823, 888
. : milestone, 856,
|
Datadog ReportBranch report: ✅ 0 Failed, 452671 Passed, 2716 Skipped, 19h 12m 28.21s Total Time |
Benchmarks Report for tracer 🐌Benchmarks for #6372 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6372) (11.193M) : 0, 11193440
master (10.959M) : 0, 10958752
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6372) (7.330M) : 0, 7329829
master (7.142M) : 0, 7142062
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.565M) : 0, 7564960
section Manual
master (11.087M) : 0, 11086868
section Manual + Automatic
This PR (6372) (6.734M) : 0, 6734305
master (6.731M) : 0, 6731055
section DD_TRACE_ENABLED=0
master (10.193M) : 0, 10192820
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6372) (9.494M) : 0, 9494244
master (9.541M) : 0, 9540843
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6372) (6.403M) : 0, 6402825
master (6.379M) : 0, 6379462
section Trace stats
master (6.703M) : 0, 6702605
section Manual
master (9.289M) : 0, 9288933
section Manual + Automatic
This PR (6372) (6.006M) : 0, 6006079
master (5.931M) : 0, 5931165
section DD_TRACE_ENABLED=0
master (8.565M) : 0, 8565457
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6372) (9.872M) : 0, 9871865
master (10.517M) : 0, 10517430
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6372) (6.474M) : 0, 6474219
master (6.756M) : 0, 6755522
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.266M) : 0, 7265713
section Manual
master (10.222M) : 0, 10222021
section Manual + Automatic
This PR (6372) (5.987M) : 0, 5986904
master (5.941M) : 0, 5941030
section DD_TRACE_ENABLED=0
master (9.471M) : 0, 9470886
|
b932e4c
to
ac9ec60
Compare
The modified files look good to me, unsure if any of the test failures are related to the actual PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates the package versions for integration tests. Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Quinna Halim <[email protected]>
Updates the package versions for integration tests.