-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Package Versions Bump] Updating package versions #6372
base: master
Are you sure you want to change the base?
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (69ms) : 65, 73
. : milestone, 69,
master - mean (69ms) : 66, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (978ms) : 956, 999
. : milestone, 978,
master - mean (983ms) : 961, 1006
. : milestone, 983,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (108ms) : 106, 110
. : milestone, 108,
master - mean (108ms) : 105, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (678ms) : 660, 696
. : milestone, 678,
master - mean (681ms) : 663, 699
. : milestone, 681,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 88, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (632ms) : 616, 648
. : milestone, 632,
master - mean (632ms) : 619, 645
. : milestone, 632,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (190ms) : 186, 194
. : milestone, 190,
master - mean (190ms) : 185, 195
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (1,095ms) : 1057, 1132
. : milestone, 1095,
master - mean (1,090ms) : 1058, 1122
. : milestone, 1090,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (276ms) : 269, 283
. : milestone, 276,
master - mean (275ms) : 270, 281
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (871ms) : 842, 900
. : milestone, 871,
master - mean (869ms) : 844, 894
. : milestone, 869,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6372) - mean (265ms) : 261, 270
. : milestone, 265,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6372) - mean (851ms) : 814, 888
. : milestone, 851,
master - mean (847ms) : 817, 878
. : milestone, 847,
|
Datadog ReportBranch report: ❌ 2 Failed (0 Known Flaky), 456087 Passed, 2729 Skipped, 19h 0m 48.67s Total Time ❌ Failed Tests (2)
|
Benchmarks Report for tracer 🐌Benchmarks for #6372 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.238 | 488.67 | 394.70 | |
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.130 | 791.95 | 701.05 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 488ns | 0.733ns | 2.84ns | 0.00814 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 568ns | 1.39ns | 5.21ns | 0.00754 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 596ns | 1.63ns | 6.3ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 483ns | 0.75ns | 2.91ns | 0.0098 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 790ns | 1.65ns | 6.4ns | 0.00912 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 832ns | 1.39ns | 5.36ns | 0.104 | 0 | 0 | 658 B |
#6372 | StartFinishSpan |
net6.0 | 394ns | 0.711ns | 2.76ns | 0.00799 | 0 | 0 | 576 B |
#6372 | StartFinishSpan |
netcoreapp3.1 | 622ns | 0.885ns | 3.31ns | 0.00773 | 0 | 0 | 576 B |
#6372 | StartFinishSpan |
net472 | 638ns | 1.42ns | 5.51ns | 0.0918 | 0 | 0 | 578 B |
#6372 | StartFinishScope |
net6.0 | 481ns | 0.53ns | 2.05ns | 0.00967 | 0 | 0 | 696 B |
#6372 | StartFinishScope |
netcoreapp3.1 | 703ns | 1.29ns | 4.99ns | 0.00933 | 0 | 0 | 696 B |
#6372 | StartFinishScope |
net472 | 830ns | 2.26ns | 8.74ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6372
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.157
608.13
703.44
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.157 | 608.13 | 703.44 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 608ns | 1.03ns | 3.97ns | 0.00976 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 905ns | 1.41ns | 5.48ns | 0.00953 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.13μs | 1.68ns | 6.49ns | 0.104 | 0 | 0 | 658 B |
#6372 | RunOnMethodBegin |
net6.0 | 703ns | 0.979ns | 3.79ns | 0.00959 | 0 | 0 | 696 B |
#6372 | RunOnMethodBegin |
netcoreapp3.1 | 900ns | 1.45ns | 5.62ns | 0.00937 | 0 | 0 | 696 B |
#6372 | RunOnMethodBegin |
net472 | 1.14μs | 2.07ns | 8.03ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6372) (11.235M) : 0, 11234943
master (10.950M) : 0, 10950268
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6372) (7.195M) : 0, 7195307
master (7.144M) : 0, 7144062
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.592M) : 0, 7592116
section Manual
master (11.151M) : 0, 11151368
section Manual + Automatic
This PR (6372) (6.697M) : 0, 6696849
master (6.721M) : 0, 6721227
section DD_TRACE_ENABLED=0
master (10.133M) : 0, 10132646
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6372) (9.547M) : 0, 9546598
master (9.581M) : 0, 9581060
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6372) (6.078M) : crit ,0, 6078259
master (6.411M) : 0, 6411077
section Trace stats
master (6.557M) : 0, 6557433
section Manual
master (9.539M) : 0, 9539314
section Manual + Automatic
This PR (6372) (5.926M) : 0, 5926268
master (5.854M) : 0, 5854294
section DD_TRACE_ENABLED=0
master (8.891M) : 0, 8890821
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6372) (10.116M) : 0, 10116323
master (10.194M) : 0, 10193580
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6372) (6.486M) : 0, 6485570
master (6.769M) : 0, 6768819
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.357M) : 0, 7356753
section Manual
master (10.447M) : 0, 10447376
section Manual + Automatic
This PR (6372) (5.897M) : 0, 5897003
master (5.985M) : 0, 5985300
section DD_TRACE_ENABLED=0
master (9.475M) : 0, 9475300
|
b932e4c
to
ac9ec60
Compare
Updates the package versions for integration tests.