[Test Package Versions Bump] Updating package versions #6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Datadog ReportBranch report: ✅ 0 Failed, 448381 Passed, 2730 Skipped, 19h 10m 39.82s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6351) - mean (69ms) : 66, 73
. : milestone, 69,
master - mean (69ms) : 65, 74
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6351) - mean (996ms) : 944, 1048
. : milestone, 996,
master - mean (976ms) : 953, 999
. : milestone, 976,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6351) - mean (110ms) : 106, 115
. : milestone, 110,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6351) - mean (685ms) : 668, 701
. : milestone, 685,
master - mean (678ms) : 659, 697
. : milestone, 678,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6351) - mean (92ms) : 89, 95
. : milestone, 92,
master - mean (92ms) : 89, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6351) - mean (650ms) : 625, 676
. : milestone, 650,
master - mean (633ms) : 614, 651
. : milestone, 633,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6351) - mean (190ms) : 185, 196
. : milestone, 190,
master - mean (190ms) : 186, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6351) - mean (1,094ms) : 1066, 1122
. : milestone, 1094,
master - mean (1,092ms) : 1068, 1116
. : milestone, 1092,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6351) - mean (277ms) : 273, 282
. : milestone, 277,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6351) - mean (871ms) : 837, 905
. : milestone, 871,
master - mean (870ms) : 835, 905
. : milestone, 870,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6351) - mean (266ms) : 261, 271
. : milestone, 266,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6351) - mean (853ms) : 816, 890
. : milestone, 853,
master - mean (850ms) : 811, 888
. : milestone, 850,
|
bouwkast
approved these changes
Nov 25, 2024
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6351) (11.257M) : 0, 11256993
master (11.198M) : 0, 11198348
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6351) (7.384M) : 0, 7383847
master (7.205M) : 0, 7205466
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.443M) : 0, 7442635
section Manual
master (11.218M) : 0, 11217680
section Manual + Automatic
This PR (6351) (6.819M) : 0, 6819026
master (6.727M) : 0, 6726536
section DD_TRACE_ENABLED=0
master (10.410M) : 0, 10409702
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6351) (9.589M) : 0, 9588832
master (9.510M) : 0, 9510466
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6351) (6.287M) : 0, 6286710
master (6.331M) : 0, 6331398
section Trace stats
master (6.659M) : 0, 6658730
section Manual
master (9.280M) : 0, 9280107
section Manual + Automatic
This PR (6351) (5.983M) : 0, 5982959
master (5.691M) : 0, 5690770
section DD_TRACE_ENABLED=0
master (8.840M) : 0, 8840434
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6351) (10.261M) : 0, 10261499
master (10.163M) : 0, 10163050
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6351) (6.629M) : 0, 6629014
master (6.829M) : 0, 6828973
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.555M) : 0, 7554541
section Manual
master (10.735M) : 0, 10735441
section Manual + Automatic
This PR (6351) (5.825M) : crit ,0, 5825196
master (6.575M) : 0, 6575410
section DD_TRACE_ENABLED=0
master (10.155M) : 0, 10155272
|
Benchmarks Report for tracer 🐌Benchmarks for #6351 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.164 | 405.04 | 471.32 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 405ns | 0.288ns | 1.11ns | 0.00814 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 656ns | 0.217ns | 0.813ns | 0.00764 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 639ns | 0.675ns | 2.62ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 484ns | 0.247ns | 0.925ns | 0.00971 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 758ns | 0.341ns | 1.28ns | 0.00944 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 895ns | 0.456ns | 1.77ns | 0.104 | 0 | 0 | 658 B |
| #6351 | StartFinishSpan |
net6.0 | 471ns | 0.295ns | 1.14ns | 0.00798 | 0 | 0 | 576 B |
| #6351 | StartFinishSpan |
netcoreapp3.1 | 618ns | 0.36ns | 1.39ns | 0.00773 | 0 | 0 | 576 B |
| #6351 | StartFinishSpan |
net472 | 708ns | 0.296ns | 1.15ns | 0.0918 | 0 | 0 | 578 B |
| #6351 | StartFinishScope |
net6.0 | 489ns | 1.55ns | 6.02ns | 0.00989 | 0 | 0 | 696 B |
| #6351 | StartFinishScope |
netcoreapp3.1 | 750ns | 1.08ns | 4.18ns | 0.00958 | 0 | 0 | 696 B |
| #6351 | StartFinishScope |
net472 | 893ns | 0.46ns | 1.78ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 646ns | 0.517ns | 1.93ns | 0.00975 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1μs | 0.992ns | 3.84ns | 0.00904 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.05μs | 0.503ns | 1.95ns | 0.104 | 0 | 0 | 658 B |
| #6351 | RunOnMethodBegin |
net6.0 | 666ns | 0.292ns | 1.09ns | 0.00984 | 0 | 0 | 696 B |
| #6351 | RunOnMethodBegin |
netcoreapp3.1 | 914ns | 0.404ns | 1.56ns | 0.00888 | 0 | 0 | 696 B |
| #6351 | RunOnMethodBegin |
net472 | 1.14μs | 0.382ns | 1.38ns | 0.104 | 0 | 0 | 658 B |
github-actions
bot
force-pushed
the
bot/test-package-versions-bump
branch
2 times, most recently
from
5fd994c to
62bb5a9
Compare
github-actions
bot
force-pushed
the
bot/test-package-versions-bump
branch
from
62bb5a9 to
fee74f4
Compare
andrewlock
approved these changes
Nov 28, 2024
| "maxAssemblyVersionInclusive": "8.65535.65535", | ||
| "maxAssemblyVersionInclusive": "9.65535.65535", |
There was a problem hiding this comment.
Note sure how this got missed in the .NET 9 PR, but 🤷♂️
veerbia
pushed a commit
that referenced
this pull request
Dec 16, 2024
Updates the package versions for integration tests. Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
andrewlock
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the package versions for integration tests.