fix unit tests by creating a new headers collection each time instad …

…of sharing it
DataDog · Nov 1, 2021 · efc1f98 · efc1f98
1 parent 5afcd69
commit efc1f98
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/tracer/test/Datadog.Trace.Tests/HeadersCollectionTests.cs b/tracer/test/Datadog.Trace.Tests/HeadersCollectionTests.cs
@@ -28,30 +28,35 @@ public class HeadersCollectionTests
 
         public static IEnumerable<object[]> GetHeaderCollectionImplementations()
         {
-            yield return new object[] { WebRequest.CreateHttp("http://localhost").Headers.Wrap() };
-            yield return new object[] { new NameValueCollection().Wrap() };
-            yield return new object[] { new DictionaryHeadersCollection() };
+            return GetHeaderCollectionFactories().Select(factory => new object[] { factory() });
         }
 
         public static IEnumerable<object[]> GetHeadersInvalidIdsCartesianProduct()
         {
-            return from header in GetHeaderCollectionImplementations().SelectMany(i => i)
+            return from headersFactory in GetHeaderCollectionFactories()
                    from invalidId in HeadersCollectionTestHelpers.GetInvalidIds().SelectMany(i => i)
-                   select new[] { header, invalidId };
+                   select new[] { headersFactory(), invalidId };
         }
 
         public static IEnumerable<object[]> GetHeadersInvalidIntegerSamplingPrioritiesCartesianProduct()
         {
-            return from header in GetHeaderCollectionImplementations().SelectMany(i => i)
+            return from headersFactory in GetHeaderCollectionFactories()
                    from invalidSamplingPriority in HeadersCollectionTestHelpers.GetInvalidIntegerSamplingPriorities().SelectMany(i => i)
-                   select new[] { header, invalidSamplingPriority };
+                   select new[] { headersFactory(), invalidSamplingPriority };
         }
 
         public static IEnumerable<object[]> GetHeadersInvalidNonIntegerSamplingPrioritiesCartesianProduct()
         {
-            return from header in GetHeaderCollectionImplementations().SelectMany(i => i)
+            return from headersFactory in GetHeaderCollectionFactories()
                    from invalidSamplingPriority in HeadersCollectionTestHelpers.GetInvalidNonIntegerSamplingPriorities().SelectMany(i => i)
-                   select new[] { header, invalidSamplingPriority };
+                   select new[] { headersFactory(), invalidSamplingPriority };
+        }
+
+        internal static IEnumerable<Func<IHeadersCollection>> GetHeaderCollectionFactories()
+        {
+            yield return () => WebRequest.CreateHttp("http://localhost").Headers.Wrap();
+            yield return () => new NameValueCollection().Wrap();
+            yield return () => new DictionaryHeadersCollection();
         }
 
         [Theory]