Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for 2.16.0 #2402

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

ambushwork
Copy link
Member

What does this PR do?

Update changelog for 2.16.0

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few formatting suggestions. On top of this, I think it will be handy to annotate feature/improvements with related feature name, e.g. Add TabandTabRow Composable groups mappers. -> Session Replay: Add TabandTabRow Composable groups mappers.. And maybe have See ... part on the same line?

Also I think you want to have release/2.16.0 as target branch for this PR instead of develop and maybe update SDK version in the same PR?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ambushwork ambushwork requested a review from 0xnm November 20, 2024 10:48
@ambushwork ambushwork changed the base branch from develop to release/2.16.0 November 20, 2024 11:05
@ambushwork
Copy link
Member Author

@0xnm good remark, updated

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.77%. Comparing base (bf7a862) to head (f2d2331).
Report is 2 commits behind head on release/2.16.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/2.16.0    #2402      +/-   ##
==================================================
- Coverage           69.95%   69.77%   -0.18%     
==================================================
  Files                 763      763              
  Lines               28377    28367      -10     
  Branches             4763     4763              
==================================================
- Hits                19850    19792      -58     
- Misses               7232     7254      +22     
- Partials             1295     1321      +26     

see 28 files with indirect coverage changes

---- 🚨 Try these New Features:

0xnm
0xnm previously approved these changes Nov 20, 2024
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess version change from snapshot to stable will be done in another PR?

jonathanmos
jonathanmos previously approved these changes Nov 20, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ambushwork
Copy link
Member Author

@0xnm yes it is, this is only to update the changelog

@ambushwork ambushwork merged commit 1ce0263 into release/2.16.0 Nov 20, 2024
24 checks passed
@ambushwork ambushwork deleted the yl/2.16.0/update-changelog branch November 20, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants