Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fine-grained error messages to propagation.cpp #196

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dgoffredo
Copy link
Contributor

The goal of these changes is to make this nginx error

2021/06/22 14:13:09 [error] 40#40: *53
failed to extract an opentracing span context from request 00005629525E3D70:
opentracing: SpanContext data corrupted in Extract carrier

look instead like

2021/06/22 14:13:09 [error] 40#40: *53
failed to extract an opentracing span context from request 00005629525E3D70:
opentracing: span has a parent ID but does not have a trace ID, unable to deserialize SpanContext

(though for this particular example the new code actually would not produce an error).

As part of these changes, I remove specific mention of error codes from the unit test. Instead, the tests only check that some error is returned.

@dgoffredo dgoffredo force-pushed the david.goffredo/specific-error-messages branch 2 times, most recently from 9cbe3ad to c01184d Compare September 2, 2021 01:54
@dgoffredo dgoffredo requested a review from cgilmour September 2, 2021 17:05
@dgoffredo dgoffredo force-pushed the david.goffredo/specific-error-messages branch from c01184d to a8f32f6 Compare October 29, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant