Additional tcp metrics #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 13, 2014 15:10
Parse the results from nestat summary which is not ideal I have tried to use ctype and make calls to sysctl which is what netstat does under the hood but the values were not correct and this works tested on Mac OSX and on a OpenBSD 5.3 VM
Tested on a Solaris 11 VM from Oracle
|
Thanks! |
|
ok thanks. |
| # 165400 duplicate acks | ||
| # ... | ||
| metrics = { | ||
| re.compile("^\s*(\d+) data packets \(\d+ bytes\) retransmitted\s*$"): 'system.net.tcp.retrans_packs', |
There was a problem hiding this comment.
Could you make the compiled regex constants at the module level ?
This way they would get compiled only once which is a good practice as regex compiling is a bit CPU consuming.
| @@ -11,7 +11,17 @@ | |||
| # project | |||
| from checks import AgentCheck | |||
| from util import Platform | |||
| BSD_TCP_METRICS = { | |||
There was a problem hiding this comment.
Tiny perf nitpick, you shouldn't use a dictionary here as you are not going to query it by the keys.
It should be a list of tuples:
BSD_TCP_METRICS = [
(re.compile("^\s*(\d+) data packets \(\d+ bytes\) retransmitted\s*$"), 'system.net.tcp.retrans_packs'),
(re.compile("^\s*(\d+) packets sent\s*$"), 'system.net.tcp.sent_packs'),
(re.compile("^\s*(\d+) packets received\s*$"), 'system.net.tcp.rcv_packs'),
]and then you'll be able to iterate with:
for regex, metric_name in BSD_TCP_METRICS:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new network metrics to get information about tcp retransmits and tcp packets in/out