Basic monitoring support for Apache Mesos #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the great PR ! We will review and test on our end 🍖 |
|
fyi: if you're trying to setup up a test environment this may help: https://github.com/everpeace/vagrant-mesos |
| class Mesos(AgentCheck): | ||
| def check(self, instance): | ||
| if 'url' not in instance: | ||
| self.log.info("Skipping instance, no url found.") |
There was a problem hiding this comment.
Could you raise an Exception here instead ? The exception would then appear in the info page.
| response = self.get_master_stats(url, timeout) | ||
| if response is not None: | ||
| for key in iter(response): | ||
| self.gauge('mesos.stats.' + key, response[key], tags=['mesos']) |
There was a problem hiding this comment.
I don't think that this tag will be useful, do you have a use case for it ?
Also could you add support for custom tags (that would be defined in the yaml file) as we do in some other checks ?
Thanks!
There was a problem hiding this comment.
Sure I'll take a peek at the custom tags tomorrow and dispense with the 'mesos' tag.
clofresh
added a commit
that referenced
this pull request
May 5, 2014
Basic monitoring support for Apache Mesos
|
great, thanks! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic agent check for Apache Mesos that consumes Mesos REST API endpoints and emits Datadog metrics. We've been using this code successfully with the latest Mesos 0.18.0 release and it's proved sufficient to build some useful dashboards.
Mesos currently provides statistics from three endpoints which are translated into Datadog metrics:
/master/roles.json: list of running frameworks and resources being managed/master/stats.json: aggregated statistics about # of slaves, tasks, offers, etc/master/state.json: detailed information about frameworks, tasks, resources, etc.Hopefully others running Mesos will find this useful.