Mcache checksd fixes #390 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "threads", | ||
| "pointer_size", | ||
|
|
||
| # these are calculated from other metrics |
There was a problem hiding this comment.
Having these 3 metrics here is never used. You can remove them.
|
Good job once the nitpicks are fixed! |
|
Failing tests are unrelated. |
|
|
||
| tags = instance.get('tag', None) | ||
| if tags: | ||
| tags = ["instance:%s" % tags] |
There was a problem hiding this comment.
We're only allowing a single tag per instance here? Shouldn't we allow multiple tags?
There was a problem hiding this comment.
I can add that functionality. It wasn't in the previous check version. I assume the tags should each be of the 'instance:tag1', 'instance:tag2' format?
ghost
assigned
| ] | ||
|
|
||
| def __init__(self, name, init_config, agentConfig): | ||
| AgentCheck.__init__(self, name, init_config, agentConfig) |
There was a problem hiding this comment.
You don't need a constructor if all you do is calling the super constructor.
|
Nice job! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.