add check for kyoto tycoon #426
Conversation
| def check(self, instance): | ||
| url = instance.get('report_url') | ||
| if not url: | ||
| self.log.exception('Invalid Kyoto Tycoon report url %r', url) |
There was a problem hiding this comment.
You should let these "expected" exceptions bubble up. They'll be caught by the agent and will display in the "datadog-agent info" command (I'll add this to the docs today). Same with the couldn't connect exceptions, etc.
There was a problem hiding this comment.
Meaning I should remove the try/except at lines 53-58, and not check report_url here? huh, good to know.
There was a problem hiding this comment.
Yea, You can still check it if you want to raise a more informative message, just raise Exception("invalid url ...") instead of continuing.
|
Awesome @dcrosta. Thanks. Made one small comment (the others might have a little more). Can you also include an example conf.d config file as well? |
|
@clutchski sure -- where do example conf.d's go? |
|
thanks dan. may the tokyo tyrant reign forever. 🇯🇵 |
|
Tokyo tyrant is so 4 years ago, just ask @clofresh :P
On Mar 27, 2013, at 6:21 PM, Matt Perpick [email protected] wrote:
|
Open question for DataDog folks: should we submit rates per second for the opcounters rather than raw values? My instinct is to leave it like this, and let users use
rate()in graph definitions.