Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network metrics #396

Merged
merged 4 commits into from
Mar 7, 2013
Merged

Network metrics #396

merged 4 commits into from
Mar 7, 2013

Conversation

LotharSee
Copy link
Contributor

Update network metrics checks (except for Windows).

  • Migrate to checks.d
  • Introduce new packets metrics (in/out count and errors)
  • Add TCP and UDP stats for Linux

remh
remh reviewed Mar 7, 2013
View reviewed changes
tests/test_system.py
"""
check, instances = get_check('network', config)

from time import time
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you can get rid of that import

@remh
Copy link

remh commented Mar 7, 2013

Looks good. Merging it.

remh pushed a commit that referenced this pull request Mar 7, 2013
Merge pull request #396 from DataDog/network_metrics
bed14fd 
Network metrics
@remh remh merged commit bed14fd into master Mar 7, 2013
@LotharSee
Copy link
Contributor Author

Related to this issue: #379
Configuration explained in comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LotharSee @remh