Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential leak of API key in collector.log and dogstatsd.log #3537

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

zippolyte
Copy link
Contributor

Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.

What does this PR do?

Fix potential leak of API key in collector.log and dogstatsd.log. The requests module logs the url in its exception message, so the API key could appear.

@truthbk truthbk merged commit 6d7d5af into master Oct 3, 2017
@truthbk truthbk modified the milestones: 5.19.0, 5.18.0 Oct 3, 2017
@zippolyte zippolyte deleted the hippo/leak_dogstatsd_apikey branch October 4, 2017 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants