[AgentCheck] Deprecate read_config
#3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only used in one check (kafka_consumer) and its usefulness in AgentCheck is dubious IMO.
olivielpeau
force-pushed
the
olivielpeau/deprecate-read-config
branch
from
b8d5668 to
74fb40a
Compare
gmmeyer
approved these changes
Sep 7, 2017
derekwbrown
approved these changes
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecates
AgentCheck.read_config.Motivation
It's only used in one check (kafka_consumer) and its usefulness in
AgentCheck is dubious IMO.
Related to DataDog/integrations-core#733 (which removes the use of this method from the
kafka_consumercheck)