Fix parsing of units in Kubernetes resource quantities #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @markine |
|
Any updates here? I'm attempting a rebase of #2766 against latest and will be using this patch. |
markine
added a commit
to AltSchool/dd-agent
that referenced
this pull request
Oct 18, 2016
|
@markine thanks for the heads up, merged |
masci
pushed a commit
that referenced
this pull request
Oct 21, 2016
jcejohnson
pushed a commit
to EFXCIA/dd-agent
that referenced
this pull request
Oct 24, 2016
jcejohnson
pushed a commit
to EFXCIA/dd-agent
that referenced
this pull request
Oct 24, 2016
* Add patch from DataDog#2908 DataDog#2908 to beter handle units. * Port change from DataDog/dd-agent DataDog#2766 * Move machine info URL management into kubeutil * Update kubernetes tests for capacity data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes parsing of resource quantities in Kubernetes resources and limits. Right now suffixes like G, M, m, etc. get simply ignored, leading to wrong numbers (unless you manage to always end up with absolute bytes/CPU numbers without any units).
It's based on the second part of #2766, but with some optimizations (precomputing stuff once at the module level).