[core] add a switch to disable profiling, but still use developer mode #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the code @cberry777 and sorry I'm sooooo late responding! Thanks! |
|
Done. |
|
BTW: It makes no sense whatsoever that the tests fail now because I added a COMMENT to datadog.conf.example |
|
also -- when I run "rake" locally -- all is well> Ran 176 tests in 19.761s OK (SKIP=1) |
|
Not your fault, some tests in the CI are extremely flaky, all green! |
|
Hi Massimiliano,
Any way that this one : #2899 could also make it in??
We are having to extend you agent_metrics.py
And then hack: https://github.com/DataDog/dd-agent/blob/master/checks/__init__.py#L45 with a script.
So it is pretty dirty.
I’d love to remove our hack
I do think others will also like this addition!
I allows us to build some great dashboards of dd-agent in action.
THANKS,
-- Chris
From: Massimiliano Pippi <[email protected]>
Reply-To: DataDog/dd-agent <[email protected]>
Date: Saturday, December 3, 2016 at 6:54 AM
To: DataDog/dd-agent <[email protected]>
Cc: Chris Berry <[email protected]>, Mention <[email protected]>
Subject: Re: [DataDog/dd-agent] [core] add a switch to disable profiling, but still use developer mode (#2898)
Merged #2898<#2898>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2898 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANJ0k7E8NBTEPbvJv5br5p4p7t72AA7Oks5rEWacgaJpZM4KRi5z>.
|
degemer
added a commit
that referenced
this pull request
Dec 21, 2016
* master: (53 commits) [nginx] Update example config [service_discovery] Add a Zookeeper service discovery implementation. [aggregator] if sample rate is bad, fix it but still parse tags. (#3073) [yarn] whitelist authorized application_tags Alex poe/update jmx with refresh beans (#3068) [config] Fix `_is_affirmative` when passed argument is `None` (#3063) Send all configured tags with process checks. (#2976) fix flake8 errors [flare] ignore whitespace before proxy credentials [core] add a switch to disable profiling, but still use developer mode (#2898) [tests] allow tests to use the additional_checksd parameter (#3056) [service_discovery][jmx] trying to pick-up JMX changes with SD. (#3010) [install_script] Make `dd-agent` group of `datadog.conf` (#3036) [postgres] Allow disable postgresql.database_size (#3035) [core] Fixes IndexError for process lookup (#3043) remove warning message leaking password strings (#3053) trap psutil.NoSuchProcess exception (#3052) Fix grammar and casing in exception text (#3050) allow override of kubelet host with KUBERNETES_KUBELET_HOST env var [service discovery] properly handle config reload for removed containers ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a 'allow_profiling' switch to agentConfig. It defaults to True (the current behavior).
Motivation
We use 'developer_mode' to monitor our dd-agent, but do not want the added burden of the profiling. It is wise to keep track of what the dd-agent itself is doing (i.e. Watch the watcher!), and 'developer_mode' provides that functionality. The profiling bit is useful only when debugging a new Check.
Testing Guidelines
A test is provided: tests/checks/mocks/test_no_profiling.py
Additional Notes
None