[docker] Fall back to default route if docker hostname is not resolvable #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #2745 |
| for line in f.readlines(): | ||
| fields = line.strip().split() | ||
| if fields[1] == '00000000': | ||
| return socket.inet_ntoa(struct.pack('<L', int(fields[2], 16))) |
There was a problem hiding this comment.
We might need some fallback for ipv6 only systems... not sure how /proc/net/route would look in those cases. The file might even be ipv4-only given the format documented.
There was a problem hiding this comment.
This is to be run within a Docker container which doesn't support ipv6 only networks
|
Other than the ipv6 concern, this looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In case, the agent cannot resolve the docker host hostname, we fall back on the default gateway.
Motivation
Customer ticket on kubernetes where the agent was unable to resolve the docker host hostname.