[sdk] minor tweaks - sdk env detection, check location #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Let's merge once the CI passes |
|
Default, core_integration and checks_mock are 💚 . Merging. |
degemer
pushed a commit
that referenced
this pull request
Jul 25, 2016
* [sdk] check if SDK or not for integration and unit tests. * [tests] fixing for new sdk `integrations` path/, instead of `3rd-party`.
degemer
added a commit
that referenced
this pull request
Jul 28, 2016
* master: (119 commits) [core] remove noisy logs (#2715) run multiple instances of pylint (#2716) [packaging] Release 5.8.5 (#2712) [changelog][5.8.5] Add notes on packaging changes (#2710) [changelog] Update 5.8.5 with python upgrade be more specific when logging ssh errors (#2708) [marathon] allow base_url with path (#2620) [changelog] Update 5.8.5 add issue and pr templates [sdk] minor tweaks - sdk env detection, check location (#2694) [http_check] log exceptions 🔊 use 0.0.0.0 as server address when non_local_traffic is passed (#2691) [elastic] tag stats metric with the node name 🏷 (#2696) [openstack] moving proxy logic to AgentCheck, for maintainability. Fixing typos. [changelog] 5.8.5 draft [tests] lower flakiness of test_no_parallelism (#2690) [core] don't use docker hostname if it's a EC2 one (#2661) [haproxy] Fix `KeyError` when an unknown status is found (#2681) [changelog] Fix md links [jenkins] Deprecate check (#2688) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AgentCheckTest.load_check()andload_check()intests.checks.commonare both needed, one by integration tests, the other by unit tests (respectively). We could maybe get rid of the former but it would involve too many changes at the moment. The proposed changes will allow both unit tests (if added in the SDK) and integration tests to correctly load the checks in the testing infrastructure.Also, because integrations-core would've been dropped into
3rd-party, and that is misleading, renaming todd-integrations.