Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] disable use_histogram by default #2542

Merged
merged 1 commit into from
May 26, 2016

Conversation

hkaj
Copy link
Member

@hkaj hkaj commented May 25, 2016

No description provided.

@@ -7,20 +7,20 @@ instances:
# The kubernetes check retrieves metrics from cadvisor running under kubelet.
# By default we will assume we're running under docker and will use the address
# of the default router to reach the cadvisor api.
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@degemer
Copy link
Member

degemer commented May 25, 2016

Indeed False is already the default in the code (

self.use_histogram = _is_affirmative(instance.get('use_histogram', DEFAULT_USE_HISTOGRAM))
)
👍

@hkaj hkaj merged commit 34c1bc7 into master May 26, 2016
@hkaj hkaj deleted the haissam/kubernetes-yaml-remove-use-hist branch May 26, 2016 08:57
degemer added a commit that referenced this pull request Jun 7, 2016
* master: (21 commits)
  [Postgres] hard limit on pg count metric (#2575)
  [procfs] make /proc configurable.
  [sqlserver] send service checks at every run (#2515)
  [http_check] SNI support for cert_expiration (#2521)
  [dev-env] DL ez_setup from preferred URL
  Example syntax using a wildcard, recommended by customer see ticket https://datadog.zendesk.com/agent/tickets/54475
  [collector] don't send the api_key with resources
  [checks] remove api_key from events payload
  [packaging] 5.9.0 nightlies
  [win32] plays well memory check timeouts
  [rabbitmq] Avoid the extra double lookup for 'rabbitmq_api_url' (#2543)
  [source] archive setuptools
  Added a note on how to get bundler installed
  [kubernetes] disable use_histogram by default (#2542)
  [powerdns_recursor] rename configuration file (#2538)
  [changelog] release 5.8.2
  Revert "Fix get_hostname for windows ec2 instances"
  [changelog] release `5.8.1`
  fixes .yaml.default
  [core] fixes windows conf (#2528)
  ...
@olivielpeau olivielpeau added this to the 5.9.0 milestone Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants