[network] Support netstat in Windows #2352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements #2350
|
Is the Travis build working at all? The build log seems to have lots of errors unrelated to my changes. |
Apparently there's a typo in the Microsoft documentation
|
Thanks @mausch for this addition! We've had a lot of errors on Python 2.6 lately but we're in the process of removing support of Python 2.6. The tests related to your changes are passing. We'll spend some time soon to review and test your PR. |
|
|
||
| def _parse_windows_netstat(self, netstat): | ||
| state_map = Network.TCP_STATES['netstat_windows'] | ||
| lines = netstat.split('\n') |
There was a problem hiding this comment.
you should use netstat.splitlines() here instead.
|
Looks good besides the nitpick, could you rebase against the master branch and also squash your commits please ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2350