[core][windows] restore 'run_check' from 'checks' #1671
Merged
+67
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| def get_check(name, config_str): | ||
| from checks import AgentCheck |
There was a problem hiding this comment.
Is there a reason why you import AgentCheck here instead of the top of the file ?
There was a problem hiding this comment.
to avoid cyclic dependencies, i.e.
checks/__init__.pyimportsdebug.pyto loaddebug.pyimportschecks/__init__.pyto loadchecks/__init__.pyimportsdebug.py...
PR #1571 introduced a bad regression: 'run_check' method was deleted beside it is still used on Windows to debug.
yannmh
force-pushed
the
yann/win-debug-module
branch
from
face859 to
d6950ce
Compare
yannmh
added a commit
that referenced
this pull request
Jun 10, 2015
[core][windows] restore 'run_check' from 'checks'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1571 introduced a bad regression: 'run_check' method was deleted
beside it is still used on Windows to debug.