redisdb: add replication service check and 'down since' metric #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The service check is named |
pbitty
force-pushed
the
redis_replication_service_check
branch
from
b73695f to
dfc63f1
Compare
|
Thanks a bunch a @pbitty ! Our master branch is currently frozen for the preparation of our 5.2.0 release. We'll review your pull request for our 5.3.0 release. |
|
Thanks @remh . I just added a time.sleep to the tests, to make sure some metrics can build up. I had this in the tests but lost it on a rebase. |
|
@pbitty Could you merge the master branch back to your branch and fix the conflicts please ? We can't merge it as is. Thanks a lot ! |
|
Thanks @remh. Sorry for the late response. I was on vacation with no internet connection at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a service checks for redis slaves, which reports CRITICAL when the slave loses a link with the master. It will also report the amount of seconds the link has been down.