Rudy/snmp table #1005
Merged
Rudy/snmp table #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
June 26, 2014 11:53
Also remove an unused variable
|
👍 |
| interface_type = tag.split(":")[1] | ||
| try: | ||
| float(interface_type) | ||
| except: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the snmp checks, modifying the way we query things.
Switching from doing snmpgets on the value specified in the configuration to
doing snmpwalks on domain specified by the user and gathering information from the results.
For completely specified objects, this doesn't change anything.
It allows for more powerful query: can query table whose size is not known at configuration time, can query object being in a table with multiple indexes, gather information for tags from the indexes or use information contained in other columns of the row as tags for the results we want.
I will also update the documentation in the documentation website with detailed examples.