[powerdns_recursor] adds support for v4. #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for v3 and v4 recursive servers
…ailing to read docs properly
…e configuration in tests
…with the separate configuration files
truthbk
force-pushed
the
jaime/jimmystewpot/powerdns
branch
from
0602b6c to
94a81a6
Compare
[powerdns] fixing rubocop offenses.
truthbk
force-pushed
the
jaime/jimmystewpot/powerdns
branch
from
94a81a6 to
31095de
Compare
|
@jimmystewpot so the issue you encountered with the CI remotely was due to the TravisCI workers not being able to compile the power DNS binary we use in the tests. These need a |
|
Thanks again for your awesome work! Merging! |
This was referenced Feb 1, 2017
degemer
added a commit
that referenced
this pull request
Feb 7, 2017
* master: (67 commits) [network] dont combine connection states (#3158) renames function in line with other checks [couchbase] Modified service_check_tags in couchbase.py to include user-specified tags. (#3079) [docker] fix image tag extraction Fix tests, refactor how we collect container and volume states test_docker_daemon.py: fix syntax errors Beginning work on docker_daemon tests. Add 5 opt-in checks to docker_daemon add mention of office hours (#3171) updates psycopg2 to 2.6.2 (#3170) [trace-agent] adding output of 'trace-agent -info' (#3164) [riak] Change default value in configuration example to match default value from the code move setting parameter to instance level riak security support [dns_check][ci] Bring back assertions on metrics (#3162) [powerdns_recursor] adds support for v4. (#3166) [tcp_check] Add custom tags to response_time gauge catch can't connect instead of failing on nodata found (#3127) [php-fpm] add http_host tag [dns_check] Document NXDOMAIN usage in yaml example file ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
All Agent Checks are now frozen in preparation for the release of the Integration SDK.
We will review and merge a few more PRs, but no new PRs will be accepted.
All changes to checks from here on out should go to the integrations-core repo and all new checks should go to the integrations-extras repo. To learn more about how to contribute to them, please check out our documentation.
What does this PR do?
This PR is just fix to #3066 and should supersede that PR. I was unable to push into your branch @jimmystewpot, so I had to open a new one.
The feature here included is the work of @jimmystewpot, all credit goes to him.
Motivation
We're closing up PR's that were practically ready barring for a few minor details in preparation for the transition to the SDK, and to keep the freeze period as short as possibly.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.